* [PATCH 1/2] drm/amd/display: make is_synaptics_cascaded_panamera static
@ 2023-03-16 9:51 Jiapeng Chong
2023-03-16 9:51 ` [PATCH 2/2] drm/amd/display: Remove the unused function link_timing_bandwidth_kbps() Jiapeng Chong
2023-03-16 14:28 ` [PATCH 1/2] drm/amd/display: make is_synaptics_cascaded_panamera static Hamza Mahfooz
0 siblings, 2 replies; 3+ messages in thread
From: Jiapeng Chong @ 2023-03-16 9:51 UTC (permalink / raw)
To: alexander.deucher
Cc: Jiapeng Chong, Xinhui.Pan, Abaci Robot, linux-kernel, amd-gfx,
dri-devel, daniel, airlied, christian.koenig
This symbol is not used outside of amdgpu_dm_mst_types.c, so marks it
static.
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_mst_types.c:211:6: warning: no previous prototype for ‘is_synaptics_cascaded_panamera’.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4548
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
index 6378352346c8..994ba426ca66 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
@@ -208,7 +208,7 @@ bool needs_dsc_aux_workaround(struct dc_link *link)
return false;
}
-bool is_synaptics_cascaded_panamera(struct dc_link *link, struct drm_dp_mst_port *port)
+static bool is_synaptics_cascaded_panamera(struct dc_link *link, struct drm_dp_mst_port *port)
{
u8 branch_vendor_data[4] = { 0 }; // Vendor data 0x50C ~ 0x50F
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] drm/amd/display: Remove the unused function link_timing_bandwidth_kbps()
2023-03-16 9:51 [PATCH 1/2] drm/amd/display: make is_synaptics_cascaded_panamera static Jiapeng Chong
@ 2023-03-16 9:51 ` Jiapeng Chong
2023-03-16 14:28 ` [PATCH 1/2] drm/amd/display: make is_synaptics_cascaded_panamera static Hamza Mahfooz
1 sibling, 0 replies; 3+ messages in thread
From: Jiapeng Chong @ 2023-03-16 9:51 UTC (permalink / raw)
To: alexander.deucher
Cc: Jiapeng Chong, Xinhui.Pan, Abaci Robot, linux-kernel, amd-gfx,
dri-devel, daniel, airlied, christian.koenig
The function link_timing_bandwidth_kbps is defined in the
link_validation.c file, but not called elsewhere, so remove this unused
function.
drivers/gpu/drm/amd/amdgpu/../display/dc/link/link_validation.c:258:10: warning: no previous prototype for ‘link_timing_bandwidth_kbps’.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4547
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
.../drm/amd/display/dc/link/link_validation.c | 51 -------------------
1 file changed, 51 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/link/link_validation.c b/drivers/gpu/drm/amd/display/dc/link/link_validation.c
index 9a5010f86003..afbd22631721 100644
--- a/drivers/gpu/drm/amd/display/dc/link/link_validation.c
+++ b/drivers/gpu/drm/amd/display/dc/link/link_validation.c
@@ -255,57 +255,6 @@ uint32_t dp_link_bandwidth_kbps(
return link_rate_per_lane_kbps * link_settings->lane_count / 10000 * total_data_bw_efficiency_x10000;
}
-uint32_t link_timing_bandwidth_kbps(const struct dc_crtc_timing *timing)
-{
- uint32_t bits_per_channel = 0;
- uint32_t kbps;
-
- if (timing->flags.DSC)
- return dc_dsc_stream_bandwidth_in_kbps(timing,
- timing->dsc_cfg.bits_per_pixel,
- timing->dsc_cfg.num_slices_h,
- timing->dsc_cfg.is_dp);
-
- switch (timing->display_color_depth) {
- case COLOR_DEPTH_666:
- bits_per_channel = 6;
- break;
- case COLOR_DEPTH_888:
- bits_per_channel = 8;
- break;
- case COLOR_DEPTH_101010:
- bits_per_channel = 10;
- break;
- case COLOR_DEPTH_121212:
- bits_per_channel = 12;
- break;
- case COLOR_DEPTH_141414:
- bits_per_channel = 14;
- break;
- case COLOR_DEPTH_161616:
- bits_per_channel = 16;
- break;
- default:
- ASSERT(bits_per_channel != 0);
- bits_per_channel = 8;
- break;
- }
-
- kbps = timing->pix_clk_100hz / 10;
- kbps *= bits_per_channel;
-
- if (timing->flags.Y_ONLY != 1) {
- /*Only YOnly make reduce bandwidth by 1/3 compares to RGB*/
- kbps *= 3;
- if (timing->pixel_encoding == PIXEL_ENCODING_YCBCR420)
- kbps /= 2;
- else if (timing->pixel_encoding == PIXEL_ENCODING_YCBCR422)
- kbps = kbps * 2 / 3;
- }
-
- return kbps;
-}
-
static bool dp_validate_mode_timing(
struct dc_link *link,
const struct dc_crtc_timing *timing)
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] drm/amd/display: make is_synaptics_cascaded_panamera static
2023-03-16 9:51 [PATCH 1/2] drm/amd/display: make is_synaptics_cascaded_panamera static Jiapeng Chong
2023-03-16 9:51 ` [PATCH 2/2] drm/amd/display: Remove the unused function link_timing_bandwidth_kbps() Jiapeng Chong
@ 2023-03-16 14:28 ` Hamza Mahfooz
1 sibling, 0 replies; 3+ messages in thread
From: Hamza Mahfooz @ 2023-03-16 14:28 UTC (permalink / raw)
To: Jiapeng Chong, alexander.deucher
Cc: Xinhui.Pan, Abaci Robot, linux-kernel, dri-devel, amd-gfx,
daniel, airlied, christian.koenig
On 3/16/23 05:51, Jiapeng Chong wrote:
> This symbol is not used outside of amdgpu_dm_mst_types.c, so marks it
> static.
>
> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_mst_types.c:211:6: warning: no previous prototype for ‘is_synaptics_cascaded_panamera’.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4548
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
I applied the series, thanks!
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> index 6378352346c8..994ba426ca66 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> @@ -208,7 +208,7 @@ bool needs_dsc_aux_workaround(struct dc_link *link)
> return false;
> }
>
> -bool is_synaptics_cascaded_panamera(struct dc_link *link, struct drm_dp_mst_port *port)
> +static bool is_synaptics_cascaded_panamera(struct dc_link *link, struct drm_dp_mst_port *port)
> {
> u8 branch_vendor_data[4] = { 0 }; // Vendor data 0x50C ~ 0x50F
>
--
Hamza
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-16 14:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-16 9:51 [PATCH 1/2] drm/amd/display: make is_synaptics_cascaded_panamera static Jiapeng Chong
2023-03-16 9:51 ` [PATCH 2/2] drm/amd/display: Remove the unused function link_timing_bandwidth_kbps() Jiapeng Chong
2023-03-16 14:28 ` [PATCH 1/2] drm/amd/display: make is_synaptics_cascaded_panamera static Hamza Mahfooz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).