* [PATCH 0/1] DC PATCH fix
@ 2020-06-18 19:49 Qingqing Zhuo
2020-06-18 19:49 ` [PATCH 1/1] drm/amd/display: fix compilation error on allmodconfig Qingqing Zhuo
0 siblings, 1 reply; 4+ messages in thread
From: Qingqing Zhuo @ 2020-06-18 19:49 UTC (permalink / raw)
To: amd-gfx
Cc: Lewis.Huang, Aric.Cyr, sfr, Harry.Wentland, Alexander.Deucher,
Bhawanpreet.Lakha, Nicholas.Kazlauskas
An issue is reported regarding compilation errors
on upstream branch. The corresponding fix has been
attached below for review.
Qingqing Zhuo (1):
drm/amd/display: fix compilation error on allmodconfig
drivers/gpu/drm/amd/display/modules/color/Makefile | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
--
2.17.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/1] drm/amd/display: fix compilation error on allmodconfig
2020-06-18 19:49 [PATCH 0/1] DC PATCH fix Qingqing Zhuo
@ 2020-06-18 19:49 ` Qingqing Zhuo
2020-06-19 15:27 ` Alex Deucher
0 siblings, 1 reply; 4+ messages in thread
From: Qingqing Zhuo @ 2020-06-18 19:49 UTC (permalink / raw)
To: amd-gfx
Cc: Lewis.Huang, Aric.Cyr, sfr, Harry.Wentland, Harry Wentland,
Alexander.Deucher, Bhawanpreet.Lakha, Nicholas.Kazlauskas
when compiled with allmodconfig option, there are error
messages as below:
ERROR: modpost:
"mod_color_is_table_init"
[drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
ERROR: modpost:
"mod_color_get_table"
[drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
ERROR: modpost:
"mod_color_set_table_init_state"
[drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
To fix the issue, this commits removes
CONFIG_DRM_AMD_DC_DCN guard in color/makefile.
Signed-off-by: Qingqing Zhuo <qingqing.zhuo@amd.com>
CC: Lewis Huang <Lewis.Huang@amd.com>
CC: Aric Cyr <Aric.Cyr@amd.com>
CC: Alexander Deucher <Alexander.Deucher@amd.com>
CC: Harry Wentland <hwentlan@amd.com>
CC: Nicholas Kazlauskas <Nicholas.Kazlauskas@amd.com>
CC: Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>
CC: Stephen Rothwell <sfr@canb.auug.org.au>
---
drivers/gpu/drm/amd/display/modules/color/Makefile | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/modules/color/Makefile b/drivers/gpu/drm/amd/display/modules/color/Makefile
index 3ee7f27ff93b..e66c19a840c2 100644
--- a/drivers/gpu/drm/amd/display/modules/color/Makefile
+++ b/drivers/gpu/drm/amd/display/modules/color/Makefile
@@ -23,11 +23,7 @@
# Makefile for the color sub-module of DAL.
#
-MOD_COLOR = color_gamma.o
-
-ifdef CONFIG_DRM_AMD_DC_DCN
-MOD_COLOR += color_table.o
-endif
+MOD_COLOR = color_gamma.o color_table.o
AMD_DAL_MOD_COLOR = $(addprefix $(AMDDALPATH)/modules/color/,$(MOD_COLOR))
#$(info ************ DAL COLOR MODULE MAKEFILE ************)
--
2.17.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] drm/amd/display: fix compilation error on allmodconfig
2020-06-18 19:49 ` [PATCH 1/1] drm/amd/display: fix compilation error on allmodconfig Qingqing Zhuo
@ 2020-06-19 15:27 ` Alex Deucher
2020-06-19 16:24 ` Kazlauskas, Nicholas
0 siblings, 1 reply; 4+ messages in thread
From: Alex Deucher @ 2020-06-19 15:27 UTC (permalink / raw)
To: Qingqing Zhuo
Cc: Lewis Huang, Cyr, Aric, Stephen Rothwell, Wentland, Harry,
amd-gfx list, Bhawanpreet Lakha, Deucher, Alexander,
Harry Wentland, Kazlauskas, Nicholas
On Thu, Jun 18, 2020 at 3:49 PM Qingqing Zhuo <qingqing.zhuo@amd.com> wrote:
>
> when compiled with allmodconfig option, there are error
> messages as below:
>
> ERROR: modpost:
> "mod_color_is_table_init"
> [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
> ERROR: modpost:
> "mod_color_get_table"
> [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
> ERROR: modpost:
> "mod_color_set_table_init_state"
> [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
>
> To fix the issue, this commits removes
> CONFIG_DRM_AMD_DC_DCN guard in color/makefile.
>
> Signed-off-by: Qingqing Zhuo <qingqing.zhuo@amd.com>
> CC: Lewis Huang <Lewis.Huang@amd.com>
> CC: Aric Cyr <Aric.Cyr@amd.com>
> CC: Alexander Deucher <Alexander.Deucher@amd.com>
> CC: Harry Wentland <hwentlan@amd.com>
> CC: Nicholas Kazlauskas <Nicholas.Kazlauskas@amd.com>
> CC: Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>
> CC: Stephen Rothwell <sfr@canb.auug.org.au>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/gpu/drm/amd/display/modules/color/Makefile | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/modules/color/Makefile b/drivers/gpu/drm/amd/display/modules/color/Makefile
> index 3ee7f27ff93b..e66c19a840c2 100644
> --- a/drivers/gpu/drm/amd/display/modules/color/Makefile
> +++ b/drivers/gpu/drm/amd/display/modules/color/Makefile
> @@ -23,11 +23,7 @@
> # Makefile for the color sub-module of DAL.
> #
>
> -MOD_COLOR = color_gamma.o
> -
> -ifdef CONFIG_DRM_AMD_DC_DCN
> -MOD_COLOR += color_table.o
> -endif
> +MOD_COLOR = color_gamma.o color_table.o
>
> AMD_DAL_MOD_COLOR = $(addprefix $(AMDDALPATH)/modules/color/,$(MOD_COLOR))
> #$(info ************ DAL COLOR MODULE MAKEFILE ************)
> --
> 2.17.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] drm/amd/display: fix compilation error on allmodconfig
2020-06-19 15:27 ` Alex Deucher
@ 2020-06-19 16:24 ` Kazlauskas, Nicholas
0 siblings, 0 replies; 4+ messages in thread
From: Kazlauskas, Nicholas @ 2020-06-19 16:24 UTC (permalink / raw)
To: Alex Deucher, Qingqing Zhuo
Cc: Lewis Huang, Cyr, Aric, Stephen Rothwell, Wentland, Harry,
amd-gfx list, Bhawanpreet Lakha, Deucher, Alexander,
Harry Wentland
On 2020-06-19 11:27 a.m., Alex Deucher wrote:
> On Thu, Jun 18, 2020 at 3:49 PM Qingqing Zhuo <qingqing.zhuo@amd.com> wrote:
>>
>> when compiled with allmodconfig option, there are error
>> messages as below:
>>
>> ERROR: modpost:
>> "mod_color_is_table_init"
>> [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
>> ERROR: modpost:
>> "mod_color_get_table"
>> [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
>> ERROR: modpost:
>> "mod_color_set_table_init_state"
>> [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
>>
>> To fix the issue, this commits removes
>> CONFIG_DRM_AMD_DC_DCN guard in color/makefile.
>>
>> Signed-off-by: Qingqing Zhuo <qingqing.zhuo@amd.com>
>> CC: Lewis Huang <Lewis.Huang@amd.com>
>> CC: Aric Cyr <Aric.Cyr@amd.com>
>> CC: Alexander Deucher <Alexander.Deucher@amd.com>
>> CC: Harry Wentland <hwentlan@amd.com>
>> CC: Nicholas Kazlauskas <Nicholas.Kazlauskas@amd.com>
>> CC: Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>
>> CC: Stephen Rothwell <sfr@canb.auug.org.au>
>
> Acked-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
>
>> ---
>> drivers/gpu/drm/amd/display/modules/color/Makefile | 6 +-----
>> 1 file changed, 1 insertion(+), 5 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/display/modules/color/Makefile b/drivers/gpu/drm/amd/display/modules/color/Makefile
>> index 3ee7f27ff93b..e66c19a840c2 100644
>> --- a/drivers/gpu/drm/amd/display/modules/color/Makefile
>> +++ b/drivers/gpu/drm/amd/display/modules/color/Makefile
>> @@ -23,11 +23,7 @@
>> # Makefile for the color sub-module of DAL.
>> #
>>
>> -MOD_COLOR = color_gamma.o
>> -
>> -ifdef CONFIG_DRM_AMD_DC_DCN
>> -MOD_COLOR += color_table.o
>> -endif
>> +MOD_COLOR = color_gamma.o color_table.o
>>
>> AMD_DAL_MOD_COLOR = $(addprefix $(AMDDALPATH)/modules/color/,$(MOD_COLOR))
>> #$(info ************ DAL COLOR MODULE MAKEFILE ************)
>> --
>> 2.17.1
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-06-19 16:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-18 19:49 [PATCH 0/1] DC PATCH fix Qingqing Zhuo
2020-06-18 19:49 ` [PATCH 1/1] drm/amd/display: fix compilation error on allmodconfig Qingqing Zhuo
2020-06-19 15:27 ` Alex Deucher
2020-06-19 16:24 ` Kazlauskas, Nicholas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).