From: Felix Kuehling <felix.kuehling@amd.com>
To: Joseph Greathouse <Joseph.Greathouse@amd.com>,
amd-gfx@lists.freedesktop.org
Cc: Hawking.Zhang@amd.com
Subject: Re: [PATCH] Update NV SIMD-per-CU to 2
Date: Mon, 3 May 2021 13:46:29 -0400 [thread overview]
Message-ID: <734dca50-0d14-6822-87e9-5d8defc6038f@amd.com> (raw)
In-Reply-To: <20210503172557.1130985-1-Joseph.Greathouse@amd.com>
Am 2021-05-03 um 1:25 p.m. schrieb Joseph Greathouse:
> Navi series GPUs have 2 SIMDs per CU (and then 2 CUs per WGP).
> The NV enum headers incorrectly listed this as 4, which later meant
> we were incorrectly reporting the number of SIMDs in the HSA
> topology. This could cause problems down the line for user-space
> applications that want to launch a fixed amount of work to each
> SIMD.
>
> Signed-off-by: Joseph Greathouse <Joseph.Greathouse@amd.com>
> Change-Id: I94021ca71363a3d27330b2fda8e6acaac258017e
Please remove the Change-Id. You can disable generation of Change-Ids in
your kernel repository with this command:
git config --bool gerrit.createChangeId false
The change looks good to me. As far as I can see in the code this would
fix both the simd_count and simd_per_cu properties in the KFD topology.
I don't see this value used anywhere else in amdgpu, so there shouldn't
be any other unexpected side effects.
Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
> ---
> drivers/gpu/drm/amd/include/navi10_enum.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/include/navi10_enum.h b/drivers/gpu/drm/amd/include/navi10_enum.h
> index d5ead9680c6e..84bcb96f76ea 100644
> --- a/drivers/gpu/drm/amd/include/navi10_enum.h
> +++ b/drivers/gpu/drm/amd/include/navi10_enum.h
> @@ -430,7 +430,7 @@ ARRAY_2D_DEPTH = 0x00000001,
> */
>
> typedef enum ENUM_NUM_SIMD_PER_CU {
> -NUM_SIMD_PER_CU = 0x00000004,
> +NUM_SIMD_PER_CU = 0x00000002,
> } ENUM_NUM_SIMD_PER_CU;
>
> /*
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2021-05-03 17:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-03 17:25 [PATCH] Update NV SIMD-per-CU to 2 Joseph Greathouse
2021-05-03 17:37 ` Deucher, Alexander
2021-05-03 17:46 ` Felix Kuehling [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=734dca50-0d14-6822-87e9-5d8defc6038f@amd.com \
--to=felix.kuehling@amd.com \
--cc=Hawking.Zhang@amd.com \
--cc=Joseph.Greathouse@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).