From: Nirmoy <nirmodas@amd.com>
To: Luben Tuikov <luben.tuikov@amd.com>,
Nirmoy Das <nirmoy.aiemd@gmail.com>,
amd-gfx@lists.freedesktop.org
Cc: alexander.deucher@amd.com, nirmoy.das@amd.com, christian.koenig@amd.com
Subject: Re: [PATCH] drm/scheduler: fix documentation by replacing rq_list with sched_list
Date: Fri, 17 Jan 2020 11:59:23 +0100 [thread overview]
Message-ID: <8080c3c5-0d8d-5f85-011a-1edf4074eda9@amd.com> (raw)
In-Reply-To: <cec773a9-8040-ee55-c73b-f7165a117696@amd.com>
Hi Luben,
On 1/16/20 6:13 PM, Luben Tuikov wrote:
>> - * Note: the rq_list should have atleast one element to schedule
>> + * Note: the sched_list should have atleast one element to schedule
> "atleast" --> "at least".
Always a tricky one to catch, Thanks!
I will create a patch and ask Alex to squash with this one.
>
>> - * @num_rq_list: number of run queues in the rq_list
>> + * @sched_list: a list of drm_gpu_schedulers on which jobs from this entity can
>> + * be scheduled
> I had to read this a few times to understand it. I wonder if splitting
> it into two sentences would make it clearer:
>
> "A list of schedulers (drm_gpu_schedulers). Jobs from this entity,
> can be scheduled on any scheduler on this list."
I don't know, both feels right to me. Please create a patch if you think
this splitting makes it more clearer.
Regards,
Nirmoy
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2020-01-17 10:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 14:43 [PATCH] drm/scheduler: fix documentation by replacing rq_list with sched_list Nirmoy Das
2020-01-16 15:22 ` Christian König
2020-01-16 17:13 ` Luben Tuikov
2020-01-17 10:59 ` Nirmoy [this message]
2020-01-20 15:39 ` Luben Tuikov
-- strict thread matches above, loose matches on Subject: below --
2020-01-14 9:58 Nirmoy Das
2020-01-14 10:22 ` Christian König
2020-01-15 2:14 ` Yuan, Xiaojie
2020-01-15 10:44 ` Nirmoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8080c3c5-0d8d-5f85-011a-1edf4074eda9@amd.com \
--to=nirmodas@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=luben.tuikov@amd.com \
--cc=nirmoy.aiemd@gmail.com \
--cc=nirmoy.das@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).