From: "Christian König" <christian.koenig@amd.com>
To: Nirmoy Das <nirmoy.aiemd@gmail.com>, amd-gfx@lists.freedesktop.org
Cc: alexander.deucher@amd.com, nirmoy.das@amd.com
Subject: Re: [PATCH] drm/scheduler: fix documentation by replacing rq_list with sched_list
Date: Thu, 16 Jan 2020 16:22:26 +0100 [thread overview]
Message-ID: <d77b5c95-78b0-b62d-f6ca-8b25fe8de45c@amd.com> (raw)
In-Reply-To: <20200116144320.109044-1-nirmoy.das@amd.com>
Am 16.01.20 um 15:43 schrieb Nirmoy Das:
> This also replaces old artifacts with a correct one in drm_sched_entity_init()
> declaration
>
> Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/scheduler/sched_entity.c | 2 +-
> include/drm/gpu_scheduler.h | 10 +++++-----
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/scheduler/sched_entity.c b/drivers/gpu/drm/scheduler/sched_entity.c
> index 33e2cd1089a2..ec79e8e5ad3c 100644
> --- a/drivers/gpu/drm/scheduler/sched_entity.c
> +++ b/drivers/gpu/drm/scheduler/sched_entity.c
> @@ -45,7 +45,7 @@
> * @guilty: atomic_t set to 1 when a job on this queue
> * is found to be guilty causing a timeout
> *
> - * Note: the rq_list should have atleast one element to schedule
> + * Note: the sched_list should have atleast one element to schedule
> * the entity
> *
> * Returns 0 on success or a negative error code on failure.
> diff --git a/include/drm/gpu_scheduler.h b/include/drm/gpu_scheduler.h
> index 537f7a4655a5..9e71be129c30 100644
> --- a/include/drm/gpu_scheduler.h
> +++ b/include/drm/gpu_scheduler.h
> @@ -52,9 +52,9 @@ enum drm_sched_priority {
> * @list: used to append this struct to the list of entities in the
> * runqueue.
> * @rq: runqueue on which this entity is currently scheduled.
> - * @rq_list: a list of run queues on which jobs from this entity can
> - * be scheduled
> - * @num_rq_list: number of run queues in the rq_list
> + * @sched_list: a list of drm_gpu_schedulers on which jobs from this entity can
> + * be scheduled
> + * @num_sched_list: number of drm_gpu_schedulers in the sched_list.
> * @rq_lock: lock to modify the runqueue to which this entity belongs.
> * @job_queue: the list of jobs of this entity.
> * @fence_seq: a linearly increasing seqno incremented with each
> @@ -81,8 +81,8 @@ enum drm_sched_priority {
> struct drm_sched_entity {
> struct list_head list;
> struct drm_sched_rq *rq;
> - unsigned int num_sched_list;
> struct drm_gpu_scheduler **sched_list;
> + unsigned int num_sched_list;
> enum drm_sched_priority priority;
> spinlock_t rq_lock;
>
> @@ -315,7 +315,7 @@ void drm_sched_rq_remove_entity(struct drm_sched_rq *rq,
> int drm_sched_entity_init(struct drm_sched_entity *entity,
> enum drm_sched_priority priority,
> struct drm_gpu_scheduler **sched_list,
> - unsigned int num_rq_list,
> + unsigned int num_sched_list,
> atomic_t *guilty);
> long drm_sched_entity_flush(struct drm_sched_entity *entity, long timeout);
> void drm_sched_entity_fini(struct drm_sched_entity *entity);
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2020-01-16 15:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 14:43 [PATCH] drm/scheduler: fix documentation by replacing rq_list with sched_list Nirmoy Das
2020-01-16 15:22 ` Christian König [this message]
2020-01-16 17:13 ` Luben Tuikov
2020-01-17 10:59 ` Nirmoy
2020-01-20 15:39 ` Luben Tuikov
-- strict thread matches above, loose matches on Subject: below --
2020-01-14 9:58 Nirmoy Das
2020-01-14 10:22 ` Christian König
2020-01-15 2:14 ` Yuan, Xiaojie
2020-01-15 10:44 ` Nirmoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d77b5c95-78b0-b62d-f6ca-8b25fe8de45c@amd.com \
--to=christian.koenig@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=nirmoy.aiemd@gmail.com \
--cc=nirmoy.das@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).