amd-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] drm/amd/display: Update DCN302 SR Exit Latency
@ 2021-04-08 17:10 Aurabindo Pillai
  2021-04-08 17:46 ` Harry Wentland
  0 siblings, 1 reply; 3+ messages in thread
From: Aurabindo Pillai @ 2021-04-08 17:10 UTC (permalink / raw)
  To: amd-gfx; +Cc: aurabindo.pillai, Bindu.R

From: Joshua Aberback <joshua.aberback@amd.com>

[Why&How]
Update SR Exit Latency to fix screen flickering caused due to OTG
underflow. This is the recommended value given by the hardware IP team.

Signed-off-by: Joshua Aberback <joshua.aberback@amd.com>
Acked-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
---
 drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c b/drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c
index a928c1d9a557..fc2dea243d1b 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c
@@ -164,7 +164,7 @@ struct _vcs_dpi_soc_bounding_box_st dcn3_02_soc = {
 
 		.min_dcfclk = 500.0, /* TODO: set this to actual min DCFCLK */
 		.num_states = 1,
-		.sr_exit_time_us = 12,
+		.sr_exit_time_us = 15.5,
 		.sr_enter_plus_exit_time_us = 20,
 		.urgent_latency_us = 4.0,
 		.urgent_latency_pixel_data_only_us = 4.0,
-- 
2.31.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] drm/amd/display: Update DCN302 SR Exit Latency
  2021-04-08 17:10 [PATCH v2] drm/amd/display: Update DCN302 SR Exit Latency Aurabindo Pillai
@ 2021-04-08 17:46 ` Harry Wentland
  2021-04-08 18:01   ` Aurabindo Pillai
  0 siblings, 1 reply; 3+ messages in thread
From: Harry Wentland @ 2021-04-08 17:46 UTC (permalink / raw)
  To: Aurabindo Pillai, amd-gfx; +Cc: Bindu.R

On 2021-04-08 1:10 p.m., Aurabindo Pillai wrote:
> From: Joshua Aberback <joshua.aberback@amd.com>
> 
> [Why&How]
> Update SR Exit Latency to fix screen flickering caused due to OTG
> underflow. This is the recommended value given by the hardware IP team.
> 
> Signed-off-by: Joshua Aberback <joshua.aberback@amd.com>
> Acked-by: Aurabindo Pillai <aurabindo.pillai@amd.com>

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> ---
>   drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c b/drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c
> index a928c1d9a557..fc2dea243d1b 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c
> @@ -164,7 +164,7 @@ struct _vcs_dpi_soc_bounding_box_st dcn3_02_soc = {
>   
>   		.min_dcfclk = 500.0, /* TODO: set this to actual min DCFCLK */
>   		.num_states = 1,
> -		.sr_exit_time_us = 12,
> +		.sr_exit_time_us = 15.5,
>   		.sr_enter_plus_exit_time_us = 20,
>   		.urgent_latency_us = 4.0,
>   		.urgent_latency_pixel_data_only_us = 4.0,
> 

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] drm/amd/display: Update DCN302 SR Exit Latency
  2021-04-08 17:46 ` Harry Wentland
@ 2021-04-08 18:01   ` Aurabindo Pillai
  0 siblings, 0 replies; 3+ messages in thread
From: Aurabindo Pillai @ 2021-04-08 18:01 UTC (permalink / raw)
  To: Harry Wentland, amd-gfx; +Cc: Bindu.R

Thank you Harry.

On 2021-04-08 1:46 p.m., Harry Wentland wrote:
> On 2021-04-08 1:10 p.m., Aurabindo Pillai wrote:
>> From: Joshua Aberback <joshua.aberback@amd.com>
>>
>> [Why&How]
>> Update SR Exit Latency to fix screen flickering caused due to OTG
>> underflow. This is the recommended value given by the hardware IP team.
>>
>> Signed-off-by: Joshua Aberback <joshua.aberback@amd.com>
>> Acked-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
> 
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
> 
> Harry
> 
>> ---
>>   drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c 
>> b/drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c
>> index a928c1d9a557..fc2dea243d1b 100644
>> --- a/drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c
>> +++ b/drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c
>> @@ -164,7 +164,7 @@ struct _vcs_dpi_soc_bounding_box_st dcn3_02_soc = {
>>           .min_dcfclk = 500.0, /* TODO: set this to actual min DCFCLK */
>>           .num_states = 1,
>> -        .sr_exit_time_us = 12,
>> +        .sr_exit_time_us = 15.5,
>>           .sr_enter_plus_exit_time_us = 20,
>>           .urgent_latency_us = 4.0,
>>           .urgent_latency_pixel_data_only_us = 4.0,
>>
> 

-- 
Regards,
Aurabindo Pillai
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-04-08 18:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-08 17:10 [PATCH v2] drm/amd/display: Update DCN302 SR Exit Latency Aurabindo Pillai
2021-04-08 17:46 ` Harry Wentland
2021-04-08 18:01   ` Aurabindo Pillai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).