* [PATCH] drm/amdgpu: update wave data type to 3 for gfx11
@ 2023-01-17 19:41 Graham Sider
2023-01-25 19:31 ` Joshi, Mukul
0 siblings, 1 reply; 2+ messages in thread
From: Graham Sider @ 2023-01-17 19:41 UTC (permalink / raw)
To: amd-gfx; +Cc: Graham Sider
SQ_WAVE_INST_DW0 isn't present on gfx11 compared to gfx10, so update
wave data type to signify a difference.
Signed-off-by: Graham Sider <Graham.Sider@amd.com>
---
drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
index f98c67d07a9b..f821309f48c9 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
@@ -754,8 +754,8 @@ static void gfx_v11_0_read_wave_data(struct amdgpu_device *adev, uint32_t simd,
* zero here */
WARN_ON(simd != 0);
- /* type 2 wave data */
- dst[(*no_fields)++] = 2;
+ /* type 3 wave data */
+ dst[(*no_fields)++] = 3;
dst[(*no_fields)++] = wave_read_ind(adev, wave, ixSQ_WAVE_STATUS);
dst[(*no_fields)++] = wave_read_ind(adev, wave, ixSQ_WAVE_PC_LO);
dst[(*no_fields)++] = wave_read_ind(adev, wave, ixSQ_WAVE_PC_HI);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] drm/amdgpu: update wave data type to 3 for gfx11
2023-01-17 19:41 [PATCH] drm/amdgpu: update wave data type to 3 for gfx11 Graham Sider
@ 2023-01-25 19:31 ` Joshi, Mukul
0 siblings, 0 replies; 2+ messages in thread
From: Joshi, Mukul @ 2023-01-25 19:31 UTC (permalink / raw)
To: Sider, Graham, amd-gfx; +Cc: Sider, Graham
[AMD Official Use Only - General]
Reviewed-by: Mukul Joshi <mukul.joshi@amd.com>
> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of
> Graham Sider
> Sent: Tuesday, January 17, 2023 2:42 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Sider, Graham <Graham.Sider@amd.com>
> Subject: [PATCH] drm/amdgpu: update wave data type to 3 for gfx11
>
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
>
>
> SQ_WAVE_INST_DW0 isn't present on gfx11 compared to gfx10, so update
> wave data type to signify a difference.
>
> Signed-off-by: Graham Sider <Graham.Sider@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
> b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
> index f98c67d07a9b..f821309f48c9 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c
> @@ -754,8 +754,8 @@ static void gfx_v11_0_read_wave_data(struct
> amdgpu_device *adev, uint32_t simd,
> * zero here */
> WARN_ON(simd != 0);
>
> - /* type 2 wave data */
> - dst[(*no_fields)++] = 2;
> + /* type 3 wave data */
> + dst[(*no_fields)++] = 3;
> dst[(*no_fields)++] = wave_read_ind(adev, wave,
> ixSQ_WAVE_STATUS);
> dst[(*no_fields)++] = wave_read_ind(adev, wave, ixSQ_WAVE_PC_LO);
> dst[(*no_fields)++] = wave_read_ind(adev, wave, ixSQ_WAVE_PC_HI);
> --
> 2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-25 19:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-17 19:41 [PATCH] drm/amdgpu: update wave data type to 3 for gfx11 Graham Sider
2023-01-25 19:31 ` Joshi, Mukul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).