* [PATCH] drm/amd/pm: Activate a more aggressive DPM policy while there's heavy load.
@ 2020-10-27 6:38 Li, Xin (Justin)
2020-10-27 12:46 ` Ernst Sjöstrand
0 siblings, 1 reply; 2+ messages in thread
From: Li, Xin (Justin) @ 2020-10-27 6:38 UTC (permalink / raw)
To: amd-gfx, Li, Xin (Justin), Zhao, Jiange
[-- Attachment #1.1: Type: text/plain, Size: 1395 bytes --]
[AMD Official Use Only - Internal Distribution Only]
Fix performace drop while streaming Doom
Signed-off-by: Li, Xin (Justin) <Xin2.Li@amd.com<mailto:Xin2.Li@amd.com>>
Signed-off-by: Zhao, Jiange <Jiange.Zhao@amd.com<mailto:Jiange.Zhao@amd.com>>
---
drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c b/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c
index eab9768029c1..5287ac4e8364 100644
--- a/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c
+++ b/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c
@@ -125,6 +125,20 @@ static int pp_hw_init(void *handle)
ret = hwmgr_hw_init(hwmgr);
+ if (adev->pdev->device == 0x6860 && adev->pdev->revision == 0x07) {
+ long param[5];
+
+ param[0] = 5; // busy_set_point
+ param[1] = 60; // FPS
+ param[2] = 0; // use_rlc_busy
+ param[3] = 3; // min_active_level
+ param[4] = PP_SMC_POWER_PROFILE_CUSTOM;
+
+ mutex_lock(&hwmgr->smu_lock);
+ ret = hwmgr->hwmgr_func->set_power_profile_mode(hwmgr, param, 4);
+ mutex_unlock(&hwmgr->smu_lock);
+ }
+
if (ret)
pr_err("powerplay hw init failed\n");
--
2.24.3 (Apple Git-128)
[-- Attachment #1.2: Type: text/html, Size: 4699 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/amd/pm: Activate a more aggressive DPM policy while there's heavy load.
2020-10-27 6:38 [PATCH] drm/amd/pm: Activate a more aggressive DPM policy while there's heavy load Li, Xin (Justin)
@ 2020-10-27 12:46 ` Ernst Sjöstrand
0 siblings, 0 replies; 2+ messages in thread
From: Ernst Sjöstrand @ 2020-10-27 12:46 UTC (permalink / raw)
To: Li, Xin (Justin); +Cc: Zhao, Jiange, amd-gfx
[-- Attachment #1.1: Type: text/plain, Size: 1818 bytes --]
Is this really a patch for kernel.org? Seems like a hack for Stadia or
something. (And the patch description is not very good...)
This should really be made into a generic solution.
Regards
//Ernst
Den tis 27 okt. 2020 kl 07:38 skrev Li, Xin (Justin) <Xin2.Li@amd.com>:
> [AMD Official Use Only - Internal Distribution Only]
>
> Fix performace drop while streaming Doom
>
> Signed-off-by: Li, Xin (Justin) <Xin2.Li@amd.com>
> Signed-off-by: Zhao, Jiange <Jiange.Zhao@amd.com>
> ---
> drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c
> b/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c
> index eab9768029c1..5287ac4e8364 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/amd_powerplay.c
> @@ -125,6 +125,20 @@ static int pp_hw_init(void *handle)
>
> ret = hwmgr_hw_init(hwmgr);
>
> + if (adev->pdev->device == 0x6860 && adev->pdev->revision == 0x07) {
> + long param[5];
> +
> + param[0] = 5; // busy_set_point
> + param[1] = 60; // FPS
> + param[2] = 0; // use_rlc_busy
> + param[3] = 3; // min_active_level
> + param[4] = PP_SMC_POWER_PROFILE_CUSTOM;
> +
> + mutex_lock(&hwmgr->smu_lock);
> + ret = hwmgr->hwmgr_func->set_power_profile_mode(hwmgr,
> param, 4);
> + mutex_unlock(&hwmgr->smu_lock);
> + }
> +
> if (ret)
> pr_err("powerplay hw init failed\n");
>
> --
> 2.24.3 (Apple Git-128)
>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
>
[-- Attachment #1.2: Type: text/html, Size: 4100 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-27 12:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-27 6:38 [PATCH] drm/amd/pm: Activate a more aggressive DPM policy while there's heavy load Li, Xin (Justin)
2020-10-27 12:46 ` Ernst Sjöstrand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).