From: Alex Deucher <alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> To: Leo Liu <leo.liu-5C7GfCeVMHo@public.gmane.org> Cc: amd-gfx list <amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org> Subject: Re: [PATCH 00/21] Separate JPEG from VCN Date: Tue, 12 Nov 2019 15:12:00 -0500 [thread overview] Message-ID: <CADnq5_MRfvfE1D5SPOWTyWZFnLZezZ3N61QXvrwnLFssM++LrA@mail.gmail.com> (raw) In-Reply-To: <171a5818-a2b5-6e91-ac35-050b43963988-5C7GfCeVMHo@public.gmane.org> On Tue, Nov 12, 2019 at 2:57 PM Leo Liu <leo.liu@amd.com> wrote: > > > On 2019-11-12 2:49 p.m., Alex Deucher wrote: > > On Tue, Nov 12, 2019 at 1:03 PM Leo Liu <leo.liu@amd.com> wrote: > >> From JPEG2.0, JPEG is a separated IP block, and has it own PG/CG, > >> and power management. It doesn't require FW, so indepedent from FW > >> loading as well. > >> > >> Patch 1-4: Separate JPEG1.0 from SW wise, since JPEG1.0 is still > >> combined with VCN1.0 esp. in power management; > >> Patch 5-10: Separate JPEG2.0 as an independent IP with PG/CG; > >> Patch 11-15: Add power management for JPEG of Navi1x and Renoir; > >> Patch 16: Enable JPEG2.0; > >> Patch 17-20: Separate JPEG2.5 from VCN2.5; > >> Patch 21: Enable JPEG2.5 > >> > > Is the jpeg powergating dynamic or do we need a idle work thread to > > turn it off like we do for vcn? > > It has static PG/CG for JPEG2.0 and static CG for JPEG2.5. > > It also has DPM for JPEG2.0. So we need idle work thread and begin_use > like VCN to init/deinit JPEG and turn on/off JPEG power through SMU > messages such as PowerUPJpeg and PowerDownJpeg. Ok, so that still has to be implemented then. I didn't see that in the patch set. Thanks, Alex > > > Thanks, > Leo > > > > > > Alex > > > >> Leo Liu (21): > >> drm/amdgpu: add JPEG HW IP and SW structures > >> drm/amdgpu: add amdgpu_jpeg and JPEG tests > >> drm/amdgpu: separate JPEG1.0 code out from VCN1.0 > >> drm/amdgpu: use the JPEG structure for general driver support > >> drm/amdgpu: add JPEG IP block type > >> drm/amdgpu: add JPEG common functions to amdgpu_jpeg > >> drm/amdgpu: add JPEG v2.0 function supports > >> drm/amdgpu: remove unnecessary JPEG2.0 code from VCN2.0 > >> drm/amdgpu: add JPEG PG and CG interface > >> drm/amdgpu: add PG and CG for JPEG2.0 > >> drm/amd/powerplay: add JPEG Powerplay interface > >> drm/amd/powerplay: add JPEG power control for Navi1x > >> drm/amd/powerplay: add Powergate JPEG for Renoir > >> drm/amd/powerplay: add JPEG power control for Renoir > >> drm/amd/powerplay: set JPEG to SMU dpm > >> drm/amdgpu: enable JPEG2.0 dpm > >> drm/amdgpu: add driver support for JPEG2.0 and above > >> drm/amdgpu: enable JPEG2.0 for Navi1x and Renoir > >> drm/amdgpu: move JPEG2.5 out from VCN2.5 > >> drm/amdgpu: enable Arcturus CG for VCN and JPEG blocks > >> drm/amdgpu: enable Arcturus JPEG2.5 block > >> > >> drivers/gpu/drm/amd/amdgpu/Makefile | 8 +- > >> drivers/gpu/drm/amd/amdgpu/amdgpu.h | 5 + > >> drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 4 +- > >> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 + > >> drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.c | 215 +++++ > >> drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.h | 62 ++ > >> drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 15 +- > >> drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 8 + > >> drivers/gpu/drm/amd/amdgpu/amdgpu_pm.h | 1 + > >> drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 113 +-- > >> drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 5 - > >> drivers/gpu/drm/amd/amdgpu/jpeg_v1_0.c | 584 +++++++++++++ > >> drivers/gpu/drm/amd/amdgpu/jpeg_v1_0.h | 32 + > >> drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.c | 827 ++++++++++++++++++ > >> drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.h | 42 + > >> drivers/gpu/drm/amd/amdgpu/jpeg_v2_5.c | 641 ++++++++++++++ > >> drivers/gpu/drm/amd/amdgpu/jpeg_v2_5.h | 29 + > >> drivers/gpu/drm/amd/amdgpu/nv.c | 11 +- > >> drivers/gpu/drm/amd/amdgpu/soc15.c | 10 +- > >> drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 481 +--------- > >> drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 496 +---------- > >> drivers/gpu/drm/amd/amdgpu/vcn_v2_0.h | 13 - > >> drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c | 246 +----- > >> drivers/gpu/drm/amd/include/amd_shared.h | 5 +- > >> drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 5 + > >> .../gpu/drm/amd/powerplay/inc/amdgpu_smu.h | 3 + > >> drivers/gpu/drm/amd/powerplay/inc/smu_v12_0.h | 2 + > >> drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 32 +- > >> drivers/gpu/drm/amd/powerplay/renoir_ppt.c | 27 + > >> drivers/gpu/drm/amd/powerplay/smu_internal.h | 4 + > >> drivers/gpu/drm/amd/powerplay/smu_v12_0.c | 11 + > >> 31 files changed, 2593 insertions(+), 1346 deletions(-) > >> create mode 100644 drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.c > >> create mode 100644 drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.h > >> create mode 100644 drivers/gpu/drm/amd/amdgpu/jpeg_v1_0.c > >> create mode 100644 drivers/gpu/drm/amd/amdgpu/jpeg_v1_0.h > >> create mode 100644 drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.c > >> create mode 100644 drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.h > >> create mode 100644 drivers/gpu/drm/amd/amdgpu/jpeg_v2_5.c > >> create mode 100644 drivers/gpu/drm/amd/amdgpu/jpeg_v2_5.h > >> > >> -- > >> 2.17.1 > >> > >> _______________________________________________ > >> amd-gfx mailing list > >> amd-gfx@lists.freedesktop.org > >> https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Alex Deucher <alexdeucher@gmail.com> To: Leo Liu <leo.liu@amd.com> Cc: amd-gfx list <amd-gfx@lists.freedesktop.org> Subject: Re: [PATCH 00/21] Separate JPEG from VCN Date: Tue, 12 Nov 2019 15:12:00 -0500 [thread overview] Message-ID: <CADnq5_MRfvfE1D5SPOWTyWZFnLZezZ3N61QXvrwnLFssM++LrA@mail.gmail.com> (raw) Message-ID: <20191112201200.sTr35TPx08DSg4NNk_9HbeY8k-MU0ShVazNXJoooRBg@z> (raw) In-Reply-To: <171a5818-a2b5-6e91-ac35-050b43963988@amd.com> On Tue, Nov 12, 2019 at 2:57 PM Leo Liu <leo.liu@amd.com> wrote: > > > On 2019-11-12 2:49 p.m., Alex Deucher wrote: > > On Tue, Nov 12, 2019 at 1:03 PM Leo Liu <leo.liu@amd.com> wrote: > >> From JPEG2.0, JPEG is a separated IP block, and has it own PG/CG, > >> and power management. It doesn't require FW, so indepedent from FW > >> loading as well. > >> > >> Patch 1-4: Separate JPEG1.0 from SW wise, since JPEG1.0 is still > >> combined with VCN1.0 esp. in power management; > >> Patch 5-10: Separate JPEG2.0 as an independent IP with PG/CG; > >> Patch 11-15: Add power management for JPEG of Navi1x and Renoir; > >> Patch 16: Enable JPEG2.0; > >> Patch 17-20: Separate JPEG2.5 from VCN2.5; > >> Patch 21: Enable JPEG2.5 > >> > > Is the jpeg powergating dynamic or do we need a idle work thread to > > turn it off like we do for vcn? > > It has static PG/CG for JPEG2.0 and static CG for JPEG2.5. > > It also has DPM for JPEG2.0. So we need idle work thread and begin_use > like VCN to init/deinit JPEG and turn on/off JPEG power through SMU > messages such as PowerUPJpeg and PowerDownJpeg. Ok, so that still has to be implemented then. I didn't see that in the patch set. Thanks, Alex > > > Thanks, > Leo > > > > > > Alex > > > >> Leo Liu (21): > >> drm/amdgpu: add JPEG HW IP and SW structures > >> drm/amdgpu: add amdgpu_jpeg and JPEG tests > >> drm/amdgpu: separate JPEG1.0 code out from VCN1.0 > >> drm/amdgpu: use the JPEG structure for general driver support > >> drm/amdgpu: add JPEG IP block type > >> drm/amdgpu: add JPEG common functions to amdgpu_jpeg > >> drm/amdgpu: add JPEG v2.0 function supports > >> drm/amdgpu: remove unnecessary JPEG2.0 code from VCN2.0 > >> drm/amdgpu: add JPEG PG and CG interface > >> drm/amdgpu: add PG and CG for JPEG2.0 > >> drm/amd/powerplay: add JPEG Powerplay interface > >> drm/amd/powerplay: add JPEG power control for Navi1x > >> drm/amd/powerplay: add Powergate JPEG for Renoir > >> drm/amd/powerplay: add JPEG power control for Renoir > >> drm/amd/powerplay: set JPEG to SMU dpm > >> drm/amdgpu: enable JPEG2.0 dpm > >> drm/amdgpu: add driver support for JPEG2.0 and above > >> drm/amdgpu: enable JPEG2.0 for Navi1x and Renoir > >> drm/amdgpu: move JPEG2.5 out from VCN2.5 > >> drm/amdgpu: enable Arcturus CG for VCN and JPEG blocks > >> drm/amdgpu: enable Arcturus JPEG2.5 block > >> > >> drivers/gpu/drm/amd/amdgpu/Makefile | 8 +- > >> drivers/gpu/drm/amd/amdgpu/amdgpu.h | 5 + > >> drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 4 +- > >> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 + > >> drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.c | 215 +++++ > >> drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.h | 62 ++ > >> drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 15 +- > >> drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 8 + > >> drivers/gpu/drm/amd/amdgpu/amdgpu_pm.h | 1 + > >> drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 113 +-- > >> drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 5 - > >> drivers/gpu/drm/amd/amdgpu/jpeg_v1_0.c | 584 +++++++++++++ > >> drivers/gpu/drm/amd/amdgpu/jpeg_v1_0.h | 32 + > >> drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.c | 827 ++++++++++++++++++ > >> drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.h | 42 + > >> drivers/gpu/drm/amd/amdgpu/jpeg_v2_5.c | 641 ++++++++++++++ > >> drivers/gpu/drm/amd/amdgpu/jpeg_v2_5.h | 29 + > >> drivers/gpu/drm/amd/amdgpu/nv.c | 11 +- > >> drivers/gpu/drm/amd/amdgpu/soc15.c | 10 +- > >> drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 481 +--------- > >> drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 496 +---------- > >> drivers/gpu/drm/amd/amdgpu/vcn_v2_0.h | 13 - > >> drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c | 246 +----- > >> drivers/gpu/drm/amd/include/amd_shared.h | 5 +- > >> drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 5 + > >> .../gpu/drm/amd/powerplay/inc/amdgpu_smu.h | 3 + > >> drivers/gpu/drm/amd/powerplay/inc/smu_v12_0.h | 2 + > >> drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 32 +- > >> drivers/gpu/drm/amd/powerplay/renoir_ppt.c | 27 + > >> drivers/gpu/drm/amd/powerplay/smu_internal.h | 4 + > >> drivers/gpu/drm/amd/powerplay/smu_v12_0.c | 11 + > >> 31 files changed, 2593 insertions(+), 1346 deletions(-) > >> create mode 100644 drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.c > >> create mode 100644 drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.h > >> create mode 100644 drivers/gpu/drm/amd/amdgpu/jpeg_v1_0.c > >> create mode 100644 drivers/gpu/drm/amd/amdgpu/jpeg_v1_0.h > >> create mode 100644 drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.c > >> create mode 100644 drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.h > >> create mode 100644 drivers/gpu/drm/amd/amdgpu/jpeg_v2_5.c > >> create mode 100644 drivers/gpu/drm/amd/amdgpu/jpeg_v2_5.h > >> > >> -- > >> 2.17.1 > >> > >> _______________________________________________ > >> amd-gfx mailing list > >> amd-gfx@lists.freedesktop.org > >> https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2019-11-12 20:12 UTC|newest] Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-12 18:03 [PATCH 00/21] Separate JPEG from VCN Leo Liu 2019-11-12 18:03 ` Leo Liu [not found] ` <20191112180329.3927-1-leo.liu-5C7GfCeVMHo@public.gmane.org> 2019-11-12 18:03 ` [PATCH 01/21] drm/amdgpu: add JPEG HW IP and SW structures Leo Liu 2019-11-12 18:03 ` Leo Liu 2019-11-12 18:03 ` [PATCH 02/21] drm/amdgpu: add amdgpu_jpeg and JPEG tests Leo Liu 2019-11-12 18:03 ` Leo Liu 2019-11-12 18:03 ` [PATCH 03/21] drm/amdgpu: separate JPEG1.0 code out from VCN1.0 Leo Liu 2019-11-12 18:03 ` Leo Liu 2019-11-12 18:03 ` [PATCH 04/21] drm/amdgpu: use the JPEG structure for general driver support Leo Liu 2019-11-12 18:03 ` Leo Liu 2019-11-12 18:03 ` [PATCH 05/21] drm/amdgpu: add JPEG IP block type Leo Liu 2019-11-12 18:03 ` Leo Liu 2019-11-12 18:03 ` [PATCH 06/21] drm/amdgpu: add JPEG common functions to amdgpu_jpeg Leo Liu 2019-11-12 18:03 ` Leo Liu 2019-11-12 18:03 ` [PATCH 07/21] drm/amdgpu: add JPEG v2.0 function supports Leo Liu 2019-11-12 18:03 ` Leo Liu 2019-11-12 18:03 ` [PATCH 08/21] drm/amdgpu: remove unnecessary JPEG2.0 code from VCN2.0 Leo Liu 2019-11-12 18:03 ` Leo Liu 2019-11-12 18:03 ` [PATCH 09/21] drm/amdgpu: add JPEG PG and CG interface Leo Liu 2019-11-12 18:03 ` Leo Liu 2019-11-12 18:03 ` [PATCH 10/21] drm/amdgpu: add PG and CG for JPEG2.0 Leo Liu 2019-11-12 18:03 ` Leo Liu 2019-11-12 18:03 ` [PATCH 11/21] drm/amd/powerplay: add JPEG Powerplay interface Leo Liu 2019-11-12 18:03 ` Leo Liu 2019-11-12 18:03 ` [PATCH 12/21] drm/amd/powerplay: add JPEG power control for Navi1x Leo Liu 2019-11-12 18:03 ` Leo Liu [not found] ` <20191112180329.3927-13-leo.liu-5C7GfCeVMHo@public.gmane.org> 2019-11-13 3:50 ` Quan, Evan 2019-11-13 3:50 ` Quan, Evan [not found] ` <MN2PR12MB334438FF2957ED7C7C8E226FE4760-rweVpJHSKToDMgCC8P//OwdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> 2019-11-13 13:50 ` Leo Liu 2019-11-13 13:50 ` Leo Liu 2019-11-13 14:11 ` Leo Liu 2019-11-13 14:11 ` Leo Liu 2019-11-12 18:03 ` [PATCH 13/21] drm/amd/powerplay: add Powergate JPEG for Renoir Leo Liu 2019-11-12 18:03 ` Leo Liu [not found] ` <20191112180329.3927-14-leo.liu-5C7GfCeVMHo@public.gmane.org> 2019-11-13 3:52 ` Quan, Evan 2019-11-13 3:52 ` Quan, Evan 2019-11-13 14:12 ` Leo Liu 2019-11-13 14:12 ` Leo Liu 2019-11-12 18:03 ` [PATCH 14/21] drm/amd/powerplay: add JPEG power control " Leo Liu 2019-11-12 18:03 ` Leo Liu [not found] ` <20191112180329.3927-15-leo.liu-5C7GfCeVMHo@public.gmane.org> 2019-11-13 3:52 ` Quan, Evan 2019-11-13 3:52 ` Quan, Evan 2019-11-13 14:13 ` Leo Liu 2019-11-13 14:13 ` Leo Liu 2019-11-12 18:03 ` [PATCH 15/21] drm/amd/powerplay: set JPEG to SMU dpm Leo Liu 2019-11-12 18:03 ` Leo Liu 2019-11-12 18:03 ` [PATCH 16/21] drm/amdgpu: enable JPEG2.0 dpm Leo Liu 2019-11-12 18:03 ` Leo Liu [not found] ` <20191112180329.3927-17-leo.liu-5C7GfCeVMHo@public.gmane.org> 2019-11-14 16:03 ` Alex Deucher 2019-11-14 16:03 ` Alex Deucher [not found] ` <CADnq5_PTs-1fU3o3rpQ1hhAdbiicwixWMHuOxSbZ7bshMSBVxA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2019-11-14 16:14 ` Leo Liu 2019-11-14 16:14 ` Leo Liu 2019-11-12 18:03 ` [PATCH 17/21] drm/amdgpu: add driver support for JPEG2.0 and above Leo Liu 2019-11-12 18:03 ` Leo Liu 2019-11-12 18:03 ` [PATCH 18/21] drm/amdgpu: enable JPEG2.0 for Navi1x and Renoir Leo Liu 2019-11-12 18:03 ` Leo Liu 2019-11-12 18:03 ` [PATCH 19/21] drm/amdgpu: move JPEG2.5 out from VCN2.5 Leo Liu 2019-11-12 18:03 ` Leo Liu 2019-11-12 18:03 ` [PATCH 20/21] drm/amdgpu: enable Arcturus CG for VCN and JPEG blocks Leo Liu 2019-11-12 18:03 ` Leo Liu 2019-11-12 18:03 ` [PATCH 21/21] drm/amdgpu: enable Arcturus JPEG2.5 block Leo Liu 2019-11-12 18:03 ` Leo Liu 2019-11-12 18:59 ` [PATCH 00/21] Separate JPEG from VCN Leo Liu 2019-11-12 18:59 ` Leo Liu 2019-11-12 19:49 ` Alex Deucher 2019-11-12 19:49 ` Alex Deucher [not found] ` <CADnq5_NVBemrfE5OB=NBeb5XM5HPWdnhjaWM0KjdDyb6+pm9zA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2019-11-12 19:57 ` Leo Liu 2019-11-12 19:57 ` Leo Liu [not found] ` <171a5818-a2b5-6e91-ac35-050b43963988-5C7GfCeVMHo@public.gmane.org> 2019-11-12 20:12 ` Alex Deucher [this message] 2019-11-12 20:12 ` Alex Deucher [not found] ` <CADnq5_MRfvfE1D5SPOWTyWZFnLZezZ3N61QXvrwnLFssM++LrA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2019-11-12 20:16 ` Leo Liu 2019-11-12 20:16 ` Leo Liu [not found] ` <bf523547-408a-536d-5f61-226691058a7b-5C7GfCeVMHo@public.gmane.org> 2019-11-12 20:34 ` Alex Deucher 2019-11-12 20:34 ` Alex Deucher [not found] ` <CADnq5_NjNPZC=2xt5Qft6_jiZnbdtR+LqogTWdfty_N_zWR_uA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2019-11-12 20:37 ` Leo Liu 2019-11-12 20:37 ` Leo Liu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CADnq5_MRfvfE1D5SPOWTyWZFnLZezZ3N61QXvrwnLFssM++LrA@mail.gmail.com \ --to=alexdeucher-re5jqeeqqe8avxtiumwx3w@public.gmane.org \ --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \ --cc=leo.liu-5C7GfCeVMHo@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).