* [PATCH] drm/amdgpu/display: use kvzalloc again in dc_create_state
@ 2020-10-26 14:30 Alex Deucher
2020-10-26 15:29 ` Kazlauskas, Nicholas
2020-10-26 16:56 ` Alex Xu (Hello71)
0 siblings, 2 replies; 4+ messages in thread
From: Alex Deucher @ 2020-10-26 14:30 UTC (permalink / raw)
To: amd-gfx; +Cc: Alex Deucher, Aric Cyr, Alex Xu
It looks this was accidently lost in a follow up patch.
dc context is large and we don't need contiguous pages.
Fixes: e4863f118a7d ("drm/amd/display: Multi display cause system lag on mode change")
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: Aric Cyr <aric.cyr@amd.com>
Cc: Alex Xu <alex_y_xu@yahoo.ca>
---
drivers/gpu/drm/amd/display/dc/core/dc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
index 7ff029143722..64da60450fb0 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
@@ -1564,8 +1564,8 @@ static void init_state(struct dc *dc, struct dc_state *context)
struct dc_state *dc_create_state(struct dc *dc)
{
- struct dc_state *context = kzalloc(sizeof(struct dc_state),
- GFP_KERNEL);
+ struct dc_state *context = kvzalloc(sizeof(struct dc_state),
+ GFP_KERNEL);
if (!context)
return NULL;
--
2.25.4
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amdgpu/display: use kvzalloc again in dc_create_state
2020-10-26 14:30 [PATCH] drm/amdgpu/display: use kvzalloc again in dc_create_state Alex Deucher
@ 2020-10-26 15:29 ` Kazlauskas, Nicholas
2020-10-26 16:56 ` Alex Xu (Hello71)
1 sibling, 0 replies; 4+ messages in thread
From: Kazlauskas, Nicholas @ 2020-10-26 15:29 UTC (permalink / raw)
To: Alex Deucher, amd-gfx; +Cc: Alex Deucher, Aric Cyr, Alex Xu
On 2020-10-26 10:30 a.m., Alex Deucher wrote:
> It looks this was accidently lost in a follow up patch.
> dc context is large and we don't need contiguous pages.
>
> Fixes: e4863f118a7d ("drm/amd/display: Multi display cause system lag on mode change")
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> Cc: Aric Cyr <aric.cyr@amd.com>
> Cc: Alex Xu <alex_y_xu@yahoo.ca>
Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Regards,
Nicholas Kazlauskas
> ---
> drivers/gpu/drm/amd/display/dc/core/dc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> index 7ff029143722..64da60450fb0 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> @@ -1564,8 +1564,8 @@ static void init_state(struct dc *dc, struct dc_state *context)
>
> struct dc_state *dc_create_state(struct dc *dc)
> {
> - struct dc_state *context = kzalloc(sizeof(struct dc_state),
> - GFP_KERNEL);
> + struct dc_state *context = kvzalloc(sizeof(struct dc_state),
> + GFP_KERNEL);
>
> if (!context)
> return NULL;
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amdgpu/display: use kvzalloc again in dc_create_state
2020-10-26 14:30 [PATCH] drm/amdgpu/display: use kvzalloc again in dc_create_state Alex Deucher
2020-10-26 15:29 ` Kazlauskas, Nicholas
@ 2020-10-26 16:56 ` Alex Xu (Hello71)
2020-10-26 17:35 ` Alex Deucher
1 sibling, 1 reply; 4+ messages in thread
From: Alex Xu (Hello71) @ 2020-10-26 16:56 UTC (permalink / raw)
To: Alex Deucher, amd-gfx; +Cc: Alex Deucher, Aric Cyr
Excerpts from Alex Deucher's message of October 26, 2020 10:30 am:
> It looks this was accidently lost in a follow up patch.
> dc context is large and we don't need contiguous pages.
>
> Fixes: e4863f118a7d ("drm/amd/display: Multi display cause system lag on mode change")
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> Cc: Aric Cyr <aric.cyr@amd.com>
> Cc: Alex Xu <alex_y_xu@yahoo.ca>
> ---
> drivers/gpu/drm/amd/display/dc/core/dc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> index 7ff029143722..64da60450fb0 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> @@ -1564,8 +1564,8 @@ static void init_state(struct dc *dc, struct dc_state *context)
>
> struct dc_state *dc_create_state(struct dc *dc)
> {
> - struct dc_state *context = kzalloc(sizeof(struct dc_state),
> - GFP_KERNEL);
> + struct dc_state *context = kvzalloc(sizeof(struct dc_state),
> + GFP_KERNEL);
>
> if (!context)
> return NULL;
> --
> 2.25.4
>
>
Did a quick test, it seems to resolve the issue for me. If you could
apply one or both of:
Reported-by: Alex Xu (Hello71) <alex_y_xu@yahoo.ca>
Tested-by: Alex Xu (Hello71) <alex_y_xu@yahoo.ca>
I'd appreciate it, but it's not a big deal. Thanks!
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amdgpu/display: use kvzalloc again in dc_create_state
2020-10-26 16:56 ` Alex Xu (Hello71)
@ 2020-10-26 17:35 ` Alex Deucher
0 siblings, 0 replies; 4+ messages in thread
From: Alex Deucher @ 2020-10-26 17:35 UTC (permalink / raw)
To: Alex Xu (Hello71); +Cc: Alex Deucher, Aric Cyr, amd-gfx list
Will do. Thanks!
Alex
On Mon, Oct 26, 2020 at 12:56 PM Alex Xu (Hello71) <alex_y_xu@yahoo.ca> wrote:
>
> Excerpts from Alex Deucher's message of October 26, 2020 10:30 am:
> > It looks this was accidently lost in a follow up patch.
> > dc context is large and we don't need contiguous pages.
> >
> > Fixes: e4863f118a7d ("drm/amd/display: Multi display cause system lag on mode change")
> > Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> > Cc: Aric Cyr <aric.cyr@amd.com>
> > Cc: Alex Xu <alex_y_xu@yahoo.ca>
> > ---
> > drivers/gpu/drm/amd/display/dc/core/dc.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> > index 7ff029143722..64da60450fb0 100644
> > --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> > +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> > @@ -1564,8 +1564,8 @@ static void init_state(struct dc *dc, struct dc_state *context)
> >
> > struct dc_state *dc_create_state(struct dc *dc)
> > {
> > - struct dc_state *context = kzalloc(sizeof(struct dc_state),
> > - GFP_KERNEL);
> > + struct dc_state *context = kvzalloc(sizeof(struct dc_state),
> > + GFP_KERNEL);
> >
> > if (!context)
> > return NULL;
> > --
> > 2.25.4
> >
> >
>
> Did a quick test, it seems to resolve the issue for me. If you could
> apply one or both of:
>
> Reported-by: Alex Xu (Hello71) <alex_y_xu@yahoo.ca>
> Tested-by: Alex Xu (Hello71) <alex_y_xu@yahoo.ca>
>
> I'd appreciate it, but it's not a big deal. Thanks!
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-10-26 17:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-26 14:30 [PATCH] drm/amdgpu/display: use kvzalloc again in dc_create_state Alex Deucher
2020-10-26 15:29 ` Kazlauskas, Nicholas
2020-10-26 16:56 ` Alex Xu (Hello71)
2020-10-26 17:35 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).