* [PATCH] drm/amd/display: Remove return value of Calculate256BBlockSizes
@ 2022-06-30 18:50 Maíra Canal
2022-07-05 15:16 ` Alex Deucher
0 siblings, 1 reply; 2+ messages in thread
From: Maíra Canal @ 2022-06-30 18:50 UTC (permalink / raw)
To: Harry Wentland, Leo Li, Rodrigo Siqueira, Alex Deucher,
christian.koenig, Xinhui.Pan, David Airlie, Daniel Vetter
Cc: Maíra Canal, dri-devel, amd-gfx, linux-kernel
The function Calculate256BBlockSizes always returns true, regardless of
the parameters. As any file checks the return of the function, this
commit changes the return value to void.
Signed-off-by: Maíra Canal <mairacanal@riseup.net>
---
drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.c | 3 +--
drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.h | 2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.c b/drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.c
index 2676710a5f2b..ed23c7c79d86 100644
--- a/drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.c
+++ b/drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.c
@@ -957,7 +957,7 @@ static void recalculate_params(
}
}
-bool Calculate256BBlockSizes(
+void Calculate256BBlockSizes(
enum source_format_class SourcePixelFormat,
enum dm_swizzle_mode SurfaceTiling,
unsigned int BytePerPixelY,
@@ -995,7 +995,6 @@ bool Calculate256BBlockSizes(
*BlockWidth256BytesY = 256 / BytePerPixelY / *BlockHeight256BytesY;
*BlockWidth256BytesC = 256 / BytePerPixelC / *BlockHeight256BytesC;
}
- return true;
}
bool CalculateMinAndMaxPrefetchMode(
diff --git a/drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.h b/drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.h
index 10ff536ef2a4..25a9a606ab6f 100644
--- a/drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.h
+++ b/drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.h
@@ -169,7 +169,7 @@ bool get_is_phantom_pipe(struct display_mode_lib *mode_lib,
unsigned int pipe_idx);
void PixelClockAdjustmentForProgressiveToInterlaceUnit(struct display_mode_lib *mode_lib);
-bool Calculate256BBlockSizes(
+void Calculate256BBlockSizes(
enum source_format_class SourcePixelFormat,
enum dm_swizzle_mode SurfaceTiling,
unsigned int BytePerPixelY,
--
2.36.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/amd/display: Remove return value of Calculate256BBlockSizes
2022-06-30 18:50 [PATCH] drm/amd/display: Remove return value of Calculate256BBlockSizes Maíra Canal
@ 2022-07-05 15:16 ` Alex Deucher
0 siblings, 0 replies; 2+ messages in thread
From: Alex Deucher @ 2022-07-05 15:16 UTC (permalink / raw)
To: Maíra Canal
Cc: Leo Li, xinhui pan, Rodrigo Siqueira, LKML,
Maling list - DRI developers, David Airlie, amd-gfx list,
Daniel Vetter, Alex Deucher, Harry Wentland, Christian Koenig
Applied. Thanks!
Alex
On Thu, Jun 30, 2022 at 2:50 PM Maíra Canal <mairacanal@riseup.net> wrote:
>
> The function Calculate256BBlockSizes always returns true, regardless of
> the parameters. As any file checks the return of the function, this
> commit changes the return value to void.
>
> Signed-off-by: Maíra Canal <mairacanal@riseup.net>
> ---
> drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.c | 3 +--
> drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.h | 2 +-
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.c b/drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.c
> index 2676710a5f2b..ed23c7c79d86 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.c
> @@ -957,7 +957,7 @@ static void recalculate_params(
> }
> }
>
> -bool Calculate256BBlockSizes(
> +void Calculate256BBlockSizes(
> enum source_format_class SourcePixelFormat,
> enum dm_swizzle_mode SurfaceTiling,
> unsigned int BytePerPixelY,
> @@ -995,7 +995,6 @@ bool Calculate256BBlockSizes(
> *BlockWidth256BytesY = 256 / BytePerPixelY / *BlockHeight256BytesY;
> *BlockWidth256BytesC = 256 / BytePerPixelC / *BlockHeight256BytesC;
> }
> - return true;
> }
>
> bool CalculateMinAndMaxPrefetchMode(
> diff --git a/drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.h b/drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.h
> index 10ff536ef2a4..25a9a606ab6f 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.h
> +++ b/drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.h
> @@ -169,7 +169,7 @@ bool get_is_phantom_pipe(struct display_mode_lib *mode_lib,
> unsigned int pipe_idx);
> void PixelClockAdjustmentForProgressiveToInterlaceUnit(struct display_mode_lib *mode_lib);
>
> -bool Calculate256BBlockSizes(
> +void Calculate256BBlockSizes(
> enum source_format_class SourcePixelFormat,
> enum dm_swizzle_mode SurfaceTiling,
> unsigned int BytePerPixelY,
> --
> 2.36.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-05 15:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-30 18:50 [PATCH] drm/amd/display: Remove return value of Calculate256BBlockSizes Maíra Canal
2022-07-05 15:16 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).