* [Outreachy kernel][PATCH] gpu: amd: Return boolean types instead of integer values
@ 2020-10-21 18:26 Sumera Priyadarsini
2020-10-21 18:33 ` Alex Deucher
0 siblings, 1 reply; 2+ messages in thread
From: Sumera Priyadarsini @ 2020-10-21 18:26 UTC (permalink / raw)
To: dri-devel
Cc: airlied, Felix.Kuehling, linux-kernel, amd-gfx, melissa.srw,
daniel, alexander.deucher, christian.koenig
Return statements for functions returning bool should use truth
and false instead of 1 and 0 respectively.
Modify cik_event_interrupt.c to return false instead of 0.
Issue found with Coccinelle.
Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
---
drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c b/drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c
index 24b471734117..8e64c01565ac 100644
--- a/drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c
+++ b/drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c
@@ -66,12 +66,12 @@ static bool cik_event_interrupt_isr(struct kfd_dev *dev,
vmid = (ihre->ring_id & 0x0000ff00) >> 8;
if (vmid < dev->vm_info.first_vmid_kfd ||
vmid > dev->vm_info.last_vmid_kfd)
- return 0;
+ return false;
/* If there is no valid PASID, it's likely a firmware bug */
pasid = (ihre->ring_id & 0xffff0000) >> 16;
if (WARN_ONCE(pasid == 0, "FW bug: No PASID in KFD interrupt"))
- return 0;
+ return false;
/* Interrupt types we care about: various signals and faults.
* They will be forwarded to a work queue (see below).
--
2.25.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Outreachy kernel][PATCH] gpu: amd: Return boolean types instead of integer values
2020-10-21 18:26 [Outreachy kernel][PATCH] gpu: amd: Return boolean types instead of integer values Sumera Priyadarsini
@ 2020-10-21 18:33 ` Alex Deucher
0 siblings, 0 replies; 2+ messages in thread
From: Alex Deucher @ 2020-10-21 18:33 UTC (permalink / raw)
To: Sumera Priyadarsini
Cc: Dave Airlie, Kuehling, Felix, LKML, amd-gfx list, Melissa Wen,
Maling list - DRI developers, Daniel Vetter, Deucher, Alexander,
Christian Koenig
Applied. Thanks!
Alex
On Wed, Oct 21, 2020 at 2:29 PM Sumera Priyadarsini
<sylphrenadin@gmail.com> wrote:
>
> Return statements for functions returning bool should use truth
> and false instead of 1 and 0 respectively.
>
> Modify cik_event_interrupt.c to return false instead of 0.
>
> Issue found with Coccinelle.
>
> Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
> ---
> drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c b/drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c
> index 24b471734117..8e64c01565ac 100644
> --- a/drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c
> +++ b/drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c
> @@ -66,12 +66,12 @@ static bool cik_event_interrupt_isr(struct kfd_dev *dev,
> vmid = (ihre->ring_id & 0x0000ff00) >> 8;
> if (vmid < dev->vm_info.first_vmid_kfd ||
> vmid > dev->vm_info.last_vmid_kfd)
> - return 0;
> + return false;
>
> /* If there is no valid PASID, it's likely a firmware bug */
> pasid = (ihre->ring_id & 0xffff0000) >> 16;
> if (WARN_ONCE(pasid == 0, "FW bug: No PASID in KFD interrupt"))
> - return 0;
> + return false;
>
> /* Interrupt types we care about: various signals and faults.
> * They will be forwarded to a work queue (see below).
> --
> 2.25.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-21 18:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-21 18:26 [Outreachy kernel][PATCH] gpu: amd: Return boolean types instead of integer values Sumera Priyadarsini
2020-10-21 18:33 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).