* [PATCH] drm/fourcc: fix AMD modifiers PACKERS field doc
@ 2020-11-15 9:39 Simon Ser
2020-11-15 15:48 ` Bas Nieuwenhuizen
0 siblings, 1 reply; 3+ messages in thread
From: Simon Ser @ 2020-11-15 9:39 UTC (permalink / raw)
To: amd-gfx; +Cc: Alex Deucher, Daniel Vetter, dri-devel, Bas Nieuwenhuizen
This field doesn't alias with BANK_XOR_BITS: PACKERS is bits 26:28 while
BANK_XOR_BITS is bits 23:25.
Fixes: 8ba16d599374 ("drm/fourcc: Add AMD DRM modifiers.")
Signed-off-by: Simon Ser <contact@emersion.fr>
Cc: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Cc: Alex Deucher <alexdeucher@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
---
include/uapi/drm/drm_fourcc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
index ca48ed0e6bc1..29c7a8694479 100644
--- a/include/uapi/drm/drm_fourcc.h
+++ b/include/uapi/drm/drm_fourcc.h
@@ -1196,7 +1196,7 @@ drm_fourcc_canonicalize_nvidia_format_mod(__u64 modifier)
#define AMD_FMT_MOD_PIPE_XOR_BITS_MASK 0x7
#define AMD_FMT_MOD_BANK_XOR_BITS_SHIFT 23
#define AMD_FMT_MOD_BANK_XOR_BITS_MASK 0x7
-#define AMD_FMT_MOD_PACKERS_SHIFT 26 /* aliases with BANK_XOR_BITS */
+#define AMD_FMT_MOD_PACKERS_SHIFT 26
#define AMD_FMT_MOD_PACKERS_MASK 0x7
#define AMD_FMT_MOD_RB_SHIFT 29
#define AMD_FMT_MOD_RB_MASK 0x7
--
2.29.2
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/fourcc: fix AMD modifiers PACKERS field doc
2020-11-15 9:39 [PATCH] drm/fourcc: fix AMD modifiers PACKERS field doc Simon Ser
@ 2020-11-15 15:48 ` Bas Nieuwenhuizen
2020-11-16 16:13 ` Alex Deucher
0 siblings, 1 reply; 3+ messages in thread
From: Bas Nieuwenhuizen @ 2020-11-15 15:48 UTC (permalink / raw)
To: Simon Ser; +Cc: Alex Deucher, Daniel Vetter, ML dri-devel, amd-gfx mailing list
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
On Sun, Nov 15, 2020 at 10:39 AM Simon Ser <contact@emersion.fr> wrote:
>
> This field doesn't alias with BANK_XOR_BITS: PACKERS is bits 26:28 while
> BANK_XOR_BITS is bits 23:25.
>
> Fixes: 8ba16d599374 ("drm/fourcc: Add AMD DRM modifiers.")
> Signed-off-by: Simon Ser <contact@emersion.fr>
> Cc: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
> Cc: Alex Deucher <alexdeucher@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> ---
> include/uapi/drm/drm_fourcc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
> index ca48ed0e6bc1..29c7a8694479 100644
> --- a/include/uapi/drm/drm_fourcc.h
> +++ b/include/uapi/drm/drm_fourcc.h
> @@ -1196,7 +1196,7 @@ drm_fourcc_canonicalize_nvidia_format_mod(__u64 modifier)
> #define AMD_FMT_MOD_PIPE_XOR_BITS_MASK 0x7
> #define AMD_FMT_MOD_BANK_XOR_BITS_SHIFT 23
> #define AMD_FMT_MOD_BANK_XOR_BITS_MASK 0x7
> -#define AMD_FMT_MOD_PACKERS_SHIFT 26 /* aliases with BANK_XOR_BITS */
> +#define AMD_FMT_MOD_PACKERS_SHIFT 26
> #define AMD_FMT_MOD_PACKERS_MASK 0x7
> #define AMD_FMT_MOD_RB_SHIFT 29
> #define AMD_FMT_MOD_RB_MASK 0x7
> --
> 2.29.2
>
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/fourcc: fix AMD modifiers PACKERS field doc
2020-11-15 15:48 ` Bas Nieuwenhuizen
@ 2020-11-16 16:13 ` Alex Deucher
0 siblings, 0 replies; 3+ messages in thread
From: Alex Deucher @ 2020-11-16 16:13 UTC (permalink / raw)
To: Bas Nieuwenhuizen
Cc: Daniel Vetter, Simon Ser, ML dri-devel, amd-gfx mailing list
Applied and updated based on the corrected layout.
Thanks!
Alex
On Sun, Nov 15, 2020 at 10:48 AM Bas Nieuwenhuizen
<bas@basnieuwenhuizen.nl> wrote:
>
> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
>
> On Sun, Nov 15, 2020 at 10:39 AM Simon Ser <contact@emersion.fr> wrote:
> >
> > This field doesn't alias with BANK_XOR_BITS: PACKERS is bits 26:28 while
> > BANK_XOR_BITS is bits 23:25.
> >
> > Fixes: 8ba16d599374 ("drm/fourcc: Add AMD DRM modifiers.")
> > Signed-off-by: Simon Ser <contact@emersion.fr>
> > Cc: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
> > Cc: Alex Deucher <alexdeucher@gmail.com>
> > Cc: Daniel Vetter <daniel@ffwll.ch>
> > ---
> > include/uapi/drm/drm_fourcc.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
> > index ca48ed0e6bc1..29c7a8694479 100644
> > --- a/include/uapi/drm/drm_fourcc.h
> > +++ b/include/uapi/drm/drm_fourcc.h
> > @@ -1196,7 +1196,7 @@ drm_fourcc_canonicalize_nvidia_format_mod(__u64 modifier)
> > #define AMD_FMT_MOD_PIPE_XOR_BITS_MASK 0x7
> > #define AMD_FMT_MOD_BANK_XOR_BITS_SHIFT 23
> > #define AMD_FMT_MOD_BANK_XOR_BITS_MASK 0x7
> > -#define AMD_FMT_MOD_PACKERS_SHIFT 26 /* aliases with BANK_XOR_BITS */
> > +#define AMD_FMT_MOD_PACKERS_SHIFT 26
> > #define AMD_FMT_MOD_PACKERS_MASK 0x7
> > #define AMD_FMT_MOD_RB_SHIFT 29
> > #define AMD_FMT_MOD_RB_MASK 0x7
> > --
> > 2.29.2
> >
> >
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-16 16:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-15 9:39 [PATCH] drm/fourcc: fix AMD modifiers PACKERS field doc Simon Ser
2020-11-15 15:48 ` Bas Nieuwenhuizen
2020-11-16 16:13 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).