* [PATCH] drm/amdgpu: disable BACO support for 699F:C7 polaris12 SKU temporarily
@ 2021-08-13 8:09 Evan Quan
2021-08-13 13:54 ` Alex Deucher
2021-08-16 2:37 ` Chen, Guchun
0 siblings, 2 replies; 5+ messages in thread
From: Evan Quan @ 2021-08-13 8:09 UTC (permalink / raw)
To: amd-gfx; +Cc: Alexander.Deucher, Guchun.Chen, Evan Quan
We have a S3 issue on that SKU with BACO enabled. Will bring back this
when that root caused.
Change-Id: I56d4830e6275e20a415808896eecbadfe944070b
Signed-off-by: Evan Quan <evan.quan@amd.com>
---
drivers/gpu/drm/amd/amdgpu/vi.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/amdgpu/vi.c
index fe9a7cc8d9eb..7210f80815b8 100644
--- a/drivers/gpu/drm/amd/amdgpu/vi.c
+++ b/drivers/gpu/drm/amd/amdgpu/vi.c
@@ -904,7 +904,12 @@ static bool vi_asic_supports_baco(struct amdgpu_device *adev)
case CHIP_POLARIS11:
case CHIP_POLARIS12:
case CHIP_TOPAZ:
- return amdgpu_dpm_is_baco_supported(adev);
+ /* Disable BACO support for the specific polaris12 SKU temporarily */
+ if ((adev->pdev->device == 0x699F) &&
+ (adev->pdev->revision == 0xC7))
+ return false;
+ else
+ return amdgpu_dpm_is_baco_supported(adev);
default:
return false;
}
--
2.29.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/amdgpu: disable BACO support for 699F:C7 polaris12 SKU temporarily
2021-08-13 8:09 [PATCH] drm/amdgpu: disable BACO support for 699F:C7 polaris12 SKU temporarily Evan Quan
@ 2021-08-13 13:54 ` Alex Deucher
2021-08-13 13:55 ` Alex Deucher
2021-08-16 2:37 ` Chen, Guchun
1 sibling, 1 reply; 5+ messages in thread
From: Alex Deucher @ 2021-08-13 13:54 UTC (permalink / raw)
To: Evan Quan; +Cc: amd-gfx list, Deucher, Alexander, Chen, Guchun
Acked-by: Alex Deucher <alexander.deucher@amd.com>
On Fri, Aug 13, 2021 at 4:09 AM Evan Quan <evan.quan@amd.com> wrote:
>
> We have a S3 issue on that SKU with BACO enabled. Will bring back this
> when that root caused.
>
> Change-Id: I56d4830e6275e20a415808896eecbadfe944070b
> Signed-off-by: Evan Quan <evan.quan@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/vi.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/amdgpu/vi.c
> index fe9a7cc8d9eb..7210f80815b8 100644
> --- a/drivers/gpu/drm/amd/amdgpu/vi.c
> +++ b/drivers/gpu/drm/amd/amdgpu/vi.c
> @@ -904,7 +904,12 @@ static bool vi_asic_supports_baco(struct amdgpu_device *adev)
> case CHIP_POLARIS11:
> case CHIP_POLARIS12:
> case CHIP_TOPAZ:
> - return amdgpu_dpm_is_baco_supported(adev);
> + /* Disable BACO support for the specific polaris12 SKU temporarily */
> + if ((adev->pdev->device == 0x699F) &&
> + (adev->pdev->revision == 0xC7))
> + return false;
> + else
> + return amdgpu_dpm_is_baco_supported(adev);
> default:
> return false;
> }
> --
> 2.29.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/amdgpu: disable BACO support for 699F:C7 polaris12 SKU temporarily
2021-08-13 13:54 ` Alex Deucher
@ 2021-08-13 13:55 ` Alex Deucher
2021-08-16 4:26 ` Quan, Evan
0 siblings, 1 reply; 5+ messages in thread
From: Alex Deucher @ 2021-08-13 13:55 UTC (permalink / raw)
To: Evan Quan; +Cc: amd-gfx list, Deucher, Alexander, Chen, Guchun
On Fri, Aug 13, 2021 at 9:54 AM Alex Deucher <alexdeucher@gmail.com> wrote:
>
> Acked-by: Alex Deucher <alexander.deucher@amd.com>
>
> On Fri, Aug 13, 2021 at 4:09 AM Evan Quan <evan.quan@amd.com> wrote:
> >
> > We have a S3 issue on that SKU with BACO enabled. Will bring back this
> > when that root caused.
> >
Actually it might be worth checking the SSIDs as well assuming this is
platform specific.
Alex
> > Change-Id: I56d4830e6275e20a415808896eecbadfe944070b
> > Signed-off-by: Evan Quan <evan.quan@amd.com>
> > ---
> > drivers/gpu/drm/amd/amdgpu/vi.c | 7 ++++++-
> > 1 file changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/amdgpu/vi.c
> > index fe9a7cc8d9eb..7210f80815b8 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/vi.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/vi.c
> > @@ -904,7 +904,12 @@ static bool vi_asic_supports_baco(struct amdgpu_device *adev)
> > case CHIP_POLARIS11:
> > case CHIP_POLARIS12:
> > case CHIP_TOPAZ:
> > - return amdgpu_dpm_is_baco_supported(adev);
> > + /* Disable BACO support for the specific polaris12 SKU temporarily */
> > + if ((adev->pdev->device == 0x699F) &&
> > + (adev->pdev->revision == 0xC7))
> > + return false;
> > + else
> > + return amdgpu_dpm_is_baco_supported(adev);
> > default:
> > return false;
> > }
> > --
> > 2.29.0
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] drm/amdgpu: disable BACO support for 699F:C7 polaris12 SKU temporarily
2021-08-13 8:09 [PATCH] drm/amdgpu: disable BACO support for 699F:C7 polaris12 SKU temporarily Evan Quan
2021-08-13 13:54 ` Alex Deucher
@ 2021-08-16 2:37 ` Chen, Guchun
1 sibling, 0 replies; 5+ messages in thread
From: Chen, Guchun @ 2021-08-16 2:37 UTC (permalink / raw)
To: Quan, Evan, amd-gfx; +Cc: Deucher, Alexander
[Public]
Reviewed-by: Guchun Chen <guchun.chen@amd.com>
Regards,
Guchun
-----Original Message-----
From: Quan, Evan <Evan.Quan@amd.com>
Sent: Friday, August 13, 2021 4:10 PM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Chen, Guchun <Guchun.Chen@amd.com>; Quan, Evan <Evan.Quan@amd.com>
Subject: [PATCH] drm/amdgpu: disable BACO support for 699F:C7 polaris12 SKU temporarily
We have a S3 issue on that SKU with BACO enabled. Will bring back this when that root caused.
Change-Id: I56d4830e6275e20a415808896eecbadfe944070b
Signed-off-by: Evan Quan <evan.quan@amd.com>
---
drivers/gpu/drm/amd/amdgpu/vi.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/amdgpu/vi.c index fe9a7cc8d9eb..7210f80815b8 100644
--- a/drivers/gpu/drm/amd/amdgpu/vi.c
+++ b/drivers/gpu/drm/amd/amdgpu/vi.c
@@ -904,7 +904,12 @@ static bool vi_asic_supports_baco(struct amdgpu_device *adev)
case CHIP_POLARIS11:
case CHIP_POLARIS12:
case CHIP_TOPAZ:
- return amdgpu_dpm_is_baco_supported(adev);
+ /* Disable BACO support for the specific polaris12 SKU temporarily */
+ if ((adev->pdev->device == 0x699F) &&
+ (adev->pdev->revision == 0xC7))
+ return false;
+ else
+ return amdgpu_dpm_is_baco_supported(adev);
default:
return false;
}
--
2.29.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] drm/amdgpu: disable BACO support for 699F:C7 polaris12 SKU temporarily
2021-08-13 13:55 ` Alex Deucher
@ 2021-08-16 4:26 ` Quan, Evan
0 siblings, 0 replies; 5+ messages in thread
From: Quan, Evan @ 2021-08-16 4:26 UTC (permalink / raw)
To: Alex Deucher; +Cc: amd-gfx list, Deucher, Alexander, Chen, Guchun
[AMD Official Use Only]
> -----Original Message-----
> From: Alex Deucher <alexdeucher@gmail.com>
> Sent: Friday, August 13, 2021 9:56 PM
> To: Quan, Evan <Evan.Quan@amd.com>
> Cc: amd-gfx list <amd-gfx@lists.freedesktop.org>; Deucher, Alexander
> <Alexander.Deucher@amd.com>; Chen, Guchun <Guchun.Chen@amd.com>
> Subject: Re: [PATCH] drm/amdgpu: disable BACO support for 699F:C7
> polaris12 SKU temporarily
>
> On Fri, Aug 13, 2021 at 9:54 AM Alex Deucher <alexdeucher@gmail.com>
> wrote:
> >
> > Acked-by: Alex Deucher <alexander.deucher@amd.com>
> >
> > On Fri, Aug 13, 2021 at 4:09 AM Evan Quan <evan.quan@amd.com> wrote:
> > >
> > > We have a S3 issue on that SKU with BACO enabled. Will bring back
> > > this when that root caused.
> > >
>
> Actually it might be worth checking the SSIDs as well assuming this is platform
> specific.
[Quan, Evan] Can you share more how to perform that check? Where to get the SSID?
BR
Evan
>
> Alex
>
> > > Change-Id: I56d4830e6275e20a415808896eecbadfe944070b
> > > Signed-off-by: Evan Quan <evan.quan@amd.com>
> > > ---
> > > drivers/gpu/drm/amd/amdgpu/vi.c | 7 ++++++-
> > > 1 file changed, 6 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c
> > > b/drivers/gpu/drm/amd/amdgpu/vi.c index fe9a7cc8d9eb..7210f80815b8
> > > 100644
> > > --- a/drivers/gpu/drm/amd/amdgpu/vi.c
> > > +++ b/drivers/gpu/drm/amd/amdgpu/vi.c
> > > @@ -904,7 +904,12 @@ static bool vi_asic_supports_baco(struct
> amdgpu_device *adev)
> > > case CHIP_POLARIS11:
> > > case CHIP_POLARIS12:
> > > case CHIP_TOPAZ:
> > > - return amdgpu_dpm_is_baco_supported(adev);
> > > + /* Disable BACO support for the specific polaris12 SKU
> temporarily */
> > > + if ((adev->pdev->device == 0x699F) &&
> > > + (adev->pdev->revision == 0xC7))
> > > + return false;
> > > + else
> > > + return amdgpu_dpm_is_baco_supported(adev);
> > > default:
> > > return false;
> > > }
> > > --
> > > 2.29.0
> > >
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-08-16 4:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-13 8:09 [PATCH] drm/amdgpu: disable BACO support for 699F:C7 polaris12 SKU temporarily Evan Quan
2021-08-13 13:54 ` Alex Deucher
2021-08-13 13:55 ` Alex Deucher
2021-08-16 4:26 ` Quan, Evan
2021-08-16 2:37 ` Chen, Guchun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).