From: "Quan, Evan" <Evan.Quan@amd.com>
To: "Kasiviswanathan, Harish" <Harish.Kasiviswanathan@amd.com>,
"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>
Cc: "Kasiviswanathan, Harish" <Harish.Kasiviswanathan@amd.com>
Subject: RE: [PATCH] drm/amdgpu: During compute disable GFXOFF for Sienna_Cichlid
Date: Fri, 23 Oct 2020 01:25:57 +0000 [thread overview]
Message-ID: <DM6PR12MB261957D5CDE34A7B7BFDCD52E41A0@DM6PR12MB2619.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20201022194112.295794-1-Harish.Kasiviswanathan@amd.com>
[AMD Official Use Only - Internal Distribution Only]
Acked-by: Evan Quan <evan.quan@amd.com>
-----Original Message-----
From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Harish Kasiviswanathan
Sent: Friday, October 23, 2020 3:41 AM
To: amd-gfx@lists.freedesktop.org
Cc: Kasiviswanathan, Harish <Harish.Kasiviswanathan@amd.com>
Subject: [PATCH] drm/amdgpu: During compute disable GFXOFF for Sienna_Cichlid
Signed-off-by: Harish Kasiviswanathan <Harish.Kasiviswanathan@amd.com>
Change-Id: Ia9f8872b7654b99864bbef1afb9998d0cf39b7e5
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
index 90fb864ac7aa..450389218516 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
@@ -647,6 +647,13 @@ void amdgpu_amdkfd_set_compute_idle(struct kgd_dev *kgd, bool idle) {
struct amdgpu_device *adev = (struct amdgpu_device *)kgd;
+/* Temp workaround to fix the soft hang observed in certain compute
+ * applications if GFXOFF is enabled.
+ */
+if (adev->asic_type == CHIP_SIENNA_CICHLID) {
+pr_debug("GFXOFF is %s\n", idle ? "enabled" : "disabled");
+amdgpu_gfx_off_ctrl(adev, idle);
+}
amdgpu_dpm_switch_power_profile(adev,
PP_SMC_POWER_PROFILE_COMPUTE,
!idle);
--
2.25.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Cevan.quan%40amd.com%7C6a7e983b34c54c78c77208d876c27ad4%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637389924993589221&sdata=r6%2Bsu380dr9zwKJROx3EU%2FhRcL9WHgUpe3iDXLZRNuA%3D&reserved=0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2020-10-23 1:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 19:41 [PATCH] drm/amdgpu: During compute disable GFXOFF for Sienna_Cichlid Harish Kasiviswanathan
2020-10-22 19:44 ` Alex Deucher
2020-10-23 1:25 ` Quan, Evan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR12MB261957D5CDE34A7B7BFDCD52E41A0@DM6PR12MB2619.namprd12.prod.outlook.com \
--to=evan.quan@amd.com \
--cc=Harish.Kasiviswanathan@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).