[PATCH] drm/amdgpu: During compute disable GFXOFF for Sienna_Cichlid

[PATCH] drm/amdgpu: During compute disable GFXOFF for Sienna_Cichlid

[Harish Kasiviswanathan]

Signed-off-by: Harish Kasiviswanathan <Harish.Kasiviswanathan@amd.com>
Change-Id: Ia9f8872b7654b99864bbef1afb9998d0cf39b7e5
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
index 90fb864ac7aa..450389218516 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
@@ -647,6 +647,13 @@ void amdgpu_amdkfd_set_compute_idle(struct kgd_dev *kgd, bool idle)
 {
 	struct amdgpu_device *adev = (struct amdgpu_device *)kgd;
 
+	/* Temp workaround to fix the soft hang observed in certain compute
+	 * applications if GFXOFF is enabled.
+	 */
+	if (adev->asic_type == CHIP_SIENNA_CICHLID) {
+		pr_debug("GFXOFF is %s\n", idle ? "enabled" : "disabled");
+		amdgpu_gfx_off_ctrl(adev, idle);
+	}
 	amdgpu_dpm_switch_power_profile(adev,
 					PP_SMC_POWER_PROFILE_COMPUTE,
 					!idle);
-- 
2.25.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/amdgpu: During compute disable GFXOFF for Sienna_Cichlid

[Alex Deucher]

On Thu, Oct 22, 2020 at 3:41 PM Harish Kasiviswanathan
<Harish.Kasiviswanathan@amd.com> wrote:
>

Please include a patch description.  With that fixed:
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

> Signed-off-by: Harish Kasiviswanathan <Harish.Kasiviswanathan@amd.com>
> Change-Id: Ia9f8872b7654b99864bbef1afb9998d0cf39b7e5
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
> index 90fb864ac7aa..450389218516 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
> @@ -647,6 +647,13 @@ void amdgpu_amdkfd_set_compute_idle(struct kgd_dev *kgd, bool idle)
>  {
>         struct amdgpu_device *adev = (struct amdgpu_device *)kgd;
>
> +       /* Temp workaround to fix the soft hang observed in certain compute
> +        * applications if GFXOFF is enabled.
> +        */
> +       if (adev->asic_type == CHIP_SIENNA_CICHLID) {
> +               pr_debug("GFXOFF is %s\n", idle ? "enabled" : "disabled");
> +               amdgpu_gfx_off_ctrl(adev, idle);
> +       }
>         amdgpu_dpm_switch_power_profile(adev,
>                                         PP_SMC_POWER_PROFILE_COMPUTE,
>                                         !idle);
> --
> 2.25.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

RE: [PATCH] drm/amdgpu: During compute disable GFXOFF for Sienna_Cichlid

[Quan, Evan]

[AMD Official Use Only - Internal Distribution Only]

Acked-by: Evan Quan <evan.quan@amd.com>

-----Original Message-----
From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Harish Kasiviswanathan
Sent: Friday, October 23, 2020 3:41 AM
To: amd-gfx@lists.freedesktop.org
Cc: Kasiviswanathan, Harish <Harish.Kasiviswanathan@amd.com>
Subject: [PATCH] drm/amdgpu: During compute disable GFXOFF for Sienna_Cichlid

Signed-off-by: Harish Kasiviswanathan <Harish.Kasiviswanathan@amd.com>
Change-Id: Ia9f8872b7654b99864bbef1afb9998d0cf39b7e5
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
index 90fb864ac7aa..450389218516 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
@@ -647,6 +647,13 @@ void amdgpu_amdkfd_set_compute_idle(struct kgd_dev *kgd, bool idle)  {
 struct amdgpu_device *adev = (struct amdgpu_device *)kgd;

+/* Temp workaround to fix the soft hang observed in certain compute
+ * applications if GFXOFF is enabled.
+ */
+if (adev->asic_type == CHIP_SIENNA_CICHLID) {
+pr_debug("GFXOFF is %s\n", idle ? "enabled" : "disabled");
+amdgpu_gfx_off_ctrl(adev, idle);
+}
 amdgpu_dpm_switch_power_profile(adev,
 PP_SMC_POWER_PROFILE_COMPUTE,
 !idle);
--
2.25.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=02%7C01%7Cevan.quan%40amd.com%7C6a7e983b34c54c78c77208d876c27ad4%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637389924993589221&amp;sdata=r6%2Bsu380dr9zwKJROx3EU%2FhRcL9WHgUpe3iDXLZRNuA%3D&amp;reserved=0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx