* [PATCH] drm/amdgpu: remove the alignment placeholder for secure buffer
@ 2020-01-17 7:48 Huang Rui
2020-01-17 7:50 ` Liu, Aaron
2020-01-17 8:12 ` Christian König
0 siblings, 2 replies; 3+ messages in thread
From: Huang Rui @ 2020-01-17 7:48 UTC (permalink / raw)
To: amd-gfx; +Cc: Alex Deucher, Huang Rui, Christian König
The alignment should match the page size for secure buffer, so we didn't
configure it anymore.
Signed-off-by: Huang Rui <ray.huang@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
index f39012e..41d49a0 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
@@ -261,10 +261,6 @@ int amdgpu_gem_create_ioctl(struct drm_device *dev, void *data,
resv = vm->root.base.bo->tbo.base.resv;
}
- if (flags & AMDGPU_GEM_CREATE_ENCRYPTED) {
- /* XXX: pad out alignment to meet TMZ requirements */
- }
-
r = amdgpu_gem_object_create(adev, size, args->in.alignment,
(u32)(0xffffffff & args->in.domains),
flags, ttm_bo_type_device, resv, &gobj);
--
2.7.4
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH] drm/amdgpu: remove the alignment placeholder for secure buffer
2020-01-17 7:48 [PATCH] drm/amdgpu: remove the alignment placeholder for secure buffer Huang Rui
@ 2020-01-17 7:50 ` Liu, Aaron
2020-01-17 8:12 ` Christian König
1 sibling, 0 replies; 3+ messages in thread
From: Liu, Aaron @ 2020-01-17 7:50 UTC (permalink / raw)
To: Huang, Ray, amd-gfx; +Cc: Deucher, Alexander, Huang, Ray, Koenig, Christian
Reviewed-by: Aaron Liu <aaron.liu@amd.com>
BR,
Aaron Liu
> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of
> Huang Rui
> Sent: Friday, January 17, 2020 3:48 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Huang, Ray
> <Ray.Huang@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>
> Subject: [PATCH] drm/amdgpu: remove the alignment placeholder for secure
> buffer
>
> The alignment should match the page size for secure buffer, so we didn't
> configure it anymore.
>
> Signed-off-by: Huang Rui <ray.huang@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> index f39012e..41d49a0 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> @@ -261,10 +261,6 @@ int amdgpu_gem_create_ioctl(struct drm_device
> *dev, void *data,
> resv = vm->root.base.bo->tbo.base.resv;
> }
>
> - if (flags & AMDGPU_GEM_CREATE_ENCRYPTED) {
> - /* XXX: pad out alignment to meet TMZ requirements */
> - }
> -
> r = amdgpu_gem_object_create(adev, size, args->in.alignment,
> (u32)(0xffffffff & args->in.domains),
> flags, ttm_bo_type_device, resv, &gobj);
> --
> 2.7.4
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.f
> reedesktop.org%2Fmailman%2Flistinfo%2Famd-
> gfx&data=02%7C01%7Caaron.liu%40amd.com%7Cfe128e2299c943be48
> 9d08d79b21a418%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C6
> 37148441147752302&sdata=HRtRCe7OUhBK4ScG%2BplLUJiK%2Bn8wU1
> BXxb28r5t2bWk%3D&reserved=0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/amdgpu: remove the alignment placeholder for secure buffer
2020-01-17 7:48 [PATCH] drm/amdgpu: remove the alignment placeholder for secure buffer Huang Rui
2020-01-17 7:50 ` Liu, Aaron
@ 2020-01-17 8:12 ` Christian König
1 sibling, 0 replies; 3+ messages in thread
From: Christian König @ 2020-01-17 8:12 UTC (permalink / raw)
To: Huang Rui, amd-gfx; +Cc: Alex Deucher
Am 17.01.20 um 08:48 schrieb Huang Rui:
> The alignment should match the page size for secure buffer, so we didn't
> configure it anymore.
>
> Signed-off-by: Huang Rui <ray.huang@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> index f39012e..41d49a0 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> @@ -261,10 +261,6 @@ int amdgpu_gem_create_ioctl(struct drm_device *dev, void *data,
> resv = vm->root.base.bo->tbo.base.resv;
> }
>
> - if (flags & AMDGPU_GEM_CREATE_ENCRYPTED) {
> - /* XXX: pad out alignment to meet TMZ requirements */
> - }
> -
> r = amdgpu_gem_object_create(adev, size, args->in.alignment,
> (u32)(0xffffffff & args->in.domains),
> flags, ttm_bo_type_device, resv, &gobj);
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-17 8:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-17 7:48 [PATCH] drm/amdgpu: remove the alignment placeholder for secure buffer Huang Rui
2020-01-17 7:50 ` Liu, Aaron
2020-01-17 8:12 ` Christian König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).