[PATCH] drm/amd/display: Fix apply_synaptics_fifo_reset_wa()

* [PATCH] drm/amd/display: Fix apply_synaptics_fifo_reset_wa()
@ 2022-07-26 15:23 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2022-07-26 15:23 UTC (permalink / raw)
  To: Harry Wentland, Fangzhi Zuo
  Cc: Ian Chen, Leo Li, kernel-janitors, Pan, Xinhui, Rodrigo Siqueira,
	Roman Li, amd-gfx, David Airlie, Fangzhi Zuo, Claudio Suarez,
	Daniel Vetter, Wayne Lin, Alex Deucher, Hersen Wu, Mikita Lipski,
	Bhawanpreet Lakha, Christian König

There is a stray return which accidentally turns the last part of the
function into dead code.

Fixes: 2ca97adccdc9 ("drm/amd/display: Add Synaptics Fifo Reset Workaround")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
From static analysis.  Untested.

 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
index a0154a5f7183..0d200e276e67 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
@@ -671,7 +671,6 @@ static void apply_synaptics_fifo_reset_wa(struct drm_dp_aux *aux)
 		return;
 
 	data[0] |= (1 << 1); // set bit 1 to 1
-		return;
 
 	if (!execute_synaptics_rc_command(aux, false, 0x31, 4, 0x221198, data))
 		return;
-- 
2.35.1


^ permalink raw reply related	[flat|nested] only message in thread