* [PATCH] drm/amdgpu: drop the non-sense firmware version check on arcturus
@ 2020-02-17 10:32 Evan Quan
2020-02-17 11:06 ` Christian König
0 siblings, 1 reply; 2+ messages in thread
From: Evan Quan @ 2020-02-17 10:32 UTC (permalink / raw)
To: amd-gfx; +Cc: Evan Quan
As the firmware versions of arcturus are different from other gfx9
ASICs. And the warning("CP firmware version too old, please update!")
caused by this check can be eliminated.
Change-Id: I04ab0e435b6ff9712be502e6ebb8d6e1f0a776d8
Signed-off-by: Evan Quan <evan.quan@amd.com>
---
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
index 9b7ff783e9a5..1c7a16b91686 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
@@ -1106,10 +1106,11 @@ static void gfx_v9_0_check_fw_write_wait(struct amdgpu_device *adev)
adev->gfx.me_fw_write_wait = false;
adev->gfx.mec_fw_write_wait = false;
- if ((adev->gfx.mec_fw_version < 0x000001a5) ||
+ if ((adev->asic_type != CHIP_ARCTURUS) &&
+ ((adev->gfx.mec_fw_version < 0x000001a5) ||
(adev->gfx.mec_feature_version < 46) ||
(adev->gfx.pfp_fw_version < 0x000000b7) ||
- (adev->gfx.pfp_feature_version < 46))
+ (adev->gfx.pfp_feature_version < 46)))
DRM_WARN_ONCE("CP firmware version too old, please update!");
switch (adev->asic_type) {
--
2.25.0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/amdgpu: drop the non-sense firmware version check on arcturus
2020-02-17 10:32 [PATCH] drm/amdgpu: drop the non-sense firmware version check on arcturus Evan Quan
@ 2020-02-17 11:06 ` Christian König
0 siblings, 0 replies; 2+ messages in thread
From: Christian König @ 2020-02-17 11:06 UTC (permalink / raw)
To: Evan Quan, amd-gfx
Am 17.02.20 um 11:32 schrieb Evan Quan:
> As the firmware versions of arcturus are different from other gfx9
> ASICs. And the warning("CP firmware version too old, please update!")
> caused by this check can be eliminated.
>
> Change-Id: I04ab0e435b6ff9712be502e6ebb8d6e1f0a776d8
> Signed-off-by: Evan Quan <evan.quan@amd.com>
Acked-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> index 9b7ff783e9a5..1c7a16b91686 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> @@ -1106,10 +1106,11 @@ static void gfx_v9_0_check_fw_write_wait(struct amdgpu_device *adev)
> adev->gfx.me_fw_write_wait = false;
> adev->gfx.mec_fw_write_wait = false;
>
> - if ((adev->gfx.mec_fw_version < 0x000001a5) ||
> + if ((adev->asic_type != CHIP_ARCTURUS) &&
> + ((adev->gfx.mec_fw_version < 0x000001a5) ||
> (adev->gfx.mec_feature_version < 46) ||
> (adev->gfx.pfp_fw_version < 0x000000b7) ||
> - (adev->gfx.pfp_feature_version < 46))
> + (adev->gfx.pfp_feature_version < 46)))
> DRM_WARN_ONCE("CP firmware version too old, please update!");
>
> switch (adev->asic_type) {
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-17 11:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-17 10:32 [PATCH] drm/amdgpu: drop the non-sense firmware version check on arcturus Evan Quan
2020-02-17 11:06 ` Christian König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).