* [PATCH] soc: apple: sart: Stop casting function pointer signatures
@ 2022-11-04 15:39 Sven Peter
2022-11-28 11:35 ` Hector Martin
0 siblings, 1 reply; 2+ messages in thread
From: Sven Peter @ 2022-11-04 15:39 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Sven Peter, Hector Martin, Alyssa Rosenzweig, asahi,
linux-arm-kernel, linux-kernel, kernel test robot
Fixes: b170143ae111 ("soc: apple: Add SART driver")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Sven Peter <sven@svenpeter.dev>
---
drivers/soc/apple/sart.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/soc/apple/sart.c b/drivers/soc/apple/sart.c
index 83804b16ad03..afa111736899 100644
--- a/drivers/soc/apple/sart.c
+++ b/drivers/soc/apple/sart.c
@@ -164,6 +164,11 @@ static int apple_sart_probe(struct platform_device *pdev)
return 0;
}
+static void apple_sart_put_device(void *dev)
+{
+ put_device(dev);
+}
+
struct apple_sart *devm_apple_sart_get(struct device *dev)
{
struct device_node *sart_node;
@@ -187,7 +192,7 @@ struct apple_sart *devm_apple_sart_get(struct device *dev)
return ERR_PTR(-EPROBE_DEFER);
}
- ret = devm_add_action_or_reset(dev, (void (*)(void *))put_device,
+ ret = devm_add_action_or_reset(dev, apple_sart_put_device,
&sart_pdev->dev);
if (ret)
return ERR_PTR(ret);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] soc: apple: sart: Stop casting function pointer signatures
2022-11-04 15:39 [PATCH] soc: apple: sart: Stop casting function pointer signatures Sven Peter
@ 2022-11-28 11:35 ` Hector Martin
0 siblings, 0 replies; 2+ messages in thread
From: Hector Martin @ 2022-11-28 11:35 UTC (permalink / raw)
To: Sven Peter, Arnd Bergmann
Cc: Alyssa Rosenzweig, asahi, linux-arm-kernel, linux-kernel,
kernel test robot
On 05/11/2022 00.39, Sven Peter wrote:
> Fixes: b170143ae111 ("soc: apple: Add SART driver")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Sven Peter <sven@svenpeter.dev>
> ---
> drivers/soc/apple/sart.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/soc/apple/sart.c b/drivers/soc/apple/sart.c
> index 83804b16ad03..afa111736899 100644
> --- a/drivers/soc/apple/sart.c
> +++ b/drivers/soc/apple/sart.c
> @@ -164,6 +164,11 @@ static int apple_sart_probe(struct platform_device *pdev)
> return 0;
> }
>
> +static void apple_sart_put_device(void *dev)
> +{
> + put_device(dev);
> +}
> +
> struct apple_sart *devm_apple_sart_get(struct device *dev)
> {
> struct device_node *sart_node;
> @@ -187,7 +192,7 @@ struct apple_sart *devm_apple_sart_get(struct device *dev)
> return ERR_PTR(-EPROBE_DEFER);
> }
>
> - ret = devm_add_action_or_reset(dev, (void (*)(void *))put_device,
> + ret = devm_add_action_or_reset(dev, apple_sart_put_device,
> &sart_pdev->dev);
> if (ret)
> return ERR_PTR(ret);
Applied to asahi-soc/soc, thanks!
- Hector
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-28 11:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-04 15:39 [PATCH] soc: apple: sart: Stop casting function pointer signatures Sven Peter
2022-11-28 11:35 ` Hector Martin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).