From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Martin Povišer" <povik+lin@cutebit.org>
Cc: "Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Nuno Sá" <nuno.sa@analog.com>,
asahi@lists.linux.dev, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ASoC: dt-bindings: Add adi,ssm3515 amp schema
Date: Wed, 10 May 2023 10:23:32 +0200 [thread overview]
Message-ID: <627f1739-98b4-9576-4b11-887c8f7e0c52@linaro.org> (raw)
In-Reply-To: <04BB0158-6C7B-400C-A87A-6E9B2835FDC7@cutebit.org>
On 10/05/2023 10:15, Martin Povišer wrote:
>
>> On 10. 5. 2023, at 9:51, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 09/05/2023 18:38, Martin Povišer wrote:
>>> Add a DT schema for the SSM3515 amp by Analog Devices. It's a simple
>>> mono amplifier with digital input.
>>>
>>> Signed-off-by: Martin Povišer <povik+lin@cutebit.org>
>>
>>
>>> + reg:
>>> + maxItems: 1
>>> +
>>> + adi,ana-gain:
>>> + $ref: /schemas/types.yaml#/definitions/uint32
>>> + enum: [0, 1, 2, 3]
>>> + description: |
>>> + The value to be set in the ANA_GAIN register field on the codec. This determines
>>> + the full voltage span of the codec's analog output.
>>> +
>>> + To quote the datasheet on the available options:
>>> +
>>> + 00: 8.4 V Full-Scale Gain Mapping
>>> + 01: 12.6 V Full-Scale Gain Mapping
>>> + 10: 14 V Full-Scale Gain Mapping
>>> + 11: 15 V Full-Scale Gain Mapping
>>> +
>>> + '#sound-dai-cells':
>>> + const: 0
>>> +
>>> +required:
>>> + - compatible
>>> + - reg
>>> + - adi,ana-gain
>>> +
>>> +additionalProperties: true
>>
>> uinevaluatedProperties: false instead, so users can have name-prefix.
>
> I actually tweaked this to have the example passing, which has sound-name-prefix,
true is not allowed anyway - it makes your schema simply not effective
almost at all as it allows anything...
> which I guess is what you have in mind. Not that I exactly understand what these
> options do (both additionalProperties and unevaluatedProperties), the schema docs
> didn’t enlighten me right away when I looked into it.
The way to go and to start always is to look at example-schema. It tells
you explicitly to use additionalProperties:false and switch to
unevaluated "If and only if another schema is referenced".
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-05-10 8:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-09 16:38 [PATCH 1/2] ASoC: dt-bindings: Add adi,ssm3515 amp schema Martin Povišer
2023-05-09 16:38 ` [PATCH 2/2] ASoC: ssm3515: Add new amp driver Martin Povišer
2023-05-10 2:16 ` Mark Brown
2023-05-10 6:23 ` Martin Povišer
2023-05-09 18:25 ` [PATCH 1/2] ASoC: dt-bindings: Add adi,ssm3515 amp schema Conor Dooley
2023-05-09 19:38 ` Martin Povišer
2023-05-10 2:10 ` Mark Brown
2023-05-10 7:51 ` Krzysztof Kozlowski
2023-05-11 1:11 ` Mark Brown
2023-05-10 7:51 ` Krzysztof Kozlowski
2023-05-10 8:15 ` Martin Povišer
2023-05-10 8:23 ` Krzysztof Kozlowski [this message]
2023-05-10 8:29 ` Martin Povišer
2023-05-10 8:30 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=627f1739-98b4-9576-4b11-887c8f7e0c52@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=asahi@lists.linux.dev \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=perex@perex.cz \
--cc=povik+lin@cutebit.org \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).