From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Conor Dooley" <conor@kernel.org>,
"Martin Povišer" <povik+lin@cutebit.org>
Cc: "Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Nuno Sá" <nuno.sa@analog.com>,
asahi@lists.linux.dev, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ASoC: dt-bindings: Add adi,ssm3515 amp schema
Date: Wed, 10 May 2023 09:51:50 +0200 [thread overview]
Message-ID: <f38b984c-e49a-0686-a907-5d86ea93d7bc@linaro.org> (raw)
In-Reply-To: <20230509-marxism-plug-759c99ac601c@spud>
On 09/05/2023 20:25, Conor Dooley wrote:
> Hey Martin,
>
> On Tue, May 09, 2023 at 06:38:27PM +0200, Martin Povišer wrote:
>> Add a DT schema for the SSM3515 amp by Analog Devices. It's a simple
>> mono amplifier with digital input.
>>
>> Signed-off-by: Martin Povišer <povik+lin@cutebit.org>
>> ---
>> .../bindings/sound/adi,ssm3515.yaml | 66 +++++++++++++++++++
>> 1 file changed, 66 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/sound/adi,ssm3515.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/sound/adi,ssm3515.yaml b/Documentation/devicetree/bindings/sound/adi,ssm3515.yaml
>> new file mode 100644
>> index 000000000000..19b7185ae8e2
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/sound/adi,ssm3515.yaml
>> @@ -0,0 +1,66 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +# Copyright (C) 2019-20 Texas Instruments Incorporated
>
> Copyright here looks a little odd, copy & paste from the TI bindings you
> send patches for earlier, or intended?
>
>> +%YAML 1.2
>> +---
>> +$id: "http://devicetree.org/schemas/sound/adi,ssm3515.yaml#"
>> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
>
> Drop the quotes on these please.
>
>> +
>> +title: Analog Devices SSM3515 Audio Amplifier
>> +
>> +maintainers:
>> + - Martin Povišer <povik+lin@cutebit.org>
>> +
>> +description: |
>> + SSM3515 is a mono Class-D audio amplifier with digital input.
>> +
>> + https://www.analog.com/media/en/technical-documentation/data-sheets/SSM3515.pdf
>> +
>> +allOf:
>> + - $ref: dai-common.yaml#
>> +
>> +properties:
>> + compatible:
>> + enum:
>> + - adi,ssm3515
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + adi,ana-gain:
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + enum: [0, 1, 2, 3]
>> + description: |
>> + The value to be set in the ANA_GAIN register field on the codec. This determines
>> + the full voltage span of the codec's analog output.
>> +
>> + To quote the datasheet on the available options:
>> +
>> + 00: 8.4 V Full-Scale Gain Mapping
>> + 01: 12.6 V Full-Scale Gain Mapping
>> + 10: 14 V Full-Scale Gain Mapping
>> + 11: 15 V Full-Scale Gain Mapping
>
> Putting register values into the DT does not seem correct, although
> I know nothing about sound and will have to defer to Krzysztof & Co. on
> that front.
Depends whether these are really voltages or something else (e.g. gain)
just related to voltage.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-05-10 7:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-09 16:38 [PATCH 1/2] ASoC: dt-bindings: Add adi,ssm3515 amp schema Martin Povišer
2023-05-09 16:38 ` [PATCH 2/2] ASoC: ssm3515: Add new amp driver Martin Povišer
2023-05-10 2:16 ` Mark Brown
2023-05-10 6:23 ` Martin Povišer
2023-05-09 18:25 ` [PATCH 1/2] ASoC: dt-bindings: Add adi,ssm3515 amp schema Conor Dooley
2023-05-09 19:38 ` Martin Povišer
2023-05-10 2:10 ` Mark Brown
2023-05-10 7:51 ` Krzysztof Kozlowski [this message]
2023-05-11 1:11 ` Mark Brown
2023-05-10 7:51 ` Krzysztof Kozlowski
2023-05-10 8:15 ` Martin Povišer
2023-05-10 8:23 ` Krzysztof Kozlowski
2023-05-10 8:29 ` Martin Povišer
2023-05-10 8:30 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f38b984c-e49a-0686-a907-5d86ea93d7bc@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=asahi@lists.linux.dev \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=perex@perex.cz \
--cc=povik+lin@cutebit.org \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).