* [PATCH 1/5] wifi: ath11k: Remove redundant pci_clear_master
@ 2023-03-23 11:26 Cai Huoqing
2023-03-23 11:26 ` [PATCH 2/5] wifi: ath10k: " Cai Huoqing
` (5 more replies)
0 siblings, 6 replies; 13+ messages in thread
From: Cai Huoqing @ 2023-03-23 11:26 UTC (permalink / raw)
To: cai.huoqing
Cc: Kalle Valo, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Yan-Hsuan Chuang, Ping-Ke Shih, ath10k,
linux-wireless, netdev, linux-kernel, ath11k, ath12k
Remove pci_clear_master to simplify the code,
the bus-mastering is also cleared in do_pci_disable_device,
like this:
./drivers/pci/pci.c:2197
static void do_pci_disable_device(struct pci_dev *dev)
{
u16 pci_command;
pci_read_config_word(dev, PCI_COMMAND, &pci_command);
if (pci_command & PCI_COMMAND_MASTER) {
pci_command &= ~PCI_COMMAND_MASTER;
pci_write_config_word(dev, PCI_COMMAND, pci_command);
}
pcibios_disable_device(dev);
}.
And dev->is_busmaster is set to 0 in pci_disable_device.
Signed-off-by: Cai Huoqing <cai.huoqing@linux.dev>
---
drivers/net/wireless/ath/ath11k/pci.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/wireless/ath/ath11k/pci.c b/drivers/net/wireless/ath/ath11k/pci.c
index 0aeef2948ff5..522d01e5e11c 100644
--- a/drivers/net/wireless/ath/ath11k/pci.c
+++ b/drivers/net/wireless/ath/ath11k/pci.c
@@ -540,7 +540,7 @@ static int ath11k_pci_claim(struct ath11k_pci *ab_pci, struct pci_dev *pdev)
if (!ab->mem) {
ath11k_err(ab, "failed to map pci bar %d\n", ATH11K_PCI_BAR_NUM);
ret = -EIO;
- goto clear_master;
+ goto release_region;
}
ab->mem_ce = ab->mem;
@@ -548,8 +548,6 @@ static int ath11k_pci_claim(struct ath11k_pci *ab_pci, struct pci_dev *pdev)
ath11k_dbg(ab, ATH11K_DBG_BOOT, "boot pci_mem 0x%pK\n", ab->mem);
return 0;
-clear_master:
- pci_clear_master(pdev);
release_region:
pci_release_region(pdev, ATH11K_PCI_BAR_NUM);
disable_device:
@@ -565,7 +563,6 @@ static void ath11k_pci_free_region(struct ath11k_pci *ab_pci)
pci_iounmap(pci_dev, ab->mem);
ab->mem = NULL;
- pci_clear_master(pci_dev);
pci_release_region(pci_dev, ATH11K_PCI_BAR_NUM);
if (pci_is_enabled(pci_dev))
pci_disable_device(pci_dev);
--
2.34.1
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 2/5] wifi: ath10k: Remove redundant pci_clear_master
2023-03-23 11:26 [PATCH 1/5] wifi: ath11k: Remove redundant pci_clear_master Cai Huoqing
@ 2023-03-23 11:26 ` Cai Huoqing
2023-03-26 9:30 ` Simon Horman
2023-03-23 11:26 ` [PATCH 3/5] wifi: ath12k: " Cai Huoqing
` (4 subsequent siblings)
5 siblings, 1 reply; 13+ messages in thread
From: Cai Huoqing @ 2023-03-23 11:26 UTC (permalink / raw)
To: cai.huoqing
Cc: Kalle Valo, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Yan-Hsuan Chuang, Ping-Ke Shih, ath10k,
linux-wireless, netdev, linux-kernel, ath11k, ath12k
Remove pci_clear_master to simplify the code,
the bus-mastering is also cleared in do_pci_disable_device,
like this:
./drivers/pci/pci.c:2197
static void do_pci_disable_device(struct pci_dev *dev)
{
u16 pci_command;
pci_read_config_word(dev, PCI_COMMAND, &pci_command);
if (pci_command & PCI_COMMAND_MASTER) {
pci_command &= ~PCI_COMMAND_MASTER;
pci_write_config_word(dev, PCI_COMMAND, pci_command);
}
pcibios_disable_device(dev);
}.
And dev->is_busmaster is set to 0 in pci_disable_device.
Signed-off-by: Cai Huoqing <cai.huoqing@linux.dev>
---
drivers/net/wireless/ath/ath10k/pci.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c
index 728d607289c3..a7f44f6335fb 100644
--- a/drivers/net/wireless/ath/ath10k/pci.c
+++ b/drivers/net/wireless/ath/ath10k/pci.c
@@ -3406,15 +3406,12 @@ static int ath10k_pci_claim(struct ath10k *ar)
if (!ar_pci->mem) {
ath10k_err(ar, "failed to iomap BAR%d\n", BAR_NUM);
ret = -EIO;
- goto err_master;
+ goto err_region;
}
ath10k_dbg(ar, ATH10K_DBG_BOOT, "boot pci_mem 0x%pK\n", ar_pci->mem);
return 0;
-err_master:
- pci_clear_master(pdev);
-
err_region:
pci_release_region(pdev, BAR_NUM);
@@ -3431,7 +3428,6 @@ static void ath10k_pci_release(struct ath10k *ar)
pci_iounmap(pdev, ar_pci->mem);
pci_release_region(pdev, BAR_NUM);
- pci_clear_master(pdev);
pci_disable_device(pdev);
}
--
2.34.1
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 3/5] wifi: ath12k: Remove redundant pci_clear_master
2023-03-23 11:26 [PATCH 1/5] wifi: ath11k: Remove redundant pci_clear_master Cai Huoqing
2023-03-23 11:26 ` [PATCH 2/5] wifi: ath10k: " Cai Huoqing
@ 2023-03-23 11:26 ` Cai Huoqing
2023-03-26 9:31 ` Simon Horman
2023-03-23 11:26 ` [PATCH 4/5] wifi: rtw88: " Cai Huoqing
` (3 subsequent siblings)
5 siblings, 1 reply; 13+ messages in thread
From: Cai Huoqing @ 2023-03-23 11:26 UTC (permalink / raw)
To: cai.huoqing
Cc: Kalle Valo, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Yan-Hsuan Chuang, Ping-Ke Shih, ath10k,
linux-wireless, netdev, linux-kernel, ath11k, ath12k
Remove pci_clear_master to simplify the code,
the bus-mastering is also cleared in do_pci_disable_device,
like this:
./drivers/pci/pci.c:2197
static void do_pci_disable_device(struct pci_dev *dev)
{
u16 pci_command;
pci_read_config_word(dev, PCI_COMMAND, &pci_command);
if (pci_command & PCI_COMMAND_MASTER) {
pci_command &= ~PCI_COMMAND_MASTER;
pci_write_config_word(dev, PCI_COMMAND, pci_command);
}
pcibios_disable_device(dev);
}.
And dev->is_busmaster is set to 0 in pci_disable_device.
Signed-off-by: Cai Huoqing <cai.huoqing@linux.dev>
---
drivers/net/wireless/ath/ath12k/pci.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/wireless/ath/ath12k/pci.c b/drivers/net/wireless/ath/ath12k/pci.c
index d32637b0113d..9ee47caf8485 100644
--- a/drivers/net/wireless/ath/ath12k/pci.c
+++ b/drivers/net/wireless/ath/ath12k/pci.c
@@ -755,14 +755,12 @@ static int ath12k_pci_claim(struct ath12k_pci *ab_pci, struct pci_dev *pdev)
if (!ab->mem) {
ath12k_err(ab, "failed to map pci bar %d\n", ATH12K_PCI_BAR_NUM);
ret = -EIO;
- goto clear_master;
+ goto release_region;
}
ath12k_dbg(ab, ATH12K_DBG_BOOT, "boot pci_mem 0x%pK\n", ab->mem);
return 0;
-clear_master:
- pci_clear_master(pdev);
release_region:
pci_release_region(pdev, ATH12K_PCI_BAR_NUM);
disable_device:
@@ -778,7 +776,6 @@ static void ath12k_pci_free_region(struct ath12k_pci *ab_pci)
pci_iounmap(pci_dev, ab->mem);
ab->mem = NULL;
- pci_clear_master(pci_dev);
pci_release_region(pci_dev, ATH12K_PCI_BAR_NUM);
if (pci_is_enabled(pci_dev))
pci_disable_device(pci_dev);
--
2.34.1
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 4/5] wifi: rtw88: Remove redundant pci_clear_master
2023-03-23 11:26 [PATCH 1/5] wifi: ath11k: Remove redundant pci_clear_master Cai Huoqing
2023-03-23 11:26 ` [PATCH 2/5] wifi: ath10k: " Cai Huoqing
2023-03-23 11:26 ` [PATCH 3/5] wifi: ath12k: " Cai Huoqing
@ 2023-03-23 11:26 ` Cai Huoqing
2023-03-26 9:31 ` Simon Horman
2023-03-31 14:49 ` Kalle Valo
2023-03-23 11:26 ` [PATCH 5/5] wifi: rtw89: " Cai Huoqing
` (2 subsequent siblings)
5 siblings, 2 replies; 13+ messages in thread
From: Cai Huoqing @ 2023-03-23 11:26 UTC (permalink / raw)
To: cai.huoqing
Cc: Kalle Valo, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Yan-Hsuan Chuang, Ping-Ke Shih, ath10k,
linux-wireless, netdev, linux-kernel, ath11k, ath12k
Remove pci_clear_master to simplify the code,
the bus-mastering is also cleared in do_pci_disable_device,
like this:
./drivers/pci/pci.c:2197
static void do_pci_disable_device(struct pci_dev *dev)
{
u16 pci_command;
pci_read_config_word(dev, PCI_COMMAND, &pci_command);
if (pci_command & PCI_COMMAND_MASTER) {
pci_command &= ~PCI_COMMAND_MASTER;
pci_write_config_word(dev, PCI_COMMAND, pci_command);
}
pcibios_disable_device(dev);
}.
And dev->is_busmaster is set to 0 in pci_disable_device.
Signed-off-by: Cai Huoqing <cai.huoqing@linux.dev>
---
drivers/net/wireless/realtek/rtw88/pci.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtw88/pci.c b/drivers/net/wireless/realtek/rtw88/pci.c
index b4bd831c9845..60145d2f3e5a 100644
--- a/drivers/net/wireless/realtek/rtw88/pci.c
+++ b/drivers/net/wireless/realtek/rtw88/pci.c
@@ -1552,7 +1552,6 @@ static int rtw_pci_claim(struct rtw_dev *rtwdev, struct pci_dev *pdev)
static void rtw_pci_declaim(struct rtw_dev *rtwdev, struct pci_dev *pdev)
{
- pci_clear_master(pdev);
pci_disable_device(pdev);
}
--
2.34.1
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 5/5] wifi: rtw89: Remove redundant pci_clear_master
2023-03-23 11:26 [PATCH 1/5] wifi: ath11k: Remove redundant pci_clear_master Cai Huoqing
` (2 preceding siblings ...)
2023-03-23 11:26 ` [PATCH 4/5] wifi: rtw88: " Cai Huoqing
@ 2023-03-23 11:26 ` Cai Huoqing
2023-03-26 9:31 ` Simon Horman
2023-04-03 13:38 ` Kalle Valo
2023-03-26 9:30 ` [PATCH 1/5] wifi: ath11k: " Simon Horman
2023-04-12 10:03 ` Kalle Valo
5 siblings, 2 replies; 13+ messages in thread
From: Cai Huoqing @ 2023-03-23 11:26 UTC (permalink / raw)
To: cai.huoqing
Cc: Kalle Valo, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Yan-Hsuan Chuang, Ping-Ke Shih, ath10k,
linux-wireless, netdev, linux-kernel, ath11k, ath12k
Remove pci_clear_master to simplify the code,
the bus-mastering is also cleared in do_pci_disable_device,
like this:
./drivers/pci/pci.c:2197
static void do_pci_disable_device(struct pci_dev *dev)
{
u16 pci_command;
pci_read_config_word(dev, PCI_COMMAND, &pci_command);
if (pci_command & PCI_COMMAND_MASTER) {
pci_command &= ~PCI_COMMAND_MASTER;
pci_write_config_word(dev, PCI_COMMAND, pci_command);
}
pcibios_disable_device(dev);
}.
And dev->is_busmaster is set to 0 in pci_disable_device.
Signed-off-by: Cai Huoqing <cai.huoqing@linux.dev>
---
drivers/net/wireless/realtek/rtw89/pci.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtw89/pci.c b/drivers/net/wireless/realtek/rtw89/pci.c
index ec8bb5f10482..75bd3ac4dd71 100644
--- a/drivers/net/wireless/realtek/rtw89/pci.c
+++ b/drivers/net/wireless/realtek/rtw89/pci.c
@@ -2694,7 +2694,6 @@ static int rtw89_pci_claim_device(struct rtw89_dev *rtwdev,
static void rtw89_pci_declaim_device(struct rtw89_dev *rtwdev,
struct pci_dev *pdev)
{
- pci_clear_master(pdev);
pci_disable_device(pdev);
}
--
2.34.1
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH 1/5] wifi: ath11k: Remove redundant pci_clear_master
2023-03-23 11:26 [PATCH 1/5] wifi: ath11k: Remove redundant pci_clear_master Cai Huoqing
` (3 preceding siblings ...)
2023-03-23 11:26 ` [PATCH 5/5] wifi: rtw89: " Cai Huoqing
@ 2023-03-26 9:30 ` Simon Horman
2023-04-12 10:03 ` Kalle Valo
5 siblings, 0 replies; 13+ messages in thread
From: Simon Horman @ 2023-03-26 9:30 UTC (permalink / raw)
To: Cai Huoqing
Cc: Kalle Valo, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Yan-Hsuan Chuang, Ping-Ke Shih, ath10k,
linux-wireless, netdev, linux-kernel, ath11k, ath12k
On Thu, Mar 23, 2023 at 07:26:09PM +0800, Cai Huoqing wrote:
> Remove pci_clear_master to simplify the code,
> the bus-mastering is also cleared in do_pci_disable_device,
> like this:
> ./drivers/pci/pci.c:2197
> static void do_pci_disable_device(struct pci_dev *dev)
> {
> u16 pci_command;
>
> pci_read_config_word(dev, PCI_COMMAND, &pci_command);
> if (pci_command & PCI_COMMAND_MASTER) {
> pci_command &= ~PCI_COMMAND_MASTER;
> pci_write_config_word(dev, PCI_COMMAND, pci_command);
> }
>
> pcibios_disable_device(dev);
> }.
> And dev->is_busmaster is set to 0 in pci_disable_device.
>
> Signed-off-by: Cai Huoqing <cai.huoqing@linux.dev>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 2/5] wifi: ath10k: Remove redundant pci_clear_master
2023-03-23 11:26 ` [PATCH 2/5] wifi: ath10k: " Cai Huoqing
@ 2023-03-26 9:30 ` Simon Horman
0 siblings, 0 replies; 13+ messages in thread
From: Simon Horman @ 2023-03-26 9:30 UTC (permalink / raw)
To: Cai Huoqing
Cc: Kalle Valo, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Yan-Hsuan Chuang, Ping-Ke Shih, ath10k,
linux-wireless, netdev, linux-kernel, ath11k, ath12k
On Thu, Mar 23, 2023 at 07:26:10PM +0800, Cai Huoqing wrote:
> Remove pci_clear_master to simplify the code,
> the bus-mastering is also cleared in do_pci_disable_device,
> like this:
> ./drivers/pci/pci.c:2197
> static void do_pci_disable_device(struct pci_dev *dev)
> {
> u16 pci_command;
>
> pci_read_config_word(dev, PCI_COMMAND, &pci_command);
> if (pci_command & PCI_COMMAND_MASTER) {
> pci_command &= ~PCI_COMMAND_MASTER;
> pci_write_config_word(dev, PCI_COMMAND, pci_command);
> }
>
> pcibios_disable_device(dev);
> }.
> And dev->is_busmaster is set to 0 in pci_disable_device.
>
> Signed-off-by: Cai Huoqing <cai.huoqing@linux.dev>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 3/5] wifi: ath12k: Remove redundant pci_clear_master
2023-03-23 11:26 ` [PATCH 3/5] wifi: ath12k: " Cai Huoqing
@ 2023-03-26 9:31 ` Simon Horman
0 siblings, 0 replies; 13+ messages in thread
From: Simon Horman @ 2023-03-26 9:31 UTC (permalink / raw)
To: Cai Huoqing
Cc: Kalle Valo, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Yan-Hsuan Chuang, Ping-Ke Shih, ath10k,
linux-wireless, netdev, linux-kernel, ath11k, ath12k
On Thu, Mar 23, 2023 at 07:26:11PM +0800, Cai Huoqing wrote:
> Remove pci_clear_master to simplify the code,
> the bus-mastering is also cleared in do_pci_disable_device,
> like this:
> ./drivers/pci/pci.c:2197
> static void do_pci_disable_device(struct pci_dev *dev)
> {
> u16 pci_command;
>
> pci_read_config_word(dev, PCI_COMMAND, &pci_command);
> if (pci_command & PCI_COMMAND_MASTER) {
> pci_command &= ~PCI_COMMAND_MASTER;
> pci_write_config_word(dev, PCI_COMMAND, pci_command);
> }
>
> pcibios_disable_device(dev);
> }.
> And dev->is_busmaster is set to 0 in pci_disable_device.
>
> Signed-off-by: Cai Huoqing <cai.huoqing@linux.dev>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 4/5] wifi: rtw88: Remove redundant pci_clear_master
2023-03-23 11:26 ` [PATCH 4/5] wifi: rtw88: " Cai Huoqing
@ 2023-03-26 9:31 ` Simon Horman
2023-03-31 14:49 ` Kalle Valo
1 sibling, 0 replies; 13+ messages in thread
From: Simon Horman @ 2023-03-26 9:31 UTC (permalink / raw)
To: Cai Huoqing
Cc: Kalle Valo, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Yan-Hsuan Chuang, Ping-Ke Shih, ath10k,
linux-wireless, netdev, linux-kernel, ath11k, ath12k
On Thu, Mar 23, 2023 at 07:26:12PM +0800, Cai Huoqing wrote:
> Remove pci_clear_master to simplify the code,
> the bus-mastering is also cleared in do_pci_disable_device,
> like this:
> ./drivers/pci/pci.c:2197
> static void do_pci_disable_device(struct pci_dev *dev)
> {
> u16 pci_command;
>
> pci_read_config_word(dev, PCI_COMMAND, &pci_command);
> if (pci_command & PCI_COMMAND_MASTER) {
> pci_command &= ~PCI_COMMAND_MASTER;
> pci_write_config_word(dev, PCI_COMMAND, pci_command);
> }
>
> pcibios_disable_device(dev);
> }.
> And dev->is_busmaster is set to 0 in pci_disable_device.
>
> Signed-off-by: Cai Huoqing <cai.huoqing@linux.dev>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 5/5] wifi: rtw89: Remove redundant pci_clear_master
2023-03-23 11:26 ` [PATCH 5/5] wifi: rtw89: " Cai Huoqing
@ 2023-03-26 9:31 ` Simon Horman
2023-04-03 13:38 ` Kalle Valo
1 sibling, 0 replies; 13+ messages in thread
From: Simon Horman @ 2023-03-26 9:31 UTC (permalink / raw)
To: Cai Huoqing
Cc: Kalle Valo, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Yan-Hsuan Chuang, Ping-Ke Shih, ath10k,
linux-wireless, netdev, linux-kernel, ath11k, ath12k
On Thu, Mar 23, 2023 at 07:26:13PM +0800, Cai Huoqing wrote:
> Remove pci_clear_master to simplify the code,
> the bus-mastering is also cleared in do_pci_disable_device,
> like this:
> ./drivers/pci/pci.c:2197
> static void do_pci_disable_device(struct pci_dev *dev)
> {
> u16 pci_command;
>
> pci_read_config_word(dev, PCI_COMMAND, &pci_command);
> if (pci_command & PCI_COMMAND_MASTER) {
> pci_command &= ~PCI_COMMAND_MASTER;
> pci_write_config_word(dev, PCI_COMMAND, pci_command);
> }
>
> pcibios_disable_device(dev);
> }.
> And dev->is_busmaster is set to 0 in pci_disable_device.
>
> Signed-off-by: Cai Huoqing <cai.huoqing@linux.dev>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 4/5] wifi: rtw88: Remove redundant pci_clear_master
2023-03-23 11:26 ` [PATCH 4/5] wifi: rtw88: " Cai Huoqing
2023-03-26 9:31 ` Simon Horman
@ 2023-03-31 14:49 ` Kalle Valo
1 sibling, 0 replies; 13+ messages in thread
From: Kalle Valo @ 2023-03-31 14:49 UTC (permalink / raw)
To: Cai Huoqing
Cc: cai.huoqing, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Yan-Hsuan Chuang, Ping-Ke Shih, ath10k,
linux-wireless, netdev, linux-kernel, ath11k, ath12k
Cai Huoqing <cai.huoqing@linux.dev> wrote:
> Remove pci_clear_master to simplify the code,
> the bus-mastering is also cleared in do_pci_disable_device,
> like this:
> ./drivers/pci/pci.c:2197
> static void do_pci_disable_device(struct pci_dev *dev)
> {
> u16 pci_command;
>
> pci_read_config_word(dev, PCI_COMMAND, &pci_command);
> if (pci_command & PCI_COMMAND_MASTER) {
> pci_command &= ~PCI_COMMAND_MASTER;
> pci_write_config_word(dev, PCI_COMMAND, pci_command);
> }
>
> pcibios_disable_device(dev);
> }.
> And dev->is_busmaster is set to 0 in pci_disable_device.
>
> Signed-off-by: Cai Huoqing <cai.huoqing@linux.dev>
> Reviewed-by: Simon Horman <simon.horman@corigine.com>
> Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>
Patch applied to wireless-next.git, thanks.
e665c6d67e54 wifi: rtw88: Remove redundant pci_clear_master
--
https://patchwork.kernel.org/project/linux-wireless/patch/20230323112613.7550-4-cai.huoqing@linux.dev/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 5/5] wifi: rtw89: Remove redundant pci_clear_master
2023-03-23 11:26 ` [PATCH 5/5] wifi: rtw89: " Cai Huoqing
2023-03-26 9:31 ` Simon Horman
@ 2023-04-03 13:38 ` Kalle Valo
1 sibling, 0 replies; 13+ messages in thread
From: Kalle Valo @ 2023-04-03 13:38 UTC (permalink / raw)
To: Cai Huoqing
Cc: cai.huoqing, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Yan-Hsuan Chuang, Ping-Ke Shih, ath10k,
linux-wireless, netdev, linux-kernel, ath11k, ath12k
Cai Huoqing <cai.huoqing@linux.dev> wrote:
> Remove pci_clear_master to simplify the code,
> the bus-mastering is also cleared in do_pci_disable_device,
> like this:
> ./drivers/pci/pci.c:2197
> static void do_pci_disable_device(struct pci_dev *dev)
> {
> u16 pci_command;
>
> pci_read_config_word(dev, PCI_COMMAND, &pci_command);
> if (pci_command & PCI_COMMAND_MASTER) {
> pci_command &= ~PCI_COMMAND_MASTER;
> pci_write_config_word(dev, PCI_COMMAND, pci_command);
> }
>
> pcibios_disable_device(dev);
> }.
> And dev->is_busmaster is set to 0 in pci_disable_device.
>
> Signed-off-by: Cai Huoqing <cai.huoqing@linux.dev>
> Reviewed-by: Simon Horman <simon.horman@corigine.com>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Patch applied to wireless-next.git, thanks.
5995f7463101 wifi: rtw89: Remove redundant pci_clear_master
--
https://patchwork.kernel.org/project/linux-wireless/patch/20230323112613.7550-5-cai.huoqing@linux.dev/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/5] wifi: ath11k: Remove redundant pci_clear_master
2023-03-23 11:26 [PATCH 1/5] wifi: ath11k: Remove redundant pci_clear_master Cai Huoqing
` (4 preceding siblings ...)
2023-03-26 9:30 ` [PATCH 1/5] wifi: ath11k: " Simon Horman
@ 2023-04-12 10:03 ` Kalle Valo
5 siblings, 0 replies; 13+ messages in thread
From: Kalle Valo @ 2023-04-12 10:03 UTC (permalink / raw)
To: Cai Huoqing
Cc: cai.huoqing, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Yan-Hsuan Chuang, Ping-Ke Shih, ath10k,
linux-wireless, netdev, linux-kernel, ath11k, ath12k
Cai Huoqing <cai.huoqing@linux.dev> wrote:
> Remove pci_clear_master to simplify the code,
> the bus-mastering is also cleared in do_pci_disable_device,
> like this:
> ./drivers/pci/pci.c:2197
> static void do_pci_disable_device(struct pci_dev *dev)
> {
> u16 pci_command;
>
> pci_read_config_word(dev, PCI_COMMAND, &pci_command);
> if (pci_command & PCI_COMMAND_MASTER) {
> pci_command &= ~PCI_COMMAND_MASTER;
> pci_write_config_word(dev, PCI_COMMAND, pci_command);
> }
>
> pcibios_disable_device(dev);
> }.
> And dev->is_busmaster is set to 0 in pci_disable_device.
>
> Signed-off-by: Cai Huoqing <cai.huoqing@linux.dev>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
3 patches applied to ath-next branch of ath.git, thanks.
f812e2a9f85d wifi: ath11k: Remove redundant pci_clear_master
76008fc13b09 wifi: ath10k: Remove redundant pci_clear_master
b9235aef8492 wifi: ath12k: Remove redundant pci_clear_master
--
https://patchwork.kernel.org/project/linux-wireless/patch/20230323112613.7550-1-cai.huoqing@linux.dev/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2023-04-12 10:03 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-23 11:26 [PATCH 1/5] wifi: ath11k: Remove redundant pci_clear_master Cai Huoqing
2023-03-23 11:26 ` [PATCH 2/5] wifi: ath10k: " Cai Huoqing
2023-03-26 9:30 ` Simon Horman
2023-03-23 11:26 ` [PATCH 3/5] wifi: ath12k: " Cai Huoqing
2023-03-26 9:31 ` Simon Horman
2023-03-23 11:26 ` [PATCH 4/5] wifi: rtw88: " Cai Huoqing
2023-03-26 9:31 ` Simon Horman
2023-03-31 14:49 ` Kalle Valo
2023-03-23 11:26 ` [PATCH 5/5] wifi: rtw89: " Cai Huoqing
2023-03-26 9:31 ` Simon Horman
2023-04-03 13:38 ` Kalle Valo
2023-03-26 9:30 ` [PATCH 1/5] wifi: ath11k: " Simon Horman
2023-04-12 10:03 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).