* [PATCH] wifi: ath10k: Remove unused struct ath10k_htc_frame
@ 2023-11-03 22:05 Jeff Johnson
2023-11-22 18:23 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Johnson @ 2023-11-03 22:05 UTC (permalink / raw)
To: Kalle Valo; +Cc: ath10k, linux-wireless, linux-kernel, Jeff Johnson
struct ath10k_htc_frame is unused, and since it illogically contains
two consecutive flexible arrays, it could never be used, so remove it.
No functional changes, compile tested only.
Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
drivers/net/wireless/ath/ath10k/htc.h | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/htc.h b/drivers/net/wireless/ath/ath10k/htc.h
index 0d180faf3b77..0eaa21ad86ac 100644
--- a/drivers/net/wireless/ath/ath10k/htc.h
+++ b/drivers/net/wireless/ath/ath10k/htc.h
@@ -253,19 +253,6 @@ struct ath10k_htc_record {
};
} __packed __aligned(4);
-/*
- * note: the trailer offset is dynamic depending
- * on payload length. this is only a struct layout draft
- */
-struct ath10k_htc_frame {
- struct ath10k_htc_hdr hdr;
- union {
- struct ath10k_htc_msg msg;
- u8 payload[0];
- };
- struct ath10k_htc_record trailer[0];
-} __packed __aligned(4);
-
/*******************/
/* Host-side stuff */
/*******************/
---
base-commit: ac2f43d3d34e52b0d388b4c573ff6bbac90235b9
change-id: 20231025-ath10k_htc_frame-16d8e43f796d
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] wifi: ath10k: Remove unused struct ath10k_htc_frame
2023-11-03 22:05 [PATCH] wifi: ath10k: Remove unused struct ath10k_htc_frame Jeff Johnson
@ 2023-11-22 18:23 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2023-11-22 18:23 UTC (permalink / raw)
To: Jeff Johnson; +Cc: ath10k, linux-wireless, linux-kernel, Jeff Johnson
Jeff Johnson <quic_jjohnson@quicinc.com> wrote:
> struct ath10k_htc_frame is unused, and since it illogically contains
> two consecutive flexible arrays, it could never be used, so remove it.
>
> No functional changes, compile tested only.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Patch applied to ath-next branch of ath.git, thanks.
2bc76fef1a9a wifi: ath10k: Remove unused struct ath10k_htc_frame
--
https://patchwork.kernel.org/project/linux-wireless/patch/20231103-ath10k_htc_frame-v1-1-ff00b38a9630@quicinc.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-22 18:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-03 22:05 [PATCH] wifi: ath10k: Remove unused struct ath10k_htc_frame Jeff Johnson
2023-11-22 18:23 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).