* ath10k-firmware: QCA9980 hw2.0: add ASRock G10 specific BDFs
@ 2020-04-10 13:01 Christian Lamparter
2022-01-21 14:05 ` Kalle Valo
2022-01-21 14:58 ` Kalle Valo
0 siblings, 2 replies; 5+ messages in thread
From: Christian Lamparter @ 2020-04-10 13:01 UTC (permalink / raw)
To: ath10k
[-- Attachment #1: Type: text/plain, Size: 1060 bytes --]
Hi,
this is a set of board.bin files for the ASRock G10,
which I wish to be added to the ath10k-firmware repository.
As per the current "Submitting board files" guidelines [1]:
* description for what hardware this is:
- it is a IPQ8064 based board with
- one QCA9980 radio is used as 2.4 GHz radio
- one QCA9980 radio is used as 5 GHz radio
* origin of the board file (did you create it yourself or where you downloaded
all files were extracted from official vendor firmware which was on the device.
* ids to be used with the board file (ATH10K_BD_IE_BOARD_NAME in ath10k)
- qca9980 hw2.0
+ bus=pci,bmi-chip-id=1,bmi-board-id=1,variant=ASRock-G10
+ bus=pci,bmi-chip-id=1,bmi-board-id=2,variant=ASRock-G10
* md5sum of each new board file to add
ae069744baeebfd6861e8080a92439ca bus=pci,bmi-chip-id=1,bmi-board-id=1,variant=ASRock-G10
9e196846841a186e61ea208cc873384c bus=pci,bmi-chip-id=1,bmi-board-id=2,variant=ASRock-G10
Best wishes
Christian Lamparter
[1] <https://wireless.wiki.kernel.org/en/users/drivers/ath10k/boardfiles>
[-- Attachment #2: bus=pci,bmi-chip-id=1,bmi-board-id=2,variant=ASRock-G10.bin --]
[-- Type: application/octet-stream, Size: 12064 bytes --]
[-- Attachment #3: bus=pci,bmi-chip-id=1,bmi-board-id=1,variant=ASRock-G10.bin --]
[-- Type: application/octet-stream, Size: 12064 bytes --]
[-- Attachment #4: Type: text/plain, Size: 146 bytes --]
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: ath10k-firmware: QCA9980 hw2.0: add ASRock G10 specific BDFs
2020-04-10 13:01 ath10k-firmware: QCA9980 hw2.0: add ASRock G10 specific BDFs Christian Lamparter
@ 2022-01-21 14:05 ` Kalle Valo
2022-01-21 14:33 ` Christian Lamparter
2022-01-21 14:58 ` Kalle Valo
1 sibling, 1 reply; 5+ messages in thread
From: Kalle Valo @ 2022-01-21 14:05 UTC (permalink / raw)
To: Christian Lamparter; +Cc: ath10k
Christian Lamparter <chunkeey@gmail.com> writes:
> this is a set of board.bin files for the ASRock G10,
> which I wish to be added to the ath10k-firmware repository.
>
> As per the current "Submitting board files" guidelines [1]:
>
> * description for what hardware this is:
> - it is a IPQ8064 based board with
> - one QCA9980 radio is used as 2.4 GHz radio
> - one QCA9980 radio is used as 5 GHz radio
>
> * origin of the board file (did you create it yourself or where you downloaded
> all files were extracted from official vendor firmware which was on the device.
>
> * ids to be used with the board file (ATH10K_BD_IE_BOARD_NAME in ath10k)
> - qca9980 hw2.0
> + bus=pci,bmi-chip-id=1,bmi-board-id=1,variant=ASRock-G10
> + bus=pci,bmi-chip-id=1,bmi-board-id=2,variant=ASRock-G10
> * md5sum of each new board file to add
>
> ae069744baeebfd6861e8080a92439ca bus=pci,bmi-chip-id=1,bmi-board-id=1,variant=ASRock-G10
> 9e196846841a186e61ea208cc873384c bus=pci,bmi-chip-id=1,bmi-board-id=2,variant=ASRock-G10
There is no QCA9880 directory in ath10k-firmware, do you mean this
should be added to QCA988X/hw2.0/board-2.bin?
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: ath10k-firmware: QCA9980 hw2.0: add ASRock G10 specific BDFs
2022-01-21 14:05 ` Kalle Valo
@ 2022-01-21 14:33 ` Christian Lamparter
2022-01-21 14:53 ` Kalle Valo
0 siblings, 1 reply; 5+ messages in thread
From: Christian Lamparter @ 2022-01-21 14:33 UTC (permalink / raw)
To: Kalle Valo; +Cc: ath10k
Hi Kalle,
On 21/01/2022 15:05, Kalle Valo wrote:
> Christian Lamparter <chunkeey@gmail.com> writes:
>
>> this is a set of board.bin files for the ASRock G10,
>> which I wish to be added to the ath10k-firmware repository.
>>
>> As per the current "Submitting board files" guidelines [1]:
>>
>> * description for what hardware this is:
>> - it is a IPQ8064 based board with
>> - one QCA9980 radio is used as 2.4 GHz radio
>> - one QCA9980 radio is used as 5 GHz radio
>>
>> * origin of the board file (did you create it yourself or where you downloaded
>> all files were extracted from official vendor firmware which was on the device.
>>
>> * ids to be used with the board file (ATH10K_BD_IE_BOARD_NAME in ath10k)
>> - qca9980 hw2.0
>> + bus=pci,bmi-chip-id=1,bmi-board-id=1,variant=ASRock-G10
>> + bus=pci,bmi-chip-id=1,bmi-board-id=2,variant=ASRock-G10
>> * md5sum of each new board file to add
>>
>> ae069744baeebfd6861e8080a92439ca bus=pci,bmi-chip-id=1,bmi-board-id=1,variant=ASRock-G10
>> 9e196846841a186e61ea208cc873384c bus=pci,bmi-chip-id=1,bmi-board-id=2,variant=ASRock-G10
>
> There is no QCA9880 directory in ath10k-firmware, do you mean this
> should be added to QCA988X/hw2.0/board-2.bin?
It's a 9980 chip. This was 9984 predecessor.
^ = Watch out for that 9! <https://www.qualcomm.com/products/qca9980>
It would belong to the 99X0 directory of your ath10k-firmware repo:
https://github.com/kvalo/ath10k-firmware/tree/master/QCA99X0/hw2.0
But there's one issue: there is no v2 board-2.bin in there yet.
However the codeaurora's ath10k-firmware repo provides the board-2.bin here:
https://source.codeaurora.org/quic/qsdk/oss/firmware/ath10k-firmware/plain/ath10k/QCA99X0/hw2.0/board-2.bin
(this also includes the reference bmi-board-id for 2, 4 and 6. I guess this
would help other people as well):
https://source.codeaurora.org/quic/qsdk/oss/firmware/ath10k-firmware/plain/ath10k/QCA99X0/hw2.0
So could you please add that board-2.bin from codeaurora and add
the ASRock G10 specific variant to it? That would be sweet.
Thank you,
Christian
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: ath10k-firmware: QCA9980 hw2.0: add ASRock G10 specific BDFs
2022-01-21 14:33 ` Christian Lamparter
@ 2022-01-21 14:53 ` Kalle Valo
0 siblings, 0 replies; 5+ messages in thread
From: Kalle Valo @ 2022-01-21 14:53 UTC (permalink / raw)
To: Christian Lamparter; +Cc: ath10k
Christian Lamparter <chunkeey@gmail.com> writes:
> Hi Kalle,
>
> On 21/01/2022 15:05, Kalle Valo wrote:
>> Christian Lamparter <chunkeey@gmail.com> writes:
>>
>>> this is a set of board.bin files for the ASRock G10,
>>> which I wish to be added to the ath10k-firmware repository.
>>>
>>> As per the current "Submitting board files" guidelines [1]:
>>>
>>> * description for what hardware this is:
>>> - it is a IPQ8064 based board with
>>> - one QCA9980 radio is used as 2.4 GHz radio
>>> - one QCA9980 radio is used as 5 GHz radio
>>>
>>> * origin of the board file (did you create it yourself or where you downloaded
>>> all files were extracted from official vendor firmware which was on the device.
>>>
>>> * ids to be used with the board file (ATH10K_BD_IE_BOARD_NAME in ath10k)
>>> - qca9980 hw2.0
>>> + bus=pci,bmi-chip-id=1,bmi-board-id=1,variant=ASRock-G10
>>> + bus=pci,bmi-chip-id=1,bmi-board-id=2,variant=ASRock-G10
>>> * md5sum of each new board file to add
>>>
>>> ae069744baeebfd6861e8080a92439ca bus=pci,bmi-chip-id=1,bmi-board-id=1,variant=ASRock-G10
>>> 9e196846841a186e61ea208cc873384c bus=pci,bmi-chip-id=1,bmi-board-id=2,variant=ASRock-G10
>>
>> There is no QCA9880 directory in ath10k-firmware, do you mean this
>> should be added to QCA988X/hw2.0/board-2.bin?
>
> It's a 9980 chip. This was 9984 predecessor.
> ^ = Watch out for that 9! <https://www.qualcomm.com/products/qca9980>
Good that you pointed out that 9, I missed it.
> It would belong to the 99X0 directory of your ath10k-firmware repo:
> https://github.com/kvalo/ath10k-firmware/tree/master/QCA99X0/hw2.0
Ok, then I would prefer that the subject starts with:
ath10k-firmware: QCA99X0 hw2.0: ...
Ie. I can directly derive the directory name from the subject. But no
need to resend anything, this is just for the future.
> But there's one issue: there is no v2 board-2.bin in there yet.
>
> However the codeaurora's ath10k-firmware repo provides the board-2.bin here:
> https://source.codeaurora.org/quic/qsdk/oss/firmware/ath10k-firmware/plain/ath10k/QCA99X0/hw2.0/board-2.bin
>
> (this also includes the reference bmi-board-id for 2, 4 and 6. I guess this
> would help other people as well):
> https://source.codeaurora.org/quic/qsdk/oss/firmware/ath10k-firmware/plain/ath10k/QCA99X0/hw2.0
>
> So could you please add that board-2.bin from codeaurora
Done:
https://github.com/kvalo/ath10k-firmware/commit/2d8566686428430ebedfaea47e3782ac25901408
> and add the ASRock G10 specific variant to it? That would be sweet.
I'll do that next. Thanks for the thorough instructions, I appreciate it
a lot.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: ath10k-firmware: QCA9980 hw2.0: add ASRock G10 specific BDFs
2020-04-10 13:01 ath10k-firmware: QCA9980 hw2.0: add ASRock G10 specific BDFs Christian Lamparter
2022-01-21 14:05 ` Kalle Valo
@ 2022-01-21 14:58 ` Kalle Valo
1 sibling, 0 replies; 5+ messages in thread
From: Kalle Valo @ 2022-01-21 14:58 UTC (permalink / raw)
To: Christian Lamparter; +Cc: ath10k
Christian Lamparter <chunkeey@gmail.com> writes:
> Hi,
>
> this is a set of board.bin files for the ASRock G10,
> which I wish to be added to the ath10k-firmware repository.
>
> As per the current "Submitting board files" guidelines [1]:
>
> * description for what hardware this is:
> - it is a IPQ8064 based board with
> - one QCA9980 radio is used as 2.4 GHz radio
> - one QCA9980 radio is used as 5 GHz radio
>
> * origin of the board file (did you create it yourself or where you downloaded
> all files were extracted from official vendor firmware which was on the device.
>
> * ids to be used with the board file (ATH10K_BD_IE_BOARD_NAME in ath10k)
> - qca9980 hw2.0
> + bus=pci,bmi-chip-id=1,bmi-board-id=1,variant=ASRock-G10
> + bus=pci,bmi-chip-id=1,bmi-board-id=2,variant=ASRock-G10
> * md5sum of each new board file to add
>
> ae069744baeebfd6861e8080a92439ca bus=pci,bmi-chip-id=1,bmi-board-id=1,variant=ASRock-G10
> 9e196846841a186e61ea208cc873384c bus=pci,bmi-chip-id=1,bmi-board-id=2,variant=ASRock-G10
Thanks, added to QCA99X0/hw2.0/board-2.bin:
New:
bus=pci,bmi-chip-id=1,bmi-board-id=1,variant=ASRock-G10
bus=pci,bmi-chip-id=1,bmi-board-id=2,variant=ASRock-G10
Changed:
Deleted:
2 board image(s) added, 0 changed, 0 deleted, 13 in total
https://github.com/kvalo/ath10k-firmware/commit/e404444dfc0baf7d0fcde21ab8ec333608c9960c
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-01-21 14:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-10 13:01 ath10k-firmware: QCA9980 hw2.0: add ASRock G10 specific BDFs Christian Lamparter
2022-01-21 14:05 ` Kalle Valo
2022-01-21 14:33 ` Christian Lamparter
2022-01-21 14:53 ` Kalle Valo
2022-01-21 14:58 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).