* [PATCH 00/15] gcc-10 warning fixes
@ 2020-04-30 21:30 Arnd Bergmann
2020-04-30 21:30 ` [PATCH 04/15] ath10k: fix gcc-10 zero-length-bounds warnings Arnd Bergmann
0 siblings, 1 reply; 7+ messages in thread
From: Arnd Bergmann @ 2020-04-30 21:30 UTC (permalink / raw)
To: linux-kernel
Cc: linux-wireless, Bob Copeland, Alexei Starovoitov,
Amitkumar Karwar, netfilter-devel, netdev, Mikulas Patocka,
linux-scsi, Christoph Hellwig, Herbert Xu, Daniel Borkmann,
James Smart, ath10k, coreteam, Jakub Kicinski, Pablo Neira Ayuso,
linux-media, Johannes Berg, Intel Linux Wireless,
James E.J. Bottomley, Jens Axboe, linux-nvme,
Mauro Carvalho Chehab, Kalle Valo, Neil Horman,
Martin K. Petersen, Greg Kroah-Hartman, linux-usb,
Florian Westphal, linux-karma-devel, Arnd Bergmann, linux-crypto,
Jan Kara, bpf, David S. Miller
Here are a couple of fixes for warnings introduced with gcc-10.
If you wish to reproduce these, you can find the compiler I used
at [1].
If you like the fixes, please apply them directly into maintainer
trees. I expect that we will also need them to be backported
into stable kernels later.
I disabled -Wrestrict on gcc in my local test tree, but with
the patches from this series and the ones I have already sent,
I see no gcc-10 specific warnings in linux-next when doing
many randconfig builds for arm/arm64/x86.
Arnd
Arnd Bergmann (15):
crypto - Avoid free() namespace collision
iwlwifi: mvm: fix gcc-10 zero-length-bounds warning
mwifiex: avoid -Wstringop-overflow warning
ath10k: fix gcc-10 zero-length-bounds warnings
bpf: avoid gcc-10 stringop-overflow warning
netfilter: conntrack: avoid gcc-10 zero-length-bounds warning
drop_monitor: work around gcc-10 stringop-overflow warning
usb: ehci: avoid gcc-10 zero-length-bounds warning
udf: avoid gcc-10 zero-length-bounds warnings
hpfs: avoid gcc-10 zero-length-bounds warning
omfs: avoid gcc-10 stringop-overflow warning
media: s5k5baf: avoid gcc-10 zero-length-bounds warning
scsi: sas: avoid gcc-10 zero-length-bounds warning
isci: avoid gcc-10 zero-length-bounds warning
nvme: avoid gcc-10 zero-length-bounds warning
crypto/lrw.c | 6 +--
crypto/xts.c | 6 +--
drivers/media/i2c/s5k5baf.c | 4 +-
drivers/net/wireless/ath/ath10k/htt.h | 4 +-
.../net/wireless/intel/iwlwifi/fw/api/tx.h | 14 +++----
.../net/wireless/marvell/mwifiex/sta_cmd.c | 39 ++++++++-----------
drivers/nvme/host/fc.c | 2 +-
drivers/scsi/aic94xx/aic94xx_tmf.c | 4 +-
drivers/scsi/isci/task.h | 7 ++--
drivers/scsi/libsas/sas_task.c | 3 +-
fs/hpfs/anode.c | 7 +++-
fs/omfs/file.c | 12 +++---
fs/omfs/omfs_fs.h | 2 +-
fs/udf/ecma_167.h | 2 +-
fs/udf/super.c | 2 +-
include/linux/filter.h | 6 +--
include/linux/usb/ehci_def.h | 12 ++++--
include/net/netfilter/nf_conntrack.h | 2 +-
net/core/drop_monitor.c | 11 ++++--
net/netfilter/nf_conntrack_core.c | 4 +-
20 files changed, 76 insertions(+), 73 deletions(-)
[1] https://mirrors.edge.kernel.org/pub/tools/crosstool/files/bin/x86_64/10.0.20200413/
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: Johannes Berg <johannes.berg@intel.com>
Cc: Intel Linux Wireless <linuxwifi@intel.com>
Cc: Amitkumar Karwar <amitkarwar@gmail.com>
Cc: James Smart <james.smart@broadcom.com>
Cc: Jens Axboe <axboe@fb.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz>
Cc: Bob Copeland <me@bobcopeland.com>
Cc: Jan Kara <jack@suse.com>
Cc: Alexei Starovoitov <ast@kernel.org>
Cc: Daniel Borkmann <daniel@iogearbox.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Neil Horman <nhorman@tuxdriver.com>
Cc: linux-crypto@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-media@vger.kernel.org
Cc: ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Cc: linux-nvme@lists.infradead.org
Cc: linux-scsi@vger.kernel.org
Cc: linux-karma-devel@lists.sourceforge.net
Cc: bpf@vger.kernel.org
Cc: linux-usb@vger.kernel.org
Cc: netfilter-devel@vger.kernel.org
Cc: coreteam@netfilter.org
--
2.26.0
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 04/15] ath10k: fix gcc-10 zero-length-bounds warnings
2020-04-30 21:30 [PATCH 00/15] gcc-10 warning fixes Arnd Bergmann
@ 2020-04-30 21:30 ` Arnd Bergmann
2020-04-30 21:45 ` Gustavo A. R. Silva
0 siblings, 1 reply; 7+ messages in thread
From: Arnd Bergmann @ 2020-04-30 21:30 UTC (permalink / raw)
To: linux-kernel, Kalle Valo, David S. Miller, Gustavo A. R. Silva,
Michal Kazior
Cc: Maharaja Kennadyrajan, Arnd Bergmann, Erik Stromdahl, netdev,
linux-wireless, ath10k, Kalle Valo, Wen Gong
gcc-10 started warning about out-of-bounds access for zero-length
arrays:
In file included from drivers/net/wireless/ath/ath10k/core.h:18,
from drivers/net/wireless/ath/ath10k/htt_rx.c:8:
drivers/net/wireless/ath/ath10k/htt_rx.c: In function 'ath10k_htt_rx_tx_fetch_ind':
drivers/net/wireless/ath/ath10k/htt.h:1683:17: warning: array subscript 65535 is outside the bounds of an interior zero-length array 'struct htt_tx_fetch_record[0]' [-Wzero-length-bounds]
1683 | return (void *)&ind->records[le16_to_cpu(ind->num_records)];
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/ath/ath10k/htt.h:1676:29: note: while referencing 'records'
1676 | struct htt_tx_fetch_record records[0];
| ^~~~~~~
The structure was already converted to have a flexible-array member in
the past, but there are two zero-length members in the end and only
one of them can be a flexible-array member.
Swap the two around to avoid the warning, as 'resp_ids' is not accessed
in a way that causes a warning.
Fixes: 3ba225b506a2 ("treewide: Replace zero-length array with flexible-array member")
Fixes: 22e6b3bc5d96 ("ath10k: add new htt definitions")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/net/wireless/ath/ath10k/htt.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/htt.h b/drivers/net/wireless/ath/ath10k/htt.h
index e7096a73c6ca..7621f0a3dc77 100644
--- a/drivers/net/wireless/ath/ath10k/htt.h
+++ b/drivers/net/wireless/ath/ath10k/htt.h
@@ -1673,8 +1673,8 @@ struct htt_tx_fetch_ind {
__le32 token;
__le16 num_resp_ids;
__le16 num_records;
- struct htt_tx_fetch_record records[0];
- __le32 resp_ids[]; /* ath10k_htt_get_tx_fetch_ind_resp_ids() */
+ __le32 resp_ids[0]; /* ath10k_htt_get_tx_fetch_ind_resp_ids() */
+ struct htt_tx_fetch_record records[];
} __packed;
static inline void *
--
2.26.0
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 04/15] ath10k: fix gcc-10 zero-length-bounds warnings
2020-04-30 21:45 ` Gustavo A. R. Silva
@ 2020-04-30 21:44 ` Arnd Bergmann
2020-05-04 11:54 ` Kalle Valo
1 sibling, 0 replies; 7+ messages in thread
From: Arnd Bergmann @ 2020-04-30 21:44 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Maharaja Kennadyrajan, Kees Cook, Erik Stromdahl, Networking,
linux-wireless, linux-kernel, ath10k, Kalle Valo, Michal Kazior,
Wen Gong, David S. Miller, Kalle Valo
On Thu, Apr 30, 2020 at 11:41 PM Gustavo A. R. Silva
<gustavo@embeddedor.com> wrote:
> On 4/30/20 16:30, Arnd Bergmann wrote:
> > gcc-10 started warning about out-of-bounds access for zero-length
> > arrays:
> The treewide patch is an experimental change and, as this change only applies
> to my -next tree, I will carry this patch in it, so other people don't have
> to worry about this at all.
Ok, thanks!
Arnd
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 04/15] ath10k: fix gcc-10 zero-length-bounds warnings
2020-04-30 21:30 ` [PATCH 04/15] ath10k: fix gcc-10 zero-length-bounds warnings Arnd Bergmann
@ 2020-04-30 21:45 ` Gustavo A. R. Silva
2020-04-30 21:44 ` Arnd Bergmann
2020-05-04 11:54 ` Kalle Valo
0 siblings, 2 replies; 7+ messages in thread
From: Gustavo A. R. Silva @ 2020-04-30 21:45 UTC (permalink / raw)
To: Arnd Bergmann, linux-kernel, Kalle Valo, David S. Miller, Michal Kazior
Cc: Maharaja Kennadyrajan, Kees Cook, Erik Stromdahl, netdev,
linux-wireless, ath10k, Kalle Valo, Wen Gong
Hi Arnd,
On 4/30/20 16:30, Arnd Bergmann wrote:
> gcc-10 started warning about out-of-bounds access for zero-length
> arrays:
>
> In file included from drivers/net/wireless/ath/ath10k/core.h:18,
> from drivers/net/wireless/ath/ath10k/htt_rx.c:8:
> drivers/net/wireless/ath/ath10k/htt_rx.c: In function 'ath10k_htt_rx_tx_fetch_ind':
> drivers/net/wireless/ath/ath10k/htt.h:1683:17: warning: array subscript 65535 is outside the bounds of an interior zero-length array 'struct htt_tx_fetch_record[0]' [-Wzero-length-bounds]
> 1683 | return (void *)&ind->records[le16_to_cpu(ind->num_records)];
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/net/wireless/ath/ath10k/htt.h:1676:29: note: while referencing 'records'
> 1676 | struct htt_tx_fetch_record records[0];
> | ^~~~~~~
>
> The structure was already converted to have a flexible-array member in
> the past, but there are two zero-length members in the end and only
> one of them can be a flexible-array member.
>
> Swap the two around to avoid the warning, as 'resp_ids' is not accessed
> in a way that causes a warning.
>
> Fixes: 3ba225b506a2 ("treewide: Replace zero-length array with flexible-array member")
> Fixes: 22e6b3bc5d96 ("ath10k: add new htt definitions")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/net/wireless/ath/ath10k/htt.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/htt.h b/drivers/net/wireless/ath/ath10k/htt.h
> index e7096a73c6ca..7621f0a3dc77 100644
> --- a/drivers/net/wireless/ath/ath10k/htt.h
> +++ b/drivers/net/wireless/ath/ath10k/htt.h
> @@ -1673,8 +1673,8 @@ struct htt_tx_fetch_ind {
> __le32 token;
> __le16 num_resp_ids;
> __le16 num_records;
> - struct htt_tx_fetch_record records[0];
> - __le32 resp_ids[]; /* ath10k_htt_get_tx_fetch_ind_resp_ids() */
> + __le32 resp_ids[0]; /* ath10k_htt_get_tx_fetch_ind_resp_ids() */
> + struct htt_tx_fetch_record records[];
> } __packed;
>
> static inline void *
>
The treewide patch is an experimental change and, as this change only applies
to my -next tree, I will carry this patch in it, so other people don't have
to worry about this at all.
Thank you
--
Gustavo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 04/15] ath10k: fix gcc-10 zero-length-bounds warnings
2020-04-30 21:45 ` Gustavo A. R. Silva
2020-04-30 21:44 ` Arnd Bergmann
@ 2020-05-04 11:54 ` Kalle Valo
2020-05-04 16:09 ` Gustavo A. R. Silva
1 sibling, 1 reply; 7+ messages in thread
From: Kalle Valo @ 2020-05-04 11:54 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Maharaja Kennadyrajan, Kees Cook, Arnd Bergmann, Erik Stromdahl,
netdev, linux-wireless, linux-kernel, ath10k, Michal Kazior,
Wen Gong, David S. Miller
"Gustavo A. R. Silva" <gustavo@embeddedor.com> writes:
> Hi Arnd,
>
> On 4/30/20 16:30, Arnd Bergmann wrote:
>> gcc-10 started warning about out-of-bounds access for zero-length
>> arrays:
>>
>> In file included from drivers/net/wireless/ath/ath10k/core.h:18,
>> from drivers/net/wireless/ath/ath10k/htt_rx.c:8:
>> drivers/net/wireless/ath/ath10k/htt_rx.c: In function 'ath10k_htt_rx_tx_fetch_ind':
>> drivers/net/wireless/ath/ath10k/htt.h:1683:17: warning: array subscript 65535 is outside the bounds of an interior zero-length array 'struct htt_tx_fetch_record[0]' [-Wzero-length-bounds]
>> 1683 | return (void *)&ind->records[le16_to_cpu(ind->num_records)];
>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/wireless/ath/ath10k/htt.h:1676:29: note: while referencing 'records'
>> 1676 | struct htt_tx_fetch_record records[0];
>> | ^~~~~~~
>>
>> The structure was already converted to have a flexible-array member in
>> the past, but there are two zero-length members in the end and only
>> one of them can be a flexible-array member.
>>
>> Swap the two around to avoid the warning, as 'resp_ids' is not accessed
>> in a way that causes a warning.
>>
>> Fixes: 3ba225b506a2 ("treewide: Replace zero-length array with flexible-array member")
>> Fixes: 22e6b3bc5d96 ("ath10k: add new htt definitions")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> ---
>> drivers/net/wireless/ath/ath10k/htt.h | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath10k/htt.h b/drivers/net/wireless/ath/ath10k/htt.h
>> index e7096a73c6ca..7621f0a3dc77 100644
>> --- a/drivers/net/wireless/ath/ath10k/htt.h
>> +++ b/drivers/net/wireless/ath/ath10k/htt.h
>> @@ -1673,8 +1673,8 @@ struct htt_tx_fetch_ind {
>> __le32 token;
>> __le16 num_resp_ids;
>> __le16 num_records;
>> - struct htt_tx_fetch_record records[0];
>> - __le32 resp_ids[]; /* ath10k_htt_get_tx_fetch_ind_resp_ids() */
>> + __le32 resp_ids[0]; /* ath10k_htt_get_tx_fetch_ind_resp_ids() */
>> + struct htt_tx_fetch_record records[];
>> } __packed;
>>
>> static inline void *
>>
>
> The treewide patch is an experimental change and, as this change only applies
> to my -next tree, I will carry this patch in it, so other people don't have
> to worry about this at all.
Gustavo, why do you have ath10k patches in your tree? I prefer that
ath10k patches go through my ath.git tree so that they are reviewed and
tested.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 04/15] ath10k: fix gcc-10 zero-length-bounds warnings
2020-05-04 11:54 ` Kalle Valo
@ 2020-05-04 16:09 ` Gustavo A. R. Silva
2020-05-05 4:56 ` Kalle Valo
0 siblings, 1 reply; 7+ messages in thread
From: Gustavo A. R. Silva @ 2020-05-04 16:09 UTC (permalink / raw)
To: Kalle Valo
Cc: Maharaja Kennadyrajan, Kees Cook, Arnd Bergmann, Erik Stromdahl,
netdev, linux-wireless, linux-kernel, ath10k, Michal Kazior,
Wen Gong, David S. Miller
On 5/4/20 06:54, Kalle Valo wrote:
> "Gustavo A. R. Silva" <gustavo@embeddedor.com> writes:
>
>> Hi Arnd,
>>
>> On 4/30/20 16:30, Arnd Bergmann wrote:
>>> gcc-10 started warning about out-of-bounds access for zero-length
>>> arrays:
>>>
>>> In file included from drivers/net/wireless/ath/ath10k/core.h:18,
>>> from drivers/net/wireless/ath/ath10k/htt_rx.c:8:
>>> drivers/net/wireless/ath/ath10k/htt_rx.c: In function 'ath10k_htt_rx_tx_fetch_ind':
>>> drivers/net/wireless/ath/ath10k/htt.h:1683:17: warning: array subscript 65535 is outside the bounds of an interior zero-length array 'struct htt_tx_fetch_record[0]' [-Wzero-length-bounds]
>>> 1683 | return (void *)&ind->records[le16_to_cpu(ind->num_records)];
>>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>> drivers/net/wireless/ath/ath10k/htt.h:1676:29: note: while referencing 'records'
>>> 1676 | struct htt_tx_fetch_record records[0];
>>> | ^~~~~~~
>>>
>>> The structure was already converted to have a flexible-array member in
>>> the past, but there are two zero-length members in the end and only
>>> one of them can be a flexible-array member.
>>>
>>> Swap the two around to avoid the warning, as 'resp_ids' is not accessed
>>> in a way that causes a warning.
>>>
>>> Fixes: 3ba225b506a2 ("treewide: Replace zero-length array with flexible-array member")
>>> Fixes: 22e6b3bc5d96 ("ath10k: add new htt definitions")
>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>> ---
>>> drivers/net/wireless/ath/ath10k/htt.h | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/net/wireless/ath/ath10k/htt.h b/drivers/net/wireless/ath/ath10k/htt.h
>>> index e7096a73c6ca..7621f0a3dc77 100644
>>> --- a/drivers/net/wireless/ath/ath10k/htt.h
>>> +++ b/drivers/net/wireless/ath/ath10k/htt.h
>>> @@ -1673,8 +1673,8 @@ struct htt_tx_fetch_ind {
>>> __le32 token;
>>> __le16 num_resp_ids;
>>> __le16 num_records;
>>> - struct htt_tx_fetch_record records[0];
>>> - __le32 resp_ids[]; /* ath10k_htt_get_tx_fetch_ind_resp_ids() */
>>> + __le32 resp_ids[0]; /* ath10k_htt_get_tx_fetch_ind_resp_ids() */
>>> + struct htt_tx_fetch_record records[];
>>> } __packed;
>>>
>>> static inline void *
>>>
>>
>> The treewide patch is an experimental change and, as this change only applies
>> to my -next tree, I will carry this patch in it, so other people don't have
>> to worry about this at all.
>
> Gustavo, why do you have ath10k patches in your tree? I prefer that
> ath10k patches go through my ath.git tree so that they are reviewed and
> tested.
>
I just wanted to test out a mechanical change. I will remove it from my tree
now and will send a patch to you so you can apply it to your ath.git tree.
Thanks!
--
Gustavo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 04/15] ath10k: fix gcc-10 zero-length-bounds warnings
2020-05-04 16:09 ` Gustavo A. R. Silva
@ 2020-05-05 4:56 ` Kalle Valo
0 siblings, 0 replies; 7+ messages in thread
From: Kalle Valo @ 2020-05-05 4:56 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Maharaja Kennadyrajan, Kees Cook, Arnd Bergmann, Erik Stromdahl,
netdev, linux-wireless, linux-kernel, ath10k, Michal Kazior,
Wen Gong, David S. Miller
"Gustavo A. R. Silva" <gustavo@embeddedor.com> writes:
> On 5/4/20 06:54, Kalle Valo wrote:
>> "Gustavo A. R. Silva" <gustavo@embeddedor.com> writes:
>>
>>> Hi Arnd,
>>>
>>> On 4/30/20 16:30, Arnd Bergmann wrote:
>>>> gcc-10 started warning about out-of-bounds access for zero-length
>>>> arrays:
>>>>
>>>> In file included from drivers/net/wireless/ath/ath10k/core.h:18,
>>>> from drivers/net/wireless/ath/ath10k/htt_rx.c:8:
>>>> drivers/net/wireless/ath/ath10k/htt_rx.c: In function 'ath10k_htt_rx_tx_fetch_ind':
>>>> drivers/net/wireless/ath/ath10k/htt.h:1683:17: warning: array subscript 65535 is outside the bounds of an interior zero-length array 'struct htt_tx_fetch_record[0]' [-Wzero-length-bounds]
>>>> 1683 | return (void *)&ind->records[le16_to_cpu(ind->num_records)];
>>>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>>> drivers/net/wireless/ath/ath10k/htt.h:1676:29: note: while referencing 'records'
>>>> 1676 | struct htt_tx_fetch_record records[0];
>>>> | ^~~~~~~
>>>>
>>>> The structure was already converted to have a flexible-array member in
>>>> the past, but there are two zero-length members in the end and only
>>>> one of them can be a flexible-array member.
>>>>
>>>> Swap the two around to avoid the warning, as 'resp_ids' is not accessed
>>>> in a way that causes a warning.
>>>>
>>>> Fixes: 3ba225b506a2 ("treewide: Replace zero-length array with flexible-array member")
>>>> Fixes: 22e6b3bc5d96 ("ath10k: add new htt definitions")
>>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>>> ---
>>>> drivers/net/wireless/ath/ath10k/htt.h | 4 ++--
>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/drivers/net/wireless/ath/ath10k/htt.h b/drivers/net/wireless/ath/ath10k/htt.h
>>>> index e7096a73c6ca..7621f0a3dc77 100644
>>>> --- a/drivers/net/wireless/ath/ath10k/htt.h
>>>> +++ b/drivers/net/wireless/ath/ath10k/htt.h
>>>> @@ -1673,8 +1673,8 @@ struct htt_tx_fetch_ind {
>>>> __le32 token;
>>>> __le16 num_resp_ids;
>>>> __le16 num_records;
>>>> - struct htt_tx_fetch_record records[0];
>>>> - __le32 resp_ids[]; /* ath10k_htt_get_tx_fetch_ind_resp_ids() */
>>>> + __le32 resp_ids[0]; /* ath10k_htt_get_tx_fetch_ind_resp_ids() */
>>>> + struct htt_tx_fetch_record records[];
>>>> } __packed;
>>>>
>>>> static inline void *
>>>>
>>>
>>> The treewide patch is an experimental change and, as this change only applies
>>> to my -next tree, I will carry this patch in it, so other people don't have
>>> to worry about this at all.
>>
>> Gustavo, why do you have ath10k patches in your tree? I prefer that
>> ath10k patches go through my ath.git tree so that they are reviewed and
>> tested.
>>
>
> I just wanted to test out a mechanical change. I will remove it from my tree
> now and will send a patch to you so you can apply it to your ath.git tree.
Great, thanks.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-05-05 4:56 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-30 21:30 [PATCH 00/15] gcc-10 warning fixes Arnd Bergmann
2020-04-30 21:30 ` [PATCH 04/15] ath10k: fix gcc-10 zero-length-bounds warnings Arnd Bergmann
2020-04-30 21:45 ` Gustavo A. R. Silva
2020-04-30 21:44 ` Arnd Bergmann
2020-05-04 11:54 ` Kalle Valo
2020-05-04 16:09 ` Gustavo A. R. Silva
2020-05-05 4:56 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).