* Re: [v2,08/13] ath10k: bring back the WMI path for mgmt frames
@ 2020-06-17 8:25 Wen Gong
2020-06-18 4:09 ` Wen Gong
0 siblings, 1 reply; 5+ messages in thread
From: Wen Gong @ 2020-06-17 8:25 UTC (permalink / raw)
To: bartosz.markowski, ath10k
> +
> + skb_queue_tail(&ar->wmi_mgmt_tx_queue, skb);
> + ieee80211_queue_work(ar->hw, &ar->wmi_mgmt_tx_work);
https://patchwork.kernel.org/patch/2947291/
(https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5e00d31a0fb74c36f3b174ff0d4914cf09016e6f)
Do you know why this patch used ieee80211_queue_work, not use "struct
workqueue_struct *workqueue" of ath10k?
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [v2,08/13] ath10k: bring back the WMI path for mgmt frames
2020-06-17 8:25 [v2,08/13] ath10k: bring back the WMI path for mgmt frames Wen Gong
@ 2020-06-18 4:09 ` Wen Gong
2020-06-18 8:53 ` Wen Gong
2020-06-23 11:48 ` Kalle Valo
0 siblings, 2 replies; 5+ messages in thread
From: Wen Gong @ 2020-06-18 4:09 UTC (permalink / raw)
To: bartosz.markowski, ath10k
On 2020-06-17 16:25, Wen Gong wrote:
>> +
>> + skb_queue_tail(&ar->wmi_mgmt_tx_queue, skb);
>> + ieee80211_queue_work(ar->hw, &ar->wmi_mgmt_tx_work);
> https://patchwork.kernel.org/patch/2947291/
> (https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5e00d31a0fb74c36f3b174ff0d4914cf09016e6f)
>
> Do you know why this patch used ieee80211_queue_work, not use "struct
> workqueue_struct *workqueue" of ath10k?
No one know it?
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [v2,08/13] ath10k: bring back the WMI path for mgmt frames
2020-06-18 4:09 ` Wen Gong
@ 2020-06-18 8:53 ` Wen Gong
2020-06-23 11:48 ` Kalle Valo
1 sibling, 0 replies; 5+ messages in thread
From: Wen Gong @ 2020-06-18 8:53 UTC (permalink / raw)
To: bartosz.markowski, ath10k
On 2020-06-18 12:09, Wen Gong wrote:
> On 2020-06-17 16:25, Wen Gong wrote:
>>> +
>>> + skb_queue_tail(&ar->wmi_mgmt_tx_queue, skb);
>>> + ieee80211_queue_work(ar->hw, &ar->wmi_mgmt_tx_work);
>> https://patchwork.kernel.org/patch/2947291/
>> (https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5e00d31a0fb74c36f3b174ff0d4914cf09016e6f)
>>
>> Do you know why this patch used ieee80211_queue_work, not use "struct
>> workqueue_struct *workqueue" of ath10k?
> No one know it?
ieee80211_queue_work is use local->workqueue of ieee80211_hw, if it is
blocked by some function of
mac80211 which is wait some mutex, then the pending worker of the queue
from ath10k will not be
executed again, this is a risk of not using workqueue of ath10k.
I have hit issue about this:
cfg80211_leave called wdev_lock(wdev) to occupy lock, then
ieee80211_sta_rx_queued_mgmt which is running in
local->workqueue of ieee80211_hw acquire the same lock by function
sdata_lock(sdata), then it entered wait state
and the workqueue of ieee80211_hw blocked and all pending worker of it
can not executed.
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [v2,08/13] ath10k: bring back the WMI path for mgmt frames
2020-06-18 4:09 ` Wen Gong
2020-06-18 8:53 ` Wen Gong
@ 2020-06-23 11:48 ` Kalle Valo
2020-06-24 1:44 ` Wen Gong
1 sibling, 1 reply; 5+ messages in thread
From: Kalle Valo @ 2020-06-23 11:48 UTC (permalink / raw)
To: Wen Gong; +Cc: ath10k, bartosz.markowski
Wen Gong <wgong@codeaurora.org> writes:
> On 2020-06-17 16:25, Wen Gong wrote:
>>> +
>>> + skb_queue_tail(&ar->wmi_mgmt_tx_queue, skb);
>>> + ieee80211_queue_work(ar->hw, &ar->wmi_mgmt_tx_work);
>> https://patchwork.kernel.org/patch/2947291/
>> (https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5e00d31a0fb74c36f3b174ff0d4914cf09016e6f)
>>
>> Do you know why this patch used ieee80211_queue_work, not use "struct
>> workqueue_struct *workqueue" of ath10k?
>
> No one know it?
This is a patch from 7 years ago, it's quite difficult to remember
anything else than what's in the commit log. And I don't think the email
address for Bartosz works anymore.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [v2,08/13] ath10k: bring back the WMI path for mgmt frames
2020-06-23 11:48 ` Kalle Valo
@ 2020-06-24 1:44 ` Wen Gong
0 siblings, 0 replies; 5+ messages in thread
From: Wen Gong @ 2020-06-24 1:44 UTC (permalink / raw)
To: Kalle Valo; +Cc: ath10k, bartosz.markowski
On 2020-06-23 19:48, Kalle Valo wrote:
> Wen Gong <wgong@codeaurora.org> writes:
>
>> On 2020-06-17 16:25, Wen Gong wrote:
>>>> +
>>>> + skb_queue_tail(&ar->wmi_mgmt_tx_queue, skb);
>>>> + ieee80211_queue_work(ar->hw, &ar->wmi_mgmt_tx_work);
>>> https://patchwork.kernel.org/patch/2947291/
>>> (https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5e00d31a0fb74c36f3b174ff0d4914cf09016e6f)
>>>
>>> Do you know why this patch used ieee80211_queue_work, not use "struct
>>> workqueue_struct *workqueue" of ath10k?
>>
>> No one know it?
>
> This is a patch from 7 years ago, it's quite difficult to remember
> anything else than what's in the commit log. And I don't think the
> email
> address for Bartosz works anymore.
Thanks Kalle.
I hit issue on ath11k, and I have fixed it.
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-06-24 1:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-17 8:25 [v2,08/13] ath10k: bring back the WMI path for mgmt frames Wen Gong
2020-06-18 4:09 ` Wen Gong
2020-06-18 8:53 ` Wen Gong
2020-06-23 11:48 ` Kalle Valo
2020-06-24 1:44 ` Wen Gong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).