* [PATCH 0/2] ath10k: Add chain-1 voltage regulator voting
@ 2020-06-26 18:01 Rakesh Pillai
2020-06-26 18:01 ` [PATCH 1/2] dt: bindings: Add new regulator as optional property for WCN3990 Rakesh Pillai
` (2 more replies)
0 siblings, 3 replies; 11+ messages in thread
From: Rakesh Pillai @ 2020-06-26 18:01 UTC (permalink / raw)
To: ath10k, devicetree; +Cc: Rakesh Pillai, linux-wireless, linux-kernel
Add the support to vote for the chain-1
voltage regulator for WCN3990. This is
added as an optional property.
Rakesh Pillai (2):
dt: bindings: Add new regulator as optional property for WCN3990
ath10k: Add support for chain1 regulator supply voting
Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt | 4 +++-
drivers/net/wireless/ath/ath10k/snoc.c | 1 +
2 files changed, 4 insertions(+), 1 deletion(-)
--
2.7.4
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH 1/2] dt: bindings: Add new regulator as optional property for WCN3990 2020-06-26 18:01 [PATCH 0/2] ath10k: Add chain-1 voltage regulator voting Rakesh Pillai @ 2020-06-26 18:01 ` Rakesh Pillai 2020-06-26 21:46 ` Doug Anderson ` (2 more replies) 2020-06-26 18:01 ` [PATCH 2/2] ath10k: Add support for chain1 regulator supply voting Rakesh Pillai 2020-08-24 23:50 ` [PATCH 0/2] ath10k: Add chain-1 voltage regulator voting Doug Anderson 2 siblings, 3 replies; 11+ messages in thread From: Rakesh Pillai @ 2020-06-26 18:01 UTC (permalink / raw) To: ath10k, devicetree; +Cc: Rakesh Pillai, linux-wireless, linux-kernel Add an additional regulator supply as an optional property for WCN3990. Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1 Signed-off-by: Rakesh Pillai <pillair@codeaurora.org> --- Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt index 65ee68e..b7188d3 100644 --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt @@ -65,7 +65,8 @@ Optional properties: the length can vary between hw versions. - <supply-name>-supply: handle to the regulator device tree node optional "supply-name" are "vdd-0.8-cx-mx", - "vdd-1.8-xo", "vdd-1.3-rfa" and "vdd-3.3-ch0". + "vdd-1.8-xo", "vdd-1.3-rfa", "vdd-3.3-ch0" + and "vdd-3.3-ch1". - memory-region: Usage: optional Value type: <phandle> @@ -204,6 +205,7 @@ wifi@18000000 { vdd-1.8-xo-supply = <&vreg_l7a_1p8>; vdd-1.3-rfa-supply = <&vreg_l17a_1p3>; vdd-3.3-ch0-supply = <&vreg_l25a_3p3>; + vdd-3.3-ch1-supply = <&vreg_l26a_3p3>; memory-region = <&wifi_msa_mem>; iommus = <&apps_smmu 0x0040 0x1>; qcom,msa-fixed-perm; -- 2.7.4 _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 1/2] dt: bindings: Add new regulator as optional property for WCN3990 2020-06-26 18:01 ` [PATCH 1/2] dt: bindings: Add new regulator as optional property for WCN3990 Rakesh Pillai @ 2020-06-26 21:46 ` Doug Anderson 2020-07-15 20:21 ` Rob Herring 2020-09-08 5:43 ` Kalle Valo 2 siblings, 0 replies; 11+ messages in thread From: Doug Anderson @ 2020-06-26 21:46 UTC (permalink / raw) To: Rakesh Pillai, Kalle Valo Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, Rob Herring, linux-wireless, LKML, ath10k Hi, On Fri, Jun 26, 2020 at 11:02 AM Rakesh Pillai <pillair@codeaurora.org> wrote: > > Add an additional regulator supply as an optional > property for WCN3990. > > Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1 > > Signed-off-by: Rakesh Pillai <pillair@codeaurora.org> > --- > Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Overall though: aren't you missing a whole lot of CCs? Have you tried using get_maintainer? > diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt > index 65ee68e..b7188d3 100644 > --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt > +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt > @@ -65,7 +65,8 @@ Optional properties: > the length can vary between hw versions. > - <supply-name>-supply: handle to the regulator device tree node > optional "supply-name" are "vdd-0.8-cx-mx", > - "vdd-1.8-xo", "vdd-1.3-rfa" and "vdd-3.3-ch0". > + "vdd-1.8-xo", "vdd-1.3-rfa", "vdd-3.3-ch0" > + and "vdd-3.3-ch1". nit that could probably be fixed by maintainer when applying: missing comma at the end of "vdd-3.3-ch0" I will also note that this file is in dire need of being converted to yaml. Pretty soon I think people are going to start disallowing changes to the bindings that haven't been converted to yaml so you probably want to get a jump start on it so future patches aren't stalled. In any case: Reviewed-by: Douglas Anderson <dianders@chromium.org> _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/2] dt: bindings: Add new regulator as optional property for WCN3990 2020-06-26 18:01 ` [PATCH 1/2] dt: bindings: Add new regulator as optional property for WCN3990 Rakesh Pillai 2020-06-26 21:46 ` Doug Anderson @ 2020-07-15 20:21 ` Rob Herring 2020-09-08 5:43 ` Kalle Valo 2 siblings, 0 replies; 11+ messages in thread From: Rob Herring @ 2020-07-15 20:21 UTC (permalink / raw) To: Rakesh Pillai; +Cc: devicetree, linux-wireless, linux-kernel, ath10k On Fri, 26 Jun 2020 23:31:41 +0530, Rakesh Pillai wrote: > Add an additional regulator supply as an optional > property for WCN3990. > > Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1 > > Signed-off-by: Rakesh Pillai <pillair@codeaurora.org> > --- > Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Acked-by: Rob Herring <robh@kernel.org> _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/2] dt: bindings: Add new regulator as optional property for WCN3990 2020-06-26 18:01 ` [PATCH 1/2] dt: bindings: Add new regulator as optional property for WCN3990 Rakesh Pillai 2020-06-26 21:46 ` Doug Anderson 2020-07-15 20:21 ` Rob Herring @ 2020-09-08 5:43 ` Kalle Valo 2 siblings, 0 replies; 11+ messages in thread From: Kalle Valo @ 2020-09-08 5:43 UTC (permalink / raw) To: Rakesh Pillai; +Cc: devicetree, linux-wireless, linux-kernel, ath10k Rakesh Pillai <pillair@codeaurora.org> wrote: > Add an additional regulator supply as an optional > property for WCN3990. > > Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1 > > Signed-off-by: Rakesh Pillai <pillair@codeaurora.org> > Reviewed-by: Douglas Anderson <dianders@chromium.org> > Acked-by: Rob Herring <robh@kernel.org> > Signed-off-by: Kalle Valo <kvalo@codeaurora.org> 2 patches applied to ath-next branch of ath.git, thanks. 8f1553694551 dt: bindings: Add new regulator as optional property for WCN3990 9e69fe31ca9a ath10k: Add support for chain1 regulator supply voting -- https://patchwork.kernel.org/patch/11628309/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 2/2] ath10k: Add support for chain1 regulator supply voting 2020-06-26 18:01 [PATCH 0/2] ath10k: Add chain-1 voltage regulator voting Rakesh Pillai 2020-06-26 18:01 ` [PATCH 1/2] dt: bindings: Add new regulator as optional property for WCN3990 Rakesh Pillai @ 2020-06-26 18:01 ` Rakesh Pillai 2020-06-26 21:51 ` Doug Anderson 2020-08-24 23:50 ` [PATCH 0/2] ath10k: Add chain-1 voltage regulator voting Doug Anderson 2 siblings, 1 reply; 11+ messages in thread From: Rakesh Pillai @ 2020-06-26 18:01 UTC (permalink / raw) To: ath10k, devicetree; +Cc: Rakesh Pillai, linux-wireless, linux-kernel Add support to vote for chain-1 voltage regulator in WCN3990. Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1 Signed-off-by: Rakesh Pillai <pillair@codeaurora.org> --- drivers/net/wireless/ath/ath10k/snoc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/ath/ath10k/snoc.c b/drivers/net/wireless/ath/ath10k/snoc.c index 645ed5f..407a074 100644 --- a/drivers/net/wireless/ath/ath10k/snoc.c +++ b/drivers/net/wireless/ath/ath10k/snoc.c @@ -45,6 +45,7 @@ static const char * const ath10k_regulators[] = { "vdd-1.8-xo", "vdd-1.3-rfa", "vdd-3.3-ch0", + "vdd-3.3-ch1", }; static const char * const ath10k_clocks[] = { -- 2.7.4 _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 2/2] ath10k: Add support for chain1 regulator supply voting 2020-06-26 18:01 ` [PATCH 2/2] ath10k: Add support for chain1 regulator supply voting Rakesh Pillai @ 2020-06-26 21:51 ` Doug Anderson 2020-06-29 12:13 ` Rakesh Pillai 0 siblings, 1 reply; 11+ messages in thread From: Doug Anderson @ 2020-06-26 21:51 UTC (permalink / raw) To: Rakesh Pillai, Kalle Valo Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, linux-wireless, LKML, ath10k Hi, On Fri, Jun 26, 2020 at 11:02 AM Rakesh Pillai <pillair@codeaurora.org> wrote: > > Add support to vote for chain-1 voltage regulator > in WCN3990. > > Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1 > > Signed-off-by: Rakesh Pillai <pillair@codeaurora.org> > --- > drivers/net/wireless/ath/ath10k/snoc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/wireless/ath/ath10k/snoc.c b/drivers/net/wireless/ath/ath10k/snoc.c > index 645ed5f..407a074 100644 > --- a/drivers/net/wireless/ath/ath10k/snoc.c > +++ b/drivers/net/wireless/ath/ath10k/snoc.c > @@ -45,6 +45,7 @@ static const char * const ath10k_regulators[] = { > "vdd-1.8-xo", > "vdd-1.3-rfa", > "vdd-3.3-ch0", > + "vdd-3.3-ch1", Reviewed-by: Douglas Anderson <dianders@chromium.org> ...with the slight nit that ${SUBJECT} and description should probably call it "chan1" and not "chain1". Presumably the maintainer can fix when applying. -Doug _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k ^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [PATCH 2/2] ath10k: Add support for chain1 regulator supply voting 2020-06-26 21:51 ` Doug Anderson @ 2020-06-29 12:13 ` Rakesh Pillai 2020-06-29 14:33 ` Doug Anderson 0 siblings, 1 reply; 11+ messages in thread From: Rakesh Pillai @ 2020-06-29 12:13 UTC (permalink / raw) To: 'Doug Anderson', 'Kalle Valo' Cc: 'open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS', 'linux-wireless', 'LKML', ath10k > -----Original Message----- > From: Doug Anderson <dianders@chromium.org> > Sent: Saturday, June 27, 2020 3:22 AM > To: Rakesh Pillai <pillair@codeaurora.org>; Kalle Valo > <kvalo@codeaurora.org> > Cc: ath10k@lists.infradead.org; open list:OPEN FIRMWARE AND FLATTENED > DEVICE TREE BINDINGS <devicetree@vger.kernel.org>; linux-wireless <linux- > wireless@vger.kernel.org>; LKML <linux-kernel@vger.kernel.org> > Subject: Re: [PATCH 2/2] ath10k: Add support for chain1 regulator supply > voting > > Hi, > > On Fri, Jun 26, 2020 at 11:02 AM Rakesh Pillai <pillair@codeaurora.org> wrote: > > > > Add support to vote for chain-1 voltage regulator > > in WCN3990. > > > > Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1 > > > > Signed-off-by: Rakesh Pillai <pillair@codeaurora.org> > > --- > > drivers/net/wireless/ath/ath10k/snoc.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/net/wireless/ath/ath10k/snoc.c > b/drivers/net/wireless/ath/ath10k/snoc.c > > index 645ed5f..407a074 100644 > > --- a/drivers/net/wireless/ath/ath10k/snoc.c > > +++ b/drivers/net/wireless/ath/ath10k/snoc.c > > @@ -45,6 +45,7 @@ static const char * const ath10k_regulators[] = { > > "vdd-1.8-xo", > > "vdd-1.3-rfa", > > "vdd-3.3-ch0", > > + "vdd-3.3-ch1", > > Reviewed-by: Douglas Anderson <dianders@chromium.org> > > ...with the slight nit that ${SUBJECT} and description should probably > call it "chan1" and not "chain1". Presumably the maintainer can fix > when applying. > > -Doug Hi Doug, It has to be chain1 only, not chan1. This is the power supply rail for the wlan-chain1 _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 2/2] ath10k: Add support for chain1 regulator supply voting 2020-06-29 12:13 ` Rakesh Pillai @ 2020-06-29 14:33 ` Doug Anderson 0 siblings, 0 replies; 11+ messages in thread From: Doug Anderson @ 2020-06-29 14:33 UTC (permalink / raw) To: Rakesh Pillai Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, linux-wireless, ath10k, Kalle Valo, LKML Hi, On Mon, Jun 29, 2020 at 5:14 AM Rakesh Pillai <pillair@codeaurora.org> wrote: > > > > > -----Original Message----- > > From: Doug Anderson <dianders@chromium.org> > > Sent: Saturday, June 27, 2020 3:22 AM > > To: Rakesh Pillai <pillair@codeaurora.org>; Kalle Valo > > <kvalo@codeaurora.org> > > Cc: ath10k@lists.infradead.org; open list:OPEN FIRMWARE AND FLATTENED > > DEVICE TREE BINDINGS <devicetree@vger.kernel.org>; linux-wireless <linux- > > wireless@vger.kernel.org>; LKML <linux-kernel@vger.kernel.org> > > Subject: Re: [PATCH 2/2] ath10k: Add support for chain1 regulator supply > > voting > > > > Hi, > > > > On Fri, Jun 26, 2020 at 11:02 AM Rakesh Pillai <pillair@codeaurora.org> wrote: > > > > > > Add support to vote for chain-1 voltage regulator > > > in WCN3990. > > > > > > Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1 > > > > > > Signed-off-by: Rakesh Pillai <pillair@codeaurora.org> > > > --- > > > drivers/net/wireless/ath/ath10k/snoc.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/net/wireless/ath/ath10k/snoc.c > > b/drivers/net/wireless/ath/ath10k/snoc.c > > > index 645ed5f..407a074 100644 > > > --- a/drivers/net/wireless/ath/ath10k/snoc.c > > > +++ b/drivers/net/wireless/ath/ath10k/snoc.c > > > @@ -45,6 +45,7 @@ static const char * const ath10k_regulators[] = { > > > "vdd-1.8-xo", > > > "vdd-1.3-rfa", > > > "vdd-3.3-ch0", > > > + "vdd-3.3-ch1", > > > > Reviewed-by: Douglas Anderson <dianders@chromium.org> > > > > ...with the slight nit that ${SUBJECT} and description should probably > > call it "chan1" and not "chain1". Presumably the maintainer can fix > > when applying. > > > > -Doug > > Hi Doug, > > It has to be chain1 only, not chan1. > This is the power supply rail for the wlan-chain1 Whoa, really? "ch1" stands for "chain1", not "chan1"? That is seriously weird (at least to me), but I find at least one document that agrees with you. Sorry for the mistake! -Doug _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 0/2] ath10k: Add chain-1 voltage regulator voting 2020-06-26 18:01 [PATCH 0/2] ath10k: Add chain-1 voltage regulator voting Rakesh Pillai 2020-06-26 18:01 ` [PATCH 1/2] dt: bindings: Add new regulator as optional property for WCN3990 Rakesh Pillai 2020-06-26 18:01 ` [PATCH 2/2] ath10k: Add support for chain1 regulator supply voting Rakesh Pillai @ 2020-08-24 23:50 ` Doug Anderson 2020-09-07 16:10 ` Kalle Valo 2 siblings, 1 reply; 11+ messages in thread From: Doug Anderson @ 2020-08-24 23:50 UTC (permalink / raw) To: Rakesh Pillai, Kalle Valo Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, linux-wireless, LKML, ath10k Hi, On Fri, Jun 26, 2020 at 11:02 AM Rakesh Pillai <pillair@codeaurora.org> wrote: > > Add the support to vote for the chain-1 > voltage regulator for WCN3990. This is > added as an optional property. > > Rakesh Pillai (2): > dt: bindings: Add new regulator as optional property for WCN3990 > ath10k: Add support for chain1 regulator supply voting > > Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt | 4 +++- > drivers/net/wireless/ath/ath10k/snoc.c | 1 + > 2 files changed, 4 insertions(+), 1 deletion(-) This series is marked as "Awaiting Upstream" in patchwork. I don't see anything blocking it landing now. -Doug _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 0/2] ath10k: Add chain-1 voltage regulator voting 2020-08-24 23:50 ` [PATCH 0/2] ath10k: Add chain-1 voltage regulator voting Doug Anderson @ 2020-09-07 16:10 ` Kalle Valo 0 siblings, 0 replies; 11+ messages in thread From: Kalle Valo @ 2020-09-07 16:10 UTC (permalink / raw) To: Doug Anderson Cc: linux-wireless, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, Rakesh Pillai, LKML, ath10k Doug Anderson <dianders@chromium.org> writes: > Hi, > > On Fri, Jun 26, 2020 at 11:02 AM Rakesh Pillai <pillair@codeaurora.org> wrote: >> >> Add the support to vote for the chain-1 >> voltage regulator for WCN3990. This is >> added as an optional property. >> >> Rakesh Pillai (2): >> dt: bindings: Add new regulator as optional property for WCN3990 >> ath10k: Add support for chain1 regulator supply voting >> >> Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt | 4 +++- >> drivers/net/wireless/ath/ath10k/snoc.c | 1 + >> 2 files changed, 4 insertions(+), 1 deletion(-) > > This series is marked as "Awaiting Upstream" in patchwork. I don't > see anything blocking it landing now. Thanks, moved it to New state now. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2020-09-08 5:43 UTC | newest] Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-06-26 18:01 [PATCH 0/2] ath10k: Add chain-1 voltage regulator voting Rakesh Pillai 2020-06-26 18:01 ` [PATCH 1/2] dt: bindings: Add new regulator as optional property for WCN3990 Rakesh Pillai 2020-06-26 21:46 ` Doug Anderson 2020-07-15 20:21 ` Rob Herring 2020-09-08 5:43 ` Kalle Valo 2020-06-26 18:01 ` [PATCH 2/2] ath10k: Add support for chain1 regulator supply voting Rakesh Pillai 2020-06-26 21:51 ` Doug Anderson 2020-06-29 12:13 ` Rakesh Pillai 2020-06-29 14:33 ` Doug Anderson 2020-08-24 23:50 ` [PATCH 0/2] ath10k: Add chain-1 voltage regulator voting Doug Anderson 2020-09-07 16:10 ` Kalle Valo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).