From: Stephen Boyd <swboyd@chromium.org>
To: Abhishek Kumar <kuabhs@chromium.org>
Cc: Matthias Kaehlcke <mka@chromium.org>,
Kalle Valo <kvalo@codeaurora.org>,
LKML <linux-kernel@vger.kernel.org>,
ath10k <ath10k@lists.infradead.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
linux-arm-msm@vger.kernel.org, netdev <netdev@vger.kernel.org>,
Youghandhar Chintala <youghand@codeaurora.org>,
Rakesh Pillai <pillair@codeaurora.org>
Subject: Re: [PATCH] ath10k: Don't always treat modem stop events as crashes
Date: Wed, 8 Sep 2021 17:21:56 -0700 [thread overview]
Message-ID: <CAE-0n50RUGTA8sfK52YWXRkoi31XYnJkahy_MydRZ0zM1QXRQg@mail.gmail.com> (raw)
In-Reply-To: <CACTWRwsRLrKHRWVoHHyrU2DEc_VkhqSi66tdD2OBWs_y8J2LPw@mail.gmail.com>
Quoting Abhishek Kumar (2021-09-08 15:37:07)
>
> Overall this change should fix the issue, additionally I have one
> comment below and would like other reviewers views.
>
> > #include <linux/regulator/consumer.h>
> > +#include <linux/remoteproc/qcom_rproc.h>
> > #include <linux/of_address.h>
> We are adding an external dependency here but since this is added in
> snoc.c (which is for integrated solution only), I can expect if SNOC
> is enabled, remote proc will be enabled as well, so it should be fine.
There are stubs so that if it isn't enabled it won't do anything. But as
you say SNOC relies on the modem to boot, so maybe CONFIG_ATH10K_SNOC
should depend on some remoteproc config anyway? I'm not clear how probe
ordering works but I think we'll want to make sure that we only register
the notifier once the remoteproc driver for the modem adds itself to the
list of available strings to look for.
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2021-09-09 0:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-05 21:04 [PATCH] ath10k: Don't always treat modem stop events as crashes Stephen Boyd
2021-09-06 0:43 ` Steev Klimaszewski
2021-09-07 19:32 ` Matthias Kaehlcke
2021-09-07 19:48 ` Stephen Boyd
2021-09-08 22:37 ` Abhishek Kumar
2021-09-09 0:21 ` Stephen Boyd [this message]
[not found] <002501d7af73$ae0a7620$0a1f6260$@codeaurora.org>
2021-09-22 22:20 ` Stephen Boyd
2021-09-24 7:59 ` Kalle Valo
2021-09-24 8:07 ` pillair
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE-0n50RUGTA8sfK52YWXRkoi31XYnJkahy_MydRZ0zM1QXRQg@mail.gmail.com \
--to=swboyd@chromium.org \
--cc=ath10k@lists.infradead.org \
--cc=kuabhs@chromium.org \
--cc=kvalo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mka@chromium.org \
--cc=netdev@vger.kernel.org \
--cc=pillair@codeaurora.org \
--cc=youghand@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).