From: Stephen Boyd <swboyd@chromium.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: Kalle Valo <kvalo@codeaurora.org>,
linux-kernel@vger.kernel.org, ath10k@lists.infradead.org,
linux-wireless@vger.kernel.org, linux-arm-msm@vger.kernel.org,
netdev@vger.kernel.org, Govind Singh <govinds@codeaurora.org>,
Youghandhar Chintala <youghand@codeaurora.org>,
Abhishek Kumar <kuabhs@chromium.org>
Subject: Re: [PATCH] ath10k: Don't always treat modem stop events as crashes
Date: Tue, 7 Sep 2021 19:48:11 +0000 [thread overview]
Message-ID: <CAE-0n52d_GBh70pSDXTrVkD5S6akP4O9YcE4tVRKZcvLtLZSmg@mail.gmail.com> (raw)
In-Reply-To: <YTe+a0Gu7O6MEy2d@google.com>
Quoting Matthias Kaehlcke (2021-09-07 12:32:59)
> On Sun, Sep 05, 2021 at 02:04:00PM -0700, Stephen Boyd wrote:
> > @@ -1740,10 +1805,19 @@ static int ath10k_snoc_probe(struct platform_device *pdev)
> > goto err_fw_deinit;
> > }
> >
> > + ret = ath10k_modem_init(ar);
> > + if (ret) {
> > + ath10k_err(ar, "failed to initialize modem notifier: %d\n", ret);
>
> nit: ath10k_modem_init() encapsulates/hides the setup of the notifier,
> the error message should be inside the function, as for _deinit()
Sure. I can fix it. I was also wondering if I should drop the debug
prints for the cases that don't matter in the switch statement but I'll
just leave that alone unless someone complains about it.
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2021-09-07 19:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-05 21:04 [PATCH] ath10k: Don't always treat modem stop events as crashes Stephen Boyd
2021-09-06 0:43 ` Steev Klimaszewski
2021-09-07 19:32 ` Matthias Kaehlcke
2021-09-07 19:48 ` Stephen Boyd [this message]
2021-09-08 22:37 ` Abhishek Kumar
2021-09-09 0:21 ` Stephen Boyd
[not found] <002501d7af73$ae0a7620$0a1f6260$@codeaurora.org>
2021-09-22 22:20 ` Stephen Boyd
2021-09-24 7:59 ` Kalle Valo
2021-09-24 8:07 ` pillair
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE-0n52d_GBh70pSDXTrVkD5S6akP4O9YcE4tVRKZcvLtLZSmg@mail.gmail.com \
--to=swboyd@chromium.org \
--cc=ath10k@lists.infradead.org \
--cc=govinds@codeaurora.org \
--cc=kuabhs@chromium.org \
--cc=kvalo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mka@chromium.org \
--cc=netdev@vger.kernel.org \
--cc=youghand@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).