* [PATCH -next] wifi: ath11k: fix return value check in ath11k_ahb_probe()
@ 2023-02-17 3:00 Yang Yingliang
2023-02-20 8:36 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Yang Yingliang @ 2023-02-17 3:00 UTC (permalink / raw)
To: linux-wireless, ath11k
Cc: kvalo, quic_kathirve, quic_srirrama, yangyingliang, liwei391
ioremap() returns NULL pointer not PTR_ERR() when it fails,
so replace the IS_ERR() check with NULL pointer check.
Fixes: b42b3678c91f ("wifi: ath11k: remap ce register space for IPQ5018")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/net/wireless/ath/ath11k/ahb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath11k/ahb.c b/drivers/net/wireless/ath/ath11k/ahb.c
index 920abce9053a..bad3946b44bf 100644
--- a/drivers/net/wireless/ath/ath11k/ahb.c
+++ b/drivers/net/wireless/ath/ath11k/ahb.c
@@ -1174,7 +1174,7 @@ static int ath11k_ahb_probe(struct platform_device *pdev)
* to a new space for accessing them.
*/
ab->mem_ce = ioremap(ce_remap->base, ce_remap->size);
- if (IS_ERR(ab->mem_ce)) {
+ if (!ab->mem_ce) {
dev_err(&pdev->dev, "ce ioremap error\n");
ret = -ENOMEM;
goto err_core_free;
--
2.25.1
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] wifi: ath11k: fix return value check in ath11k_ahb_probe()
2023-02-17 3:00 [PATCH -next] wifi: ath11k: fix return value check in ath11k_ahb_probe() Yang Yingliang
@ 2023-02-20 8:36 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2023-02-20 8:36 UTC (permalink / raw)
To: Yang Yingliang
Cc: linux-wireless, ath11k, quic_kathirve, quic_srirrama,
yangyingliang, liwei391
Yang Yingliang <yangyingliang@huawei.com> wrote:
> ioremap() returns NULL pointer not PTR_ERR() when it fails,
> so replace the IS_ERR() check with NULL pointer check.
>
> Fixes: b42b3678c91f ("wifi: ath11k: remap ce register space for IPQ5018")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Patch applied to ath-next branch of ath.git, thanks.
342fcde9d914 wifi: ath11k: fix return value check in ath11k_ahb_probe()
--
https://patchwork.kernel.org/project/linux-wireless/patch/20230217030031.4021289-1-yangyingliang@huawei.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-20 8:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-17 3:00 [PATCH -next] wifi: ath11k: fix return value check in ath11k_ahb_probe() Yang Yingliang
2023-02-20 8:36 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).