* [PATCH] add ath11k MODULE_FIRMWARE macros @ 2020-12-02 18:27 Devin Bayer 2020-12-07 16:22 ` Kalle Valo 2020-12-08 7:45 ` Kalle Valo 0 siblings, 2 replies; 3+ messages in thread From: Devin Bayer @ 2020-12-02 18:27 UTC (permalink / raw) To: ath11k; +Cc: linux-wireless, kvalo Hello, I am trying to get the ath11k driver to work with VyOS and during the build it tries to discover the firmware blobs which drivers require. This doesn't work with ath11k because it doesn't use the MODULE_FIRMWARE macro. This patch fixes that. Thanks, Devin Signed-off-by: Devin Bayer <dev@doubly.so> --- drivers/net/wireless/ath/ath11k/core.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c index af59c23fea56..2add42ce729b 100644 --- a/drivers/net/wireless/ath/ath11k/core.c +++ b/drivers/net/wireless/ath/ath11k/core.c @@ -991,3 +991,9 @@ EXPORT_SYMBOL(ath11k_core_resume); MODULE_DESCRIPTION("Core module for Qualcomm Atheros 802.11ax wireless LAN cards."); MODULE_LICENSE("Dual BSD/GPL"); + +/* QCA639x 2.0 firmware files */ +MODULE_FIRMWARE(ATH11K_FW_DIR "/QCA6390/hw2.0/" ATH11K_BOARD_API2_FILE); +MODULE_FIRMWARE(ATH11K_FW_DIR "/QCA6390/hw2.0/" ATH11K_AMSS_FILE); +MODULE_FIRMWARE(ATH11K_FW_DIR "/QCA6390/hw2.0/" ATH11K_M3_FILE); + -- 2.25.1 -- ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] add ath11k MODULE_FIRMWARE macros 2020-12-02 18:27 [PATCH] add ath11k MODULE_FIRMWARE macros Devin Bayer @ 2020-12-07 16:22 ` Kalle Valo 2020-12-08 7:45 ` Kalle Valo 1 sibling, 0 replies; 3+ messages in thread From: Kalle Valo @ 2020-12-07 16:22 UTC (permalink / raw) To: Devin Bayer; +Cc: linux-wireless, ath11k Devin Bayer <dev@doubly.so> wrote: > I am trying to get the ath11k driver to work with VyOS and during the > build it tries to discover the firmware blobs which drivers require. > > This doesn't work with ath11k because it doesn't use the MODULE_FIRMWARE > macro. This patch fixes that. > > Signed-off-by: Devin Bayer <dev@doubly.so> > [kvalo@codeaurora.org: cleanup commit log, move to pci.c] > Signed-off-by: Kalle Valo <kvalo@codeaurora.org> I cleaned up the commit log and moved the macros to pci.c, please check my changes: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=9fc43fa2b621fa84a312d9eba538bf75c9049f3b -- https://patchwork.kernel.org/project/linux-wireless/patch/20201202182705.dhkml4nb4rf2vwav@orac/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches -- ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] add ath11k MODULE_FIRMWARE macros 2020-12-02 18:27 [PATCH] add ath11k MODULE_FIRMWARE macros Devin Bayer 2020-12-07 16:22 ` Kalle Valo @ 2020-12-08 7:45 ` Kalle Valo 1 sibling, 0 replies; 3+ messages in thread From: Kalle Valo @ 2020-12-08 7:45 UTC (permalink / raw) To: Devin Bayer; +Cc: linux-wireless, ath11k Devin Bayer <dev@doubly.so> wrote: > I am trying to get the ath11k driver to work with VyOS and during the > build it tries to discover the firmware blobs which drivers require. > > This doesn't work with ath11k because it doesn't use the MODULE_FIRMWARE > macro. This patch fixes that. > > Signed-off-by: Devin Bayer <dev@doubly.so> > [kvalo@codeaurora.org: cleanup commit log, move to pci.c] > Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Patch applied to ath-next branch of ath.git, thanks. 3dbd7fe78c42 ath11k: pci: add MODULE_FIRMWARE macros -- https://patchwork.kernel.org/project/linux-wireless/patch/20201202182705.dhkml4nb4rf2vwav@orac/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches -- ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-08 7:45 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-12-02 18:27 [PATCH] add ath11k MODULE_FIRMWARE macros Devin Bayer 2020-12-07 16:22 ` Kalle Valo 2020-12-08 7:45 ` Kalle Valo
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).