* [PATCH] ath11k: qmi: avoid error messages when dma allocation fails
@ 2021-08-23 6:32 Aaron Ma
2021-09-28 10:55 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Aaron Ma @ 2021-08-23 6:32 UTC (permalink / raw)
To: aaron.ma, kvalo, davem, kuba, ath11k, linux-wireless, netdev,
linux-kernel
qmi tries to allocate a large contiguous dma memory at first,
on the AMD Ryzen platform it fails, then retries with small slices.
So set flag GFP_NOWARN to avoid flooding dmesg.
Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
---
drivers/net/wireless/ath/ath11k/qmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath11k/qmi.c b/drivers/net/wireless/ath/ath11k/qmi.c
index b5e34d670715..d6270e96d46c 100644
--- a/drivers/net/wireless/ath/ath11k/qmi.c
+++ b/drivers/net/wireless/ath/ath11k/qmi.c
@@ -1770,7 +1770,7 @@ static int ath11k_qmi_alloc_target_mem_chunk(struct ath11k_base *ab)
chunk->vaddr = dma_alloc_coherent(ab->dev,
chunk->size,
&chunk->paddr,
- GFP_KERNEL);
+ GFP_KERNEL | __GFP_NOWARN);
if (!chunk->vaddr) {
if (ab->qmi.mem_seg_count <= ATH11K_QMI_FW_MEM_REQ_SEGMENT_CNT) {
ath11k_dbg(ab, ATH11K_DBG_QMI,
--
2.30.2
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ath11k: qmi: avoid error messages when dma allocation fails
2021-08-23 6:32 [PATCH] ath11k: qmi: avoid error messages when dma allocation fails Aaron Ma
@ 2021-09-28 10:55 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2021-09-28 10:55 UTC (permalink / raw)
To: Aaron Ma
Cc: aaron.ma, davem, kuba, ath11k, linux-wireless, netdev, linux-kernel
Aaron Ma <aaron.ma@canonical.com> wrote:
> qmi tries to allocate a large contiguous dma memory at first,
> on the AMD Ryzen platform it fails, then retries with small slices.
> So set flag GFP_NOWARN to avoid flooding dmesg.
>
> Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
b9b5948cdd7b ath11k: qmi: avoid error messages when dma allocation fails
--
https://patchwork.kernel.org/project/linux-wireless/patch/20210823063258.37747-1-aaron.ma@canonical.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-28 10:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-23 6:32 [PATCH] ath11k: qmi: avoid error messages when dma allocation fails Aaron Ma
2021-09-28 10:55 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).