From: Kalle Valo <kvalo@codeaurora.org>
To: Jouni Malinen <jouni@codeaurora.org>
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
Anilkumar Kolli <akolli@codeaurora.org>
Subject: Re: [PATCH 1/3] ath11k: add htt cmd to enable full monitor mode
Date: Fri, 24 Sep 2021 16:52:34 +0300 [thread overview]
Message-ID: <87ilyqrsgt.fsf@codeaurora.org> (raw)
In-Reply-To: <20210721171905.61838-2-jouni@codeaurora.org> (Jouni Malinen's message of "Wed, 21 Jul 2021 20:19:03 +0300")
Jouni Malinen <jouni@codeaurora.org> writes:
> From: Anilkumar Kolli <akolli@codeaurora.org>
>
> Add a new hw_param full_monitor_mode to enable full monitor support for
> QCN9074. HTT_H2T_MSG_TYPE_RX_FULL_MONITOR_MODE cmd is sent to the
> firmware to enable the full monitor mode.
>
> Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.4.0.1-01734-QCAHKSWPL_SILICONZ-1
>
> Signed-off-by: Anilkumar Kolli <akolli@codeaurora.org>
> Signed-off-by: Jouni Malinen <jouni@codeaurora.org>
> ---
> drivers/net/wireless/ath/ath11k/core.c | 4 ++
> drivers/net/wireless/ath/ath11k/dp.h | 74 +++++++++++++++++++++++++
> drivers/net/wireless/ath/ath11k/dp_tx.c | 48 ++++++++++++++++
> drivers/net/wireless/ath/ath11k/dp_tx.h | 2 +
> drivers/net/wireless/ath/ath11k/hw.h | 1 +
> 5 files changed, 129 insertions(+)
>
> diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c
> index 969bf1a590d9..3179495cb3c9 100644
> --- a/drivers/net/wireless/ath/ath11k/core.c
> +++ b/drivers/net/wireless/ath/ath11k/core.c
> @@ -65,6 +65,7 @@ static const struct ath11k_hw_params ath11k_hw_params[] = {
> BIT(NL80211_IFTYPE_AP) |
> BIT(NL80211_IFTYPE_MESH_POINT),
> .supports_monitor = true,
> + .full_monitor_mode = false,
> .supports_shadow_regs = false,
> .idle_ps = false,
> .cold_boot_calib = true,
> @@ -106,6 +107,7 @@ static const struct ath11k_hw_params ath11k_hw_params[] = {
> BIT(NL80211_IFTYPE_AP) |
> BIT(NL80211_IFTYPE_MESH_POINT),
> .supports_monitor = true,
> + .full_monitor_mode = false,
> .supports_shadow_regs = false,
> .idle_ps = false,
> .cold_boot_calib = true,
> @@ -146,6 +148,7 @@ static const struct ath11k_hw_params ath11k_hw_params[] = {
> .interface_modes = BIT(NL80211_IFTYPE_STATION) |
> BIT(NL80211_IFTYPE_AP),
> .supports_monitor = false,
> + .full_monitor_mode = false,
> .supports_shadow_regs = true,
> .idle_ps = true,
> .cold_boot_calib = false,
> @@ -184,6 +187,7 @@ static const struct ath11k_hw_params ath11k_hw_params[] = {
> BIT(NL80211_IFTYPE_AP) |
> BIT(NL80211_IFTYPE_MESH_POINT),
> .supports_monitor = true,
> + .full_monitor_mode = true,
> .supports_shadow_regs = false,
> .idle_ps = false,
> .cold_boot_calib = false,
wcn6855 was not updated, I added that.
> --- a/drivers/net/wireless/ath/ath11k/dp_tx.c
> +++ b/drivers/net/wireless/ath/ath11k/dp_tx.c
> @@ -1034,6 +1034,15 @@ int ath11k_dp_tx_htt_monitor_mode_ring_config(struct ath11k *ar, bool reset)
> struct htt_rx_ring_tlv_filter tlv_filter = {0};
> int ret = 0, ring_id = 0, i;
>
> + if (ab->hw_params.full_monitor_mode) {
> + ret = ath11k_dp_tx_htt_rx_full_mon_setup(ab,
> + dp->mac_id, !reset);
> + if (ret < 0) {
> + ath11k_err(ab, "failed to setup full monitor %d\n", ret);
I changed this to:
if (ret) {
ath11k_warn(ab, "failed to setup full monitor: %d\n", ret);
return ret;
}
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
next prev parent reply other threads:[~2021-09-24 13:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 17:19 [PATCH 0/3] ath11k: add full monitor mode support for QCN9074 Jouni Malinen
2021-07-21 17:19 ` [PATCH 1/3] ath11k: add htt cmd to enable full monitor mode Jouni Malinen
2021-09-24 11:42 ` Kalle Valo
2021-09-27 4:19 ` akolli
2021-09-28 6:56 ` Kalle Valo
2021-09-30 6:47 ` Anilkumar Kolli
2021-10-04 4:23 ` Anilkumar Kolli
2021-09-24 13:52 ` Kalle Valo [this message]
2021-09-27 4:31 ` Anilkumar Kolli
2021-07-21 17:19 ` [PATCH 2/3] ath11k: add software monitor ring descriptor for full monitor Jouni Malinen
2021-07-21 17:19 ` [PATCH 3/3] ath11k: process full monitor mode rx support Jouni Malinen
2021-11-12 7:52 ` Kalle Valo
2021-12-08 13:13 ` Anilkumar Kolli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilyqrsgt.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=akolli@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=jouni@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).