ath9k-devel.lists.ath9k.org archive mirror
 help / color / mirror / Atom feed
* [ath9k-devel] [PATCH 1/1 V3] ath9k: consider return code on
@ 2016-07-27 13:19 Eduardo Abinader
  2016-08-19 10:07 ` [ath9k-devel] [1/1,V3] " Kalle Valo
  0 siblings, 1 reply; 2+ messages in thread
From: Eduardo Abinader @ 2016-07-27 13:19 UTC (permalink / raw)
  To: ath9k-devel

just to comply with current ath9k_hw_nvram_read to return value, hence
behaving reacting accordingly.

Signed-off-by: Eduardo Abinader <eduardo.abinader@riverbed.com>
---
 drivers/net/wireless/ath/ath9k/ar9003_eeprom.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c b/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
index 5bd2cba..08607d7 100644
--- a/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
+++ b/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
@@ -3252,7 +3252,8 @@ static int ar9300_eeprom_restore_flash(struct ath_hw *ah, u8 *mptr,
 	int i;
 
 	for (i = 0; i < mdata_size / 2; i++, data++)
-		ath9k_hw_nvram_read(ah, i, data);
+		if (!ath9k_hw_nvram_read(ah, i, data))
+			return -EIO;
 
 	return 0;
 }
@@ -3282,7 +3283,8 @@ static int ar9300_eeprom_restore_internal(struct ath_hw *ah,
 	if (ath9k_hw_use_flash(ah)) {
 		u8 txrx;
 
-		ar9300_eeprom_restore_flash(ah, mptr, mdata_size);
+		if (ar9300_eeprom_restore_flash(ah, mptr, mdata_size))
+			return -EIO;
 
 		/* check if eeprom contains valid data */
 		eep = (struct ar9300_eeprom *) mptr;
-- 
2.5.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [ath9k-devel] [1/1,V3] ath9k: consider return code on
  2016-07-27 13:19 [ath9k-devel] [PATCH 1/1 V3] ath9k: consider return code on Eduardo Abinader
@ 2016-08-19 10:07 ` Kalle Valo
  0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2016-08-19 10:07 UTC (permalink / raw)
  To: ath9k-devel

Eduardo Abinader <eduardo.abinader@riverbed.com> wrote:
> just to comply with current ath9k_hw_nvram_read to return value, hence
> behaving reacting accordingly.
> 
> Signed-off-by: Eduardo Abinader <eduardo.abinader@riverbed.com>

Thanks, 1 patch applied to ath-next branch of ath.git:

a5d268277ad5 ath9k: consider return code on

-- 
Sent by pwcli
https://patchwork.kernel.org/patch/9249821/

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-08-19 10:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-27 13:19 [ath9k-devel] [PATCH 1/1 V3] ath9k: consider return code on Eduardo Abinader
2016-08-19 10:07 ` [ath9k-devel] [1/1,V3] " Kalle Valo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).