From: "Bjørn Mork" <bjorn@mork.no>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH v4 3/3] ath9k: parse the device configuration from an OF node
Date: Sun, 10 Jul 2016 00:32:42 -0000 [thread overview]
Message-ID: <87inwe9wfb.fsf@miraculix.mork.no> (raw)
In-Reply-To: <20160709232834.31654-4-martin.blumenstingl@googlemail.com> (Martin Blumenstingl's message of "Sun, 10 Jul 2016 01:28:34 +0200")
Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes:
> + if (of_property_read_bool(np, "qca,clk-25mhz"))
> + ah->is_clk_25mhz = true;
> +
> + if (of_property_read_bool(np, "qca,disable-2ghz"))
> + ah->disable_2ghz = true;
> +
> + if (of_property_read_bool(np, "qca,disable-5ghz"))
> + ah->disable_5ghz = true;
This is bike-shedding, but how about
ah->is_clk_25mhz = of_property_read_bool(np, "qca,clk-25mhz");
ah->disable_2ghz = of_property_read_bool(np, "qca,disable-2ghz");
ah->disable_5ghz = of_property_read_bool(np, "qca,disable-5ghz");
instead?
Bj?rn
next prev parent reply other threads:[~2016-07-10 0:32 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-24 12:34 [ath9k-devel] [RFC v3] ath9k: add devicetree support to ath9k Martin Blumenstingl
2016-06-24 12:34 ` [ath9k-devel] [PATCH RFC v3 1/3] Documentation: dt: net: add ath9k wireless device binding Martin Blumenstingl
2016-06-27 0:20 ` Julian Calaby
2016-06-27 9:49 ` Kalle Valo
2016-06-24 12:34 ` [ath9k-devel] [PATCH v3 2/3] ath9k: add a helper to get the string representation of ath_bus_type Martin Blumenstingl
2016-06-27 10:26 ` Felix Fietkau
2016-06-29 22:37 ` Martin Blumenstingl
2016-06-24 12:34 ` [ath9k-devel] [PATCH RFC v3 3/3] ath9k: parse the device configuration from an OF node Martin Blumenstingl
2016-06-25 12:01 ` Christian Lamparter
2016-06-25 15:08 ` Martin Blumenstingl
2016-06-25 19:26 ` Christian Lamparter
2016-06-26 23:38 ` Martin Blumenstingl
2016-07-07 1:03 ` Luis R. Rodriguez
2016-07-09 23:28 ` [ath9k-devel] [PATCH v4 0/3] add devicetree support to ath9k Martin Blumenstingl
2016-07-09 23:28 ` [ath9k-devel] [PATCH v4 1/3] Documentation: dt: net: add ath9k wireless device binding Martin Blumenstingl
2016-07-10 20:52 ` Arnd Bergmann
2016-07-10 20:54 ` Martin Blumenstingl
2016-07-10 22:01 ` Arnd Bergmann
2016-07-11 21:21 ` Martin Blumenstingl
2016-07-14 12:33 ` Arnd Bergmann
2016-07-13 7:02 ` Kalle Valo
2016-07-13 7:47 ` Arnd Bergmann
2016-07-09 23:28 ` [ath9k-devel] [PATCH v4 2/3] ath9k: add a helper to get the string representation of ath_bus_type Martin Blumenstingl
2016-07-09 23:28 ` [ath9k-devel] [PATCH v4 3/3] ath9k: parse the device configuration from an OF node Martin Blumenstingl
2016-07-10 0:32 ` Bjørn Mork [this message]
2016-07-10 9:28 ` Oleksij Rempel
2016-07-10 20:56 ` Martin Blumenstingl
2016-08-21 14:31 ` [ath9k-devel] [PATCH v5 0/3] add devicetree support to ath9k Martin Blumenstingl
2016-08-21 14:31 ` [ath9k-devel] [PATCH v5 1/3] Documentation: dt: net: add ath9k wireless device binding Martin Blumenstingl
2016-08-22 9:08 ` Arnd Bergmann
2016-08-28 20:51 ` Martin Blumenstingl
2016-08-29 12:12 ` Arnd Bergmann
2016-08-21 14:31 ` [ath9k-devel] [PATCH v5 2/3] ath9k: add a helper to get the string representation of ath_bus_type Martin Blumenstingl
2016-08-21 14:31 ` [ath9k-devel] [PATCH v5 3/3] ath9k: parse the device configuration from an OF node Martin Blumenstingl
2016-09-06 21:46 ` [ath9k-devel] [PATCH v6 0/3] add devicetree support to ath9k Martin Blumenstingl
2016-09-06 21:46 ` [ath9k-devel] [PATCH v6 1/3] Documentation: dt: net: add ath9k wireless device binding Martin Blumenstingl
2016-09-09 7:48 ` Oleksij Rempel
2016-09-09 20:57 ` Martin Blumenstingl
2016-09-13 7:28 ` Oleksij Rempel
2016-09-16 12:45 ` Rob Herring
2016-09-18 21:51 ` Martin Blumenstingl
2016-09-16 12:55 ` Rob Herring
2016-09-06 21:46 ` [ath9k-devel] [PATCH v6 2/3] ath9k: add a helper to get the string representation of ath_bus_type Martin Blumenstingl
2016-09-06 21:46 ` [ath9k-devel] [PATCH v6 3/3] ath9k: parse the device configuration from an OF node Martin Blumenstingl
2016-10-02 21:47 ` [ath9k-devel] [PATCH v7 0/3] add devicetree support to ath9k Martin Blumenstingl
2016-10-02 21:47 ` [ath9k-devel] [PATCH v7 1/3] Documentation: dt: net: add ath9k wireless device binding Martin Blumenstingl
2016-10-07 12:17 ` [ath9k-devel] [v7, " Kalle Valo
2016-10-09 1:29 ` [ath9k-devel] [PATCH v7 " Rob Herring
2016-10-09 9:54 ` Martin Blumenstingl
2016-10-02 21:47 ` [ath9k-devel] [PATCH v7 2/3] ath9k: add a helper to get the string representation of ath_bus_type Martin Blumenstingl
2016-10-02 21:47 ` [ath9k-devel] [PATCH v7 3/3] ath9k: parse the device configuration from an OF node Martin Blumenstingl
2016-10-16 20:59 ` [ath9k-devel] [PATCH v8 0/3] add devicetree support to ath9k Martin Blumenstingl
2016-10-16 20:59 ` [ath9k-devel] [PATCH v8 1/3] Documentation: dt: net: add ath9k wireless device binding Martin Blumenstingl
2016-10-18 15:31 ` Rob Herring
2016-11-15 14:56 ` [ath9k-devel] [v8, " Kalle Valo
2016-10-16 20:59 ` [ath9k-devel] [PATCH v8 2/3] ath9k: add a helper to get the string representation of ath_bus_type Martin Blumenstingl
2016-10-16 20:59 ` [ath9k-devel] [PATCH v8 3/3] ath9k: parse the device configuration from an OF node Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87inwe9wfb.fsf@miraculix.mork.no \
--to=bjorn@mork.no \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).