From: "Wang, Qingshun" <qingshun.wang@linux.intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-acpi@vger.kernel.org, chao.p.peng@linux.intel.com,
erwin.tsaur@intel.com, feiting.wanyan@intel.com,
qingshun.wang@intel.com, "Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>, James Morse <james.morse@arm.com>,
Tony Luck <tony.luck@intel.com>, Borislav Petkov <bp@alien8.de>,
Davidlohr Bueso <dave@stgolabs.net>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Dave Jiang <dave.jiang@intel.com>,
Alison Schofield <alison.schofield@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Mahesh J Salgaonkar <mahesh@linux.ibm.com>,
Oliver O'Halloran <oohall@gmail.com>,
Miaohe Lin <linmiaohe@huawei.com>,
Shiju Jose <shiju.jose@huawei.com>,
Adam Preble <adam.c.preble@intel.com>,
Li Yang <leoyang.li@nxp.com>, Lukas Wunner <lukas@wunner.de>,
Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>,
Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>,
Robert Richter <rrichter@amd.com>,
linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org,
linux-edac@vger.kernel.org
Subject: Re: [PATCH v2 2/4] PCI/AER: Handle Advisory Non-Fatal properly
Date: Wed, 7 Feb 2024 00:46:39 +0800 [thread overview]
Message-ID: <ay2cwgycgjfqz5jmteeijgjiuje2u62wozhnkr76ag4tny6vl4@upbmy22y3hcn> (raw)
In-Reply-To: <20240205232616.GA831017@bhelgaas>
On Mon, Feb 05, 2024 at 05:26:16PM -0600, Bjorn Helgaas wrote:
> In the subject, "properly" really doesn't convey information. I think
> this patch does two things:
>
> - Prints error bits that might be ANFE
> - Clears UNCOR_STATUS bits that were previously not cleared
>
> Maybe the subject line could say something about those (clearing
> UNCOR_STATUS might be more important, or maybe this could even be
> split into two patches so we could see both).
>
Good idea, thanks. I think splitting it into two patches would be the
better approach.
WARNING: multiple messages have this Message-ID (diff)
From: "Wang, Qingshun" <qingshun.wang@linux.intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Miaohe Lin <linmiaohe@huawei.com>,
Alison Schofield <alison.schofield@intel.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
linux-pci@vger.kernel.org, erwin.tsaur@intel.com,
Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>,
linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org,
Oliver O'Halloran <oohall@gmail.com>,
chao.p.peng@linux.intel.com, Ira Weiny <ira.weiny@intel.com>,
Davidlohr Bueso <dave@stgolabs.net>,
Dave Jiang <dave.jiang@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>,
linux-acpi@vger.kernel.org, Len Brown <lenb@kernel.org>,
Robert Richter <rrichter@amd.com>, Borislav Petkov <bp@alien8.de>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Dan Williams <dan.j.williams@intel.com>,
linux-edac@vger.kernel.org, Tony Luck <tony.luck@intel.com>,
feiting.wanyan@intel.com, qingshun.wang@intel.com,
Adam Preble <adam.c.preble@intel.com>,
Mahesh J Salgaonk ar <mahesh@linux.ibm.com>,
Li Yang <leoyang.li@nxp.com>, Lukas Wunner <lukas@wunner.de>,
James Morse <james.morse@arm.com>,
linuxppc-dev@lists.ozlabs.org, Shiju Jose <shiju.jose@huawei.com>
Subject: Re: [PATCH v2 2/4] PCI/AER: Handle Advisory Non-Fatal properly
Date: Wed, 7 Feb 2024 00:46:39 +0800 [thread overview]
Message-ID: <ay2cwgycgjfqz5jmteeijgjiuje2u62wozhnkr76ag4tny6vl4@upbmy22y3hcn> (raw)
In-Reply-To: <20240205232616.GA831017@bhelgaas>
On Mon, Feb 05, 2024 at 05:26:16PM -0600, Bjorn Helgaas wrote:
> In the subject, "properly" really doesn't convey information. I think
> this patch does two things:
>
> - Prints error bits that might be ANFE
> - Clears UNCOR_STATUS bits that were previously not cleared
>
> Maybe the subject line could say something about those (clearing
> UNCOR_STATUS might be more important, or maybe this could even be
> split into two patches so we could see both).
>
Good idea, thanks. I think splitting it into two patches would be the
better approach.
next prev parent reply other threads:[~2024-02-06 16:46 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-25 6:27 [PATCH v2 0/4] PCI/AER: Handle Advisory Non-Fatal properly Wang, Qingshun
2024-01-25 6:27 ` Wang, Qingshun
2024-01-25 6:27 ` [PATCH v2 1/4] PCI/AER: Store more information in aer_err_info Wang, Qingshun
2024-01-25 6:27 ` Wang, Qingshun
2024-01-31 2:26 ` Kuppuswamy Sathyanarayanan
2024-01-31 2:26 ` Kuppuswamy Sathyanarayanan
2024-01-31 8:04 ` Wang, Qingshun
2024-01-31 8:04 ` Wang, Qingshun
2024-02-05 23:12 ` Bjorn Helgaas
2024-02-05 23:12 ` Bjorn Helgaas
2024-02-06 16:41 ` Wang, Qingshun
2024-02-06 16:41 ` Wang, Qingshun
2024-02-06 17:23 ` Bjorn Helgaas
2024-02-06 17:23 ` Bjorn Helgaas
2024-02-08 16:16 ` Wang, Qingshun
2024-02-08 16:16 ` Wang, Qingshun
2024-01-25 6:28 ` [PATCH v2 2/4] PCI/AER: Handle Advisory Non-Fatal properly Wang, Qingshun
2024-01-25 6:28 ` Wang, Qingshun
2024-02-05 23:26 ` Bjorn Helgaas
2024-02-05 23:26 ` Bjorn Helgaas
2024-02-06 16:46 ` Wang, Qingshun [this message]
2024-02-06 16:46 ` Wang, Qingshun
2024-01-25 6:28 ` [PATCH v2 3/4] PCI/AER: Fetch information for FTrace Wang, Qingshun
2024-01-25 6:28 ` Wang, Qingshun
2024-02-02 18:01 ` Dan Williams
2024-02-02 18:01 ` Dan Williams
2024-02-03 4:59 ` Wang, Qingshun
2024-02-03 4:59 ` Wang, Qingshun
2024-01-25 6:28 ` [PATCH v2 4/4] RAS: Trace more information in aer_event Wang, Qingshun
2024-01-25 6:28 ` Wang, Qingshun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ay2cwgycgjfqz5jmteeijgjiuje2u62wozhnkr76ag4tny6vl4@upbmy22y3hcn \
--to=qingshun.wang@linux.intel.com \
--cc=Smita.KoralahalliChannabasappa@amd.com \
--cc=adam.c.preble@intel.com \
--cc=alison.schofield@intel.com \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=chao.p.peng@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=erwin.tsaur@intel.com \
--cc=feiting.wanyan@intel.com \
--cc=helgaas@kernel.org \
--cc=ira.weiny@intel.com \
--cc=james.morse@arm.com \
--cc=jonathan.cameron@huawei.com \
--cc=lenb@kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linmiaohe@huawei.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lukas@wunner.de \
--cc=mahesh@linux.ibm.com \
--cc=oohall@gmail.com \
--cc=qingshun.wang@intel.com \
--cc=rafael@kernel.org \
--cc=rrichter@amd.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=shiju.jose@huawei.com \
--cc=tony.luck@intel.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.