From: Lucas Stach <l.stach@pengutronix.de> To: Daniel Vetter <daniel@ffwll.ch>, Chris Wilson <chris@chris-wilson.co.uk>, Dave Airlie <airlied@gmail.com> Cc: Jani Nikula <jani.nikula@intel.com>, Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/i915: Autoselect CONFIG_CHECKPOINT_RESTORE for SYS_kcmp Date: Fri, 05 Feb 2021 17:18:42 +0100 [thread overview] Message-ID: <b01fefdd8b6fa7c8f1f863daf18a25b32f6ac29c.camel@pengutronix.de> (raw) In-Reply-To: <YB1rUCQoa+wCEh1o@phenom.ffwll.local> Am Freitag, dem 05.02.2021 um 16:59 +0100 schrieb Daniel Vetter: > On Fri, Feb 05, 2021 at 04:58:32PM +0100, Daniel Vetter wrote: > > On Fri, Feb 05, 2021 at 01:03:07PM +0000, Chris Wilson wrote: > > > gallium (iris) depends on os_same_file_description() to disambiguate > > > screens and so avoid importing the same screen fd twice as two distinct > > > entities (that share all the kernel resources, so actions on screen > > > affect the other and would cause random faiure). As they depend on it, > > > so must we. os_same_file_description() uses SYS_kcmp to check the file > > > tables for the equivalent struct file, but SYS_kcmp is hidden behind > > > CONFIG_CHECKPOINT_RESTORE. As this is not default, we must select it for > > > ourselves to ensure that our userspace is fully supported. > > > > > > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/3046 > > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > > > Cc: Jani Nikula <jani.nikula@intel.com> > > > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > > > > Hm shouldn't we crank this up to CONFIG_DRM? > > > > Or embedded folks going to be unhappy about that? If so I guess we'd need > > to pull out just the SYS_kcmp part ... > > > > Asking because I think Bas is also looking at this, and it's not great if > > we're building on this and then users end up with very subtly broken gl/vk > > stacks :-/ amdgpu gallium winsys seems to also require this, so selecting it from higher up in the Kconfig tree makes sense and I don't think embedded would be massively unhappy about this. However kcmp seems to be useful on its own and pulling it out of CHECKPOINT_RESTORE sounds like the right thing to do. Regards, Lucas > > > -Daniel > > > > > --- > > > drivers/gpu/drm/i915/Kconfig | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig > > > index 1e1cb245fca7..470a5214bd33 100644 > > > --- a/drivers/gpu/drm/i915/Kconfig > > > +++ b/drivers/gpu/drm/i915/Kconfig > > > @@ -21,6 +21,7 @@ config DRM_I915 > > > select ACPI_VIDEO if ACPI > > > select ACPI_BUTTON if ACPI > > > select SYNC_FILE > > > + select CHECKPOINT_RESTORE # gallium depends on SYS_kcmp > > > select IOSF_MBI > > > select CRC32 > > > select SND_HDA_I915 if SND_HDA_CORE > > > -- > > > 2.20.1 > > > > > > > -- > > Daniel Vetter > > Software Engineer, Intel Corporation > > http://blog.ffwll.ch > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Lucas Stach <l.stach@pengutronix.de> To: Daniel Vetter <daniel@ffwll.ch>, Chris Wilson <chris@chris-wilson.co.uk>, Dave Airlie <airlied@gmail.com> Cc: Jani Nikula <jani.nikula@intel.com>, Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH] drm/i915: Autoselect CONFIG_CHECKPOINT_RESTORE for SYS_kcmp Date: Fri, 05 Feb 2021 17:18:42 +0100 [thread overview] Message-ID: <b01fefdd8b6fa7c8f1f863daf18a25b32f6ac29c.camel@pengutronix.de> (raw) In-Reply-To: <YB1rUCQoa+wCEh1o@phenom.ffwll.local> Am Freitag, dem 05.02.2021 um 16:59 +0100 schrieb Daniel Vetter: > On Fri, Feb 05, 2021 at 04:58:32PM +0100, Daniel Vetter wrote: > > On Fri, Feb 05, 2021 at 01:03:07PM +0000, Chris Wilson wrote: > > > gallium (iris) depends on os_same_file_description() to disambiguate > > > screens and so avoid importing the same screen fd twice as two distinct > > > entities (that share all the kernel resources, so actions on screen > > > affect the other and would cause random faiure). As they depend on it, > > > so must we. os_same_file_description() uses SYS_kcmp to check the file > > > tables for the equivalent struct file, but SYS_kcmp is hidden behind > > > CONFIG_CHECKPOINT_RESTORE. As this is not default, we must select it for > > > ourselves to ensure that our userspace is fully supported. > > > > > > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/3046 > > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> > > > Cc: Jani Nikula <jani.nikula@intel.com> > > > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > > > > Hm shouldn't we crank this up to CONFIG_DRM? > > > > Or embedded folks going to be unhappy about that? If so I guess we'd need > > to pull out just the SYS_kcmp part ... > > > > Asking because I think Bas is also looking at this, and it's not great if > > we're building on this and then users end up with very subtly broken gl/vk > > stacks :-/ amdgpu gallium winsys seems to also require this, so selecting it from higher up in the Kconfig tree makes sense and I don't think embedded would be massively unhappy about this. However kcmp seems to be useful on its own and pulling it out of CHECKPOINT_RESTORE sounds like the right thing to do. Regards, Lucas > > > -Daniel > > > > > --- > > > drivers/gpu/drm/i915/Kconfig | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig > > > index 1e1cb245fca7..470a5214bd33 100644 > > > --- a/drivers/gpu/drm/i915/Kconfig > > > +++ b/drivers/gpu/drm/i915/Kconfig > > > @@ -21,6 +21,7 @@ config DRM_I915 > > > select ACPI_VIDEO if ACPI > > > select ACPI_BUTTON if ACPI > > > select SYNC_FILE > > > + select CHECKPOINT_RESTORE # gallium depends on SYS_kcmp > > > select IOSF_MBI > > > select CRC32 > > > select SND_HDA_I915 if SND_HDA_CORE > > > -- > > > 2.20.1 > > > > > > > -- > > Daniel Vetter > > Software Engineer, Intel Corporation > > http://blog.ffwll.ch > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-02-05 16:18 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-05 13:03 [PATCH] drm/i915: Autoselect CONFIG_CHECKPOINT_RESTORE for SYS_kcmp Chris Wilson 2021-02-05 13:03 ` [Intel-gfx] " Chris Wilson 2021-02-05 15:58 ` Daniel Vetter 2021-02-05 15:58 ` [Intel-gfx] " Daniel Vetter 2021-02-05 15:59 ` Daniel Vetter 2021-02-05 15:59 ` [Intel-gfx] " Daniel Vetter 2021-02-05 16:18 ` Lucas Stach [this message] 2021-02-05 16:18 ` Lucas Stach 2021-02-05 18:15 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2021-02-06 4:21 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=b01fefdd8b6fa7c8f1f863daf18a25b32f6ac29c.camel@pengutronix.de \ --to=l.stach@pengutronix.de \ --cc=airlied@gmail.com \ --cc=chris@chris-wilson.co.uk \ --cc=daniel.vetter@ffwll.ch \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=jani.nikula@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.