From: "Winkler, Tomas" <tomas.winkler@intel.com>
To: "De Marchi, Lucas" <lucas.demarchi@intel.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
"Usyskin, Alexander" <alexander.usyskin@intel.com>,
Jani Nikula <jani.nikula@linux.intel.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
"Lubart, Vitaly" <vitaly.lubart@intel.com>
Subject: RE: [Intel-gfx] [RFC PATCH 3/9] drm/i915/spi: add driver for on-die spi device
Date: Thu, 18 Feb 2021 10:50:34 +0000 [thread overview]
Message-ID: <b21d2b43a98f4947b062fe31bd350566@intel.com> (raw)
In-Reply-To: <20210218094916.brm7j62if573xu5c@ldmartin-desk1>
>
> On Wed, Feb 17, 2021 at 08:58:12PM +0000, Winkler, Tomas wrote:
> >>
> >> On Tue, 16 Feb 2021, Tomas Winkler <tomas.winkler@intel.com> wrote:
> >> > Add the platform driver for i915 on-die spi device, exposed via mfd
> >> > framework.
> >> >
> >> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> >> > Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> >> > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> >> > ---
> >> > drivers/gpu/drm/i915/Kconfig | 2 +
> >> > drivers/gpu/drm/i915/Makefile | 3 +
> >> > drivers/gpu/drm/i915/spi/intel_spi_drv.c | 116
> >> > +++++++++++++++++++++++
> >> > 3 files changed, 121 insertions(+) create mode 100644
> >> > drivers/gpu/drm/i915/spi/intel_spi_drv.c
> >> >
> >> > diff --git a/drivers/gpu/drm/i915/Kconfig
> >> > b/drivers/gpu/drm/i915/Kconfig index abcaa8da45ac..13c870e5878e
> >> > 100644
> >> > --- a/drivers/gpu/drm/i915/Kconfig
> >> > +++ b/drivers/gpu/drm/i915/Kconfig
> >> > @@ -27,6 +27,8 @@ config DRM_I915
> >> > select CEC_CORE if CEC_NOTIFIER
> >> > select VMAP_PFN
> >> > select MFD_CORE
> >> > + select MTD
> >>
> >> Selecting MTD does not seem to be a popular thing to do, which is
> >> usually a clue it's probably the wrong thing to do.
> >Depends, if it is not selected you'll end with wrongly configured system.
>
> no. I believe the idea is that having a CONFIG_I915_SPI, you could do
>
> depends on MTD
>
> like the other drivers doing similar thing:
>
> git grep MTD -- ':(exclude)drivers/mtd' ':(exclude)arch/' '*Kconfig'
MTD is usually used on embedded systems rather than on general distros, i915_spi and actually a bit redefines its usage
so w/o forceful select, it won't be enabled.
>
> Lucas De Marchi
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: "Winkler, Tomas" <tomas.winkler@intel.com>
To: "De Marchi, Lucas" <lucas.demarchi@intel.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"Usyskin, Alexander" <alexander.usyskin@intel.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"Lubart, Vitaly" <vitaly.lubart@intel.com>
Subject: Re: [Intel-gfx] [RFC PATCH 3/9] drm/i915/spi: add driver for on-die spi device
Date: Thu, 18 Feb 2021 10:50:34 +0000 [thread overview]
Message-ID: <b21d2b43a98f4947b062fe31bd350566@intel.com> (raw)
In-Reply-To: <20210218094916.brm7j62if573xu5c@ldmartin-desk1>
>
> On Wed, Feb 17, 2021 at 08:58:12PM +0000, Winkler, Tomas wrote:
> >>
> >> On Tue, 16 Feb 2021, Tomas Winkler <tomas.winkler@intel.com> wrote:
> >> > Add the platform driver for i915 on-die spi device, exposed via mfd
> >> > framework.
> >> >
> >> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> >> > Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> >> > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> >> > ---
> >> > drivers/gpu/drm/i915/Kconfig | 2 +
> >> > drivers/gpu/drm/i915/Makefile | 3 +
> >> > drivers/gpu/drm/i915/spi/intel_spi_drv.c | 116
> >> > +++++++++++++++++++++++
> >> > 3 files changed, 121 insertions(+) create mode 100644
> >> > drivers/gpu/drm/i915/spi/intel_spi_drv.c
> >> >
> >> > diff --git a/drivers/gpu/drm/i915/Kconfig
> >> > b/drivers/gpu/drm/i915/Kconfig index abcaa8da45ac..13c870e5878e
> >> > 100644
> >> > --- a/drivers/gpu/drm/i915/Kconfig
> >> > +++ b/drivers/gpu/drm/i915/Kconfig
> >> > @@ -27,6 +27,8 @@ config DRM_I915
> >> > select CEC_CORE if CEC_NOTIFIER
> >> > select VMAP_PFN
> >> > select MFD_CORE
> >> > + select MTD
> >>
> >> Selecting MTD does not seem to be a popular thing to do, which is
> >> usually a clue it's probably the wrong thing to do.
> >Depends, if it is not selected you'll end with wrongly configured system.
>
> no. I believe the idea is that having a CONFIG_I915_SPI, you could do
>
> depends on MTD
>
> like the other drivers doing similar thing:
>
> git grep MTD -- ':(exclude)drivers/mtd' ':(exclude)arch/' '*Kconfig'
MTD is usually used on embedded systems rather than on general distros, i915_spi and actually a bit redefines its usage
so w/o forceful select, it won't be enabled.
>
> Lucas De Marchi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-02-18 10:52 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 18:19 [RFC PATCH 0/9] drm/i915/spi: discrete graphics internal spi Tomas Winkler
2021-02-16 18:19 ` [Intel-gfx] " Tomas Winkler
2021-02-16 18:19 ` [RFC PATCH 1/9] drm/i915/spi: add spi device for discrete graphics Tomas Winkler
2021-02-16 18:19 ` [Intel-gfx] " Tomas Winkler
2021-02-17 10:42 ` Jani Nikula
2021-02-17 10:42 ` [Intel-gfx] " Jani Nikula
2021-02-17 17:14 ` Lucas De Marchi
2021-02-17 17:14 ` [Intel-gfx] " Lucas De Marchi
2021-02-17 19:02 ` Winkler, Tomas
2021-02-17 19:02 ` [Intel-gfx] " Winkler, Tomas
2021-02-16 18:19 ` [RFC PATCH 2/9] drm/i915/spi: intel_spi_region map Tomas Winkler
2021-02-16 18:19 ` [Intel-gfx] " Tomas Winkler
2021-02-17 10:46 ` Jani Nikula
2021-02-17 10:46 ` [Intel-gfx] " Jani Nikula
2021-02-17 20:45 ` Winkler, Tomas
2021-02-17 20:45 ` [Intel-gfx] " Winkler, Tomas
2021-02-22 10:17 ` Jani Nikula
2021-02-22 10:17 ` [Intel-gfx] " Jani Nikula
2021-02-22 11:30 ` Winkler, Tomas
2021-02-22 11:30 ` [Intel-gfx] " Winkler, Tomas
2021-02-16 18:19 ` [RFC PATCH 3/9] drm/i915/spi: add driver for on-die spi device Tomas Winkler
2021-02-16 18:19 ` [Intel-gfx] " Tomas Winkler
2021-02-17 10:56 ` Jani Nikula
2021-02-17 10:56 ` [Intel-gfx] " Jani Nikula
2021-02-17 20:58 ` Winkler, Tomas
2021-02-17 20:58 ` [Intel-gfx] " Winkler, Tomas
2021-02-18 9:49 ` Lucas De Marchi
2021-02-18 9:49 ` Lucas De Marchi
2021-02-18 10:50 ` Winkler, Tomas [this message]
2021-02-18 10:50 ` Winkler, Tomas
2021-02-19 6:06 ` Winkler, Tomas
2021-02-19 6:06 ` Winkler, Tomas
2021-02-19 22:59 ` Lucas De Marchi
2021-02-19 22:59 ` Lucas De Marchi
2021-02-20 17:56 ` Winkler, Tomas
2021-02-20 17:56 ` Winkler, Tomas
2021-02-16 18:19 ` [RFC PATCH 4/9] drm/i915/spi: implement region enumeration Tomas Winkler
2021-02-16 18:19 ` [Intel-gfx] " Tomas Winkler
2021-02-16 18:19 ` [RFC PATCH 5/9] drm/i915/spi: implement spi access functions Tomas Winkler
2021-02-16 18:19 ` [Intel-gfx] " Tomas Winkler
2021-02-16 18:19 ` [RFC PATCH 6/9] drm/i915/spi: spi register with mtd Tomas Winkler
2021-02-16 18:19 ` [Intel-gfx] " Tomas Winkler
2021-02-16 18:19 ` [RFC PATCH 7/9] drm/i915/spi: mtd: implement access handlers Tomas Winkler
2021-02-16 18:19 ` [Intel-gfx] " Tomas Winkler
2021-02-16 18:19 ` [RFC PATCH 8/9] drm/i915/spi: serialize spi access Tomas Winkler
2021-02-16 18:19 ` [Intel-gfx] " Tomas Winkler
2021-02-16 18:19 ` [RFC PATCH 9/9] mtd: use refcount to prevent corruption Tomas Winkler
2021-02-16 18:19 ` [Intel-gfx] " Tomas Winkler
2021-02-16 18:45 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/spi: discrete graphics internal spi Patchwork
2021-02-16 18:47 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-02-16 19:14 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-02-16 20:35 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-02-16 23:01 ` [RFC PATCH 0/9] " Richard Weinberger
2021-02-16 23:01 ` [Intel-gfx] " Richard Weinberger
2021-02-17 8:34 ` Winkler, Tomas
2021-02-17 8:34 ` [Intel-gfx] " Winkler, Tomas
2021-02-21 7:10 ` Winkler, Tomas
2021-02-21 7:10 ` [Intel-gfx] " Winkler, Tomas
2021-02-22 22:38 ` Richard Weinberger
2021-02-22 22:38 ` [Intel-gfx] " Richard Weinberger
2021-02-23 6:31 ` Winkler, Tomas
2021-02-23 6:31 ` [Intel-gfx] " Winkler, Tomas
2021-02-28 6:52 ` Winkler, Tomas
2021-02-28 6:52 ` [Intel-gfx] " Winkler, Tomas
2021-02-17 10:36 ` Jani Nikula
2021-02-17 10:36 ` [Intel-gfx] " Jani Nikula
2021-02-17 12:50 ` Winkler, Tomas
2021-02-17 12:50 ` [Intel-gfx] " Winkler, Tomas
2021-02-17 13:35 ` Jani Nikula
2021-02-17 13:35 ` [Intel-gfx] " Jani Nikula
2021-02-17 18:33 ` Rodrigo Vivi
2021-02-17 18:33 ` Rodrigo Vivi
2021-02-17 11:02 ` Jani Nikula
2021-02-17 11:02 ` [Intel-gfx] " Jani Nikula
2021-02-17 13:56 ` Winkler, Tomas
2021-02-17 13:56 ` [Intel-gfx] " Winkler, Tomas
2021-03-01 12:33 ` Jani Nikula
2021-03-01 12:33 ` [Intel-gfx] " Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b21d2b43a98f4947b062fe31bd350566@intel.com \
--to=tomas.winkler@intel.com \
--cc=alexander.usyskin@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-mtd@lists.infradead.org \
--cc=lucas.demarchi@intel.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=rodrigo.vivi@intel.com \
--cc=vigneshr@ti.com \
--cc=vitaly.lubart@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.