From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.de>,
"Jaroslav Kysela" <perex@perex.cz>, Shuah Khan <shuah@kernel.org>
Cc: <alsa-devel@alsa-project.org>, <linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH v1 0/2] kselftest: alsa: Small enhancements to mixer-test
Date: Fri, 17 Dec 2021 16:01:07 +0100 [thread overview]
Message-ID: <b3a299ba-622b-98b3-41fc-a252396bc553@intel.com> (raw)
In-Reply-To: <20211217130213.3893415-1-broonie@kernel.org>
On 2021-12-17 2:02 PM, Mark Brown wrote:
> These two patches improve the mixer test, checking that the default
> values for enums are valid and extending them to cover all the values
> for multi-value controls, not just the first one. It also factors out
> the validation that values are OK for controls for future reuse.
>
> Mark Brown (2):
> kselftest: alsa: Factor out check that values meet constraints
> kselftest: alsa: Validate values read from enumerations
>
> tools/testing/selftests/alsa/mixer-test.c | 158 ++++++++++++++--------
> 1 file changed, 99 insertions(+), 59 deletions(-)
>
>
> base-commit: b73dad806533cad55df41a9c0349969b56d4ff7f
>
Apart from my previous question regarding patch 1/2 (which has been
already answered), I have not found any issues with the series.
Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>
Regards,
Czarek
WARNING: multiple messages have this Message-ID (diff)
From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.de>,
"Jaroslav Kysela" <perex@perex.cz>, Shuah Khan <shuah@kernel.org>
Cc: alsa-devel@alsa-project.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v1 0/2] kselftest: alsa: Small enhancements to mixer-test
Date: Fri, 17 Dec 2021 16:01:07 +0100 [thread overview]
Message-ID: <b3a299ba-622b-98b3-41fc-a252396bc553@intel.com> (raw)
In-Reply-To: <20211217130213.3893415-1-broonie@kernel.org>
On 2021-12-17 2:02 PM, Mark Brown wrote:
> These two patches improve the mixer test, checking that the default
> values for enums are valid and extending them to cover all the values
> for multi-value controls, not just the first one. It also factors out
> the validation that values are OK for controls for future reuse.
>
> Mark Brown (2):
> kselftest: alsa: Factor out check that values meet constraints
> kselftest: alsa: Validate values read from enumerations
>
> tools/testing/selftests/alsa/mixer-test.c | 158 ++++++++++++++--------
> 1 file changed, 99 insertions(+), 59 deletions(-)
>
>
> base-commit: b73dad806533cad55df41a9c0349969b56d4ff7f
>
Apart from my previous question regarding patch 1/2 (which has been
already answered), I have not found any issues with the series.
Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>
Regards,
Czarek
next prev parent reply other threads:[~2021-12-17 15:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 13:02 [PATCH v1 0/2] kselftest: alsa: Small enhancements to mixer-test Mark Brown
2021-12-17 13:02 ` Mark Brown
2021-12-17 13:02 ` [PATCH v1 1/2] kselftest: alsa: Factor out check that values meet constraints Mark Brown
2021-12-17 13:02 ` Mark Brown
2021-12-17 13:32 ` Cezary Rojewski
2021-12-17 13:32 ` Cezary Rojewski
2021-12-17 14:38 ` Mark Brown
2021-12-17 14:38 ` Mark Brown
2021-12-17 14:54 ` Cezary Rojewski
2021-12-17 14:54 ` Cezary Rojewski
2021-12-17 13:02 ` [PATCH v1 2/2] kselftest: alsa: Validate values read from enumerations Mark Brown
2021-12-17 13:02 ` Mark Brown
2021-12-17 15:01 ` Cezary Rojewski [this message]
2021-12-17 15:01 ` [PATCH v1 0/2] kselftest: alsa: Small enhancements to mixer-test Cezary Rojewski
2021-12-25 8:13 ` Takashi Iwai
2021-12-25 8:13 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3a299ba-622b-98b3-41fc-a252396bc553@intel.com \
--to=cezary.rojewski@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=perex@perex.cz \
--cc=shuah@kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.