From: "Michel Dänzer" <michel@daenzer.net>
To: Mark Yacoub <markyacoub@google.com>,
Alex Deucher <alexdeucher@gmail.com>
Cc: "Deucher, Alexander" <alexander.deucher@amd.com>,
Mark Yacoub <markyacoub@chromium.org>,
amd-gfx list <amd-gfx@lists.freedesktop.org>,
Maling list - DRI developers <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/amdgpu: Ensure that the modifier requested is supported by plane.
Date: Wed, 24 Mar 2021 11:13:48 +0100 [thread overview]
Message-ID: <b4070483-5aa5-c712-6435-dcb4a206ca76@daenzer.net> (raw)
In-Reply-To: <CAC0gqY7Y2WxtAZ3GnWmASPYq7ahYTfmPhOHAAX5UjMNS9k098w@mail.gmail.com>
On 2021-03-23 4:32 p.m., Mark Yacoub wrote:
> On Tue, Mar 23, 2021 at 11:02 AM Alex Deucher <alexdeucher@gmail.com> wrote:
>>
>> On Wed, Mar 10, 2021 at 11:15 AM Mark Yacoub <markyacoub@chromium.org> wrote:
>>>
>>> From: Mark Yacoub <markyacoub@google.com>
>>>
>>> On initializing the framebuffer, call drm_any_plane_has_format to do a
>>> check if the modifier is supported. drm_any_plane_has_format calls
>>> dm_plane_format_mod_supported which is extended to validate that the
>>> modifier is on the list of the plane's supported modifiers.
>>>
>>> The bug was caught using igt-gpu-tools test: kms_addfb_basic.addfb25-bad-modifier
>>>
>>> Tested on ChromeOS Zork by turning on the display, running an overlay
>>> test, and running a YT video.
>>>
>>> Cc: Alex Deucher <alexander.deucher@amd.com>
>>> Cc: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
>>> Signed-off-by: default avatarMark Yacoub <markyacoub@chromium.org>
>>
>> I'm not an expert with modifiers yet. Will this break chips which
>> don't currently support modifiers?
> No it shouldn't. When you don't support modifiers yet, your will
> default to Linear Modifier (DRM_FORMAT_MOD_LINEAR),
> [...]
No modifier support does not imply linear. It's generally signalled via DRM_FORMAT_MOD_INVALID, which roughly means "tiling is determined by driver specific mechanisms".
--
Earthling Michel Dänzer | https://redhat.com
Libre software enthusiast | Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: "Michel Dänzer" <michel@daenzer.net>
To: Mark Yacoub <markyacoub@google.com>,
Alex Deucher <alexdeucher@gmail.com>
Cc: "Deucher, Alexander" <alexander.deucher@amd.com>,
Mark Yacoub <markyacoub@chromium.org>,
amd-gfx list <amd-gfx@lists.freedesktop.org>,
Maling list - DRI developers <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/amdgpu: Ensure that the modifier requested is supported by plane.
Date: Wed, 24 Mar 2021 11:13:48 +0100 [thread overview]
Message-ID: <b4070483-5aa5-c712-6435-dcb4a206ca76@daenzer.net> (raw)
In-Reply-To: <CAC0gqY7Y2WxtAZ3GnWmASPYq7ahYTfmPhOHAAX5UjMNS9k098w@mail.gmail.com>
On 2021-03-23 4:32 p.m., Mark Yacoub wrote:
> On Tue, Mar 23, 2021 at 11:02 AM Alex Deucher <alexdeucher@gmail.com> wrote:
>>
>> On Wed, Mar 10, 2021 at 11:15 AM Mark Yacoub <markyacoub@chromium.org> wrote:
>>>
>>> From: Mark Yacoub <markyacoub@google.com>
>>>
>>> On initializing the framebuffer, call drm_any_plane_has_format to do a
>>> check if the modifier is supported. drm_any_plane_has_format calls
>>> dm_plane_format_mod_supported which is extended to validate that the
>>> modifier is on the list of the plane's supported modifiers.
>>>
>>> The bug was caught using igt-gpu-tools test: kms_addfb_basic.addfb25-bad-modifier
>>>
>>> Tested on ChromeOS Zork by turning on the display, running an overlay
>>> test, and running a YT video.
>>>
>>> Cc: Alex Deucher <alexander.deucher@amd.com>
>>> Cc: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
>>> Signed-off-by: default avatarMark Yacoub <markyacoub@chromium.org>
>>
>> I'm not an expert with modifiers yet. Will this break chips which
>> don't currently support modifiers?
> No it shouldn't. When you don't support modifiers yet, your will
> default to Linear Modifier (DRM_FORMAT_MOD_LINEAR),
> [...]
No modifier support does not imply linear. It's generally signalled via DRM_FORMAT_MOD_INVALID, which roughly means "tiling is determined by driver specific mechanisms".
--
Earthling Michel Dänzer | https://redhat.com
Libre software enthusiast | Mesa and X developer
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2021-03-24 10:13 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 16:14 [PATCH] drm/amdgpu: Ensure that the modifier requested is supported by plane Mark Yacoub
2021-03-10 16:14 ` Mark Yacoub
2021-03-22 15:17 ` Mark Yacoub
2021-03-22 15:17 ` Mark Yacoub
2021-03-23 15:02 ` Alex Deucher
2021-03-23 15:02 ` Alex Deucher
2021-03-23 15:32 ` Mark Yacoub
2021-03-23 15:32 ` Mark Yacoub
2021-03-24 10:13 ` Michel Dänzer [this message]
2021-03-24 10:13 ` Michel Dänzer
2021-03-24 10:53 ` Bas Nieuwenhuizen
2021-03-24 10:53 ` Bas Nieuwenhuizen
2021-03-24 12:10 ` Daniel Stone
2021-03-24 12:10 ` Daniel Stone
2021-03-24 14:58 ` Mark Yacoub
2021-03-24 14:58 ` Mark Yacoub
2021-03-24 15:25 ` Daniel Stone
2021-03-24 15:25 ` Daniel Stone
2021-03-24 15:32 ` Mark Yacoub
2021-03-24 15:32 ` Mark Yacoub
2021-03-23 15:08 ` Bas Nieuwenhuizen
2021-03-23 15:08 ` Bas Nieuwenhuizen
2021-03-23 15:34 ` Mark Yacoub
2021-03-23 15:34 ` Mark Yacoub
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4070483-5aa5-c712-6435-dcb4a206ca76@daenzer.net \
--to=michel@daenzer.net \
--cc=alexander.deucher@amd.com \
--cc=alexdeucher@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=markyacoub@chromium.org \
--cc=markyacoub@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.