* [PATCH V3] b43legacy: Fix assigning negative value to unsigned variable
@ 2022-03-25 10:17 Haowen Bai
2022-04-06 12:13 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Haowen Bai @ 2022-03-25 10:17 UTC (permalink / raw)
To: kvalo, davem, kuba, pabeni
Cc: linux-wireless, b43-dev, netdev, linux-kernel, Haowen Bai
fix warning reported by smatch:
drivers/net/wireless/broadcom/b43legacy/phy.c:1181 b43legacy_phy_lo_b_measure()
warn: assigning (-772) to unsigned variable 'fval'
Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
V1->V2: modify title of this patch
V2->V3: modify prefix of title b43legacy
drivers/net/wireless/broadcom/b43legacy/phy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/broadcom/b43legacy/phy.c b/drivers/net/wireless/broadcom/b43legacy/phy.c
index 05404fb..c1395e6 100644
--- a/drivers/net/wireless/broadcom/b43legacy/phy.c
+++ b/drivers/net/wireless/broadcom/b43legacy/phy.c
@@ -1123,7 +1123,7 @@ void b43legacy_phy_lo_b_measure(struct b43legacy_wldev *dev)
struct b43legacy_phy *phy = &dev->phy;
u16 regstack[12] = { 0 };
u16 mls;
- u16 fval;
+ s16 fval;
int i;
int j;
--
2.7.4
_______________________________________________
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH V3] b43legacy: Fix assigning negative value to unsigned variable
2022-03-25 10:17 [PATCH V3] b43legacy: Fix assigning negative value to unsigned variable Haowen Bai
@ 2022-04-06 12:13 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2022-04-06 12:13 UTC (permalink / raw)
To: Haowen Bai
Cc: davem, kuba, pabeni, linux-wireless, b43-dev, netdev,
linux-kernel, Haowen Bai
Haowen Bai <baihaowen@meizu.com> wrote:
> fix warning reported by smatch:
> drivers/net/wireless/broadcom/b43legacy/phy.c:1181 b43legacy_phy_lo_b_measure()
> warn: assigning (-772) to unsigned variable 'fval'
>
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
Patch applied to wireless-next.git, thanks.
3f6b867559b3 b43legacy: Fix assigning negative value to unsigned variable
--
https://patchwork.kernel.org/project/linux-wireless/patch/1648203433-8736-1-git-send-email-baihaowen@meizu.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-06 12:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-25 10:17 [PATCH V3] b43legacy: Fix assigning negative value to unsigned variable Haowen Bai
2022-04-06 12:13 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).