* [PATCH 0773/1285] Replace numeric parameter like 0444 with macro
@ 2016-08-02 11:45 Baole Ni
0 siblings, 0 replies; only message in thread
From: Baole Ni @ 2016-08-02 11:45 UTC (permalink / raw)
To: Larry.Finger, kvalo, bkenward, linux-driver, computersforpeace,
m.chehab, pawel, m.szyprowski, kyungmin.park, k.kozlowski
Cc: linux-wireless, b43-dev, netdev, linux-kernel, chuansheng.liu,
baolex.ni, lars, johannes.berg
I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
drivers/net/wireless/broadcom/b43legacy/sysfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/broadcom/b43legacy/sysfs.c b/drivers/net/wireless/broadcom/b43legacy/sysfs.c
index 2a1da15..e6543ff 100644
--- a/drivers/net/wireless/broadcom/b43legacy/sysfs.c
+++ b/drivers/net/wireless/broadcom/b43legacy/sysfs.c
@@ -150,7 +150,7 @@ static ssize_t b43legacy_attr_interfmode_store(struct device *dev,
return err ? err : count;
}
-static DEVICE_ATTR(interference, 0644,
+static DEVICE_ATTR(interference, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH,
b43legacy_attr_interfmode_show,
b43legacy_attr_interfmode_store);
@@ -203,7 +203,7 @@ static ssize_t b43legacy_attr_preamble_store(struct device *dev,
return count;
}
-static DEVICE_ATTR(shortpreamble, 0644,
+static DEVICE_ATTR(shortpreamble, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH,
b43legacy_attr_preamble_show,
b43legacy_attr_preamble_store);
--
2.9.2
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2016-08-02 11:45 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-02 11:45 [PATCH 0773/1285] Replace numeric parameter like 0444 with macro Baole Ni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).