From: Lee Jones <lee.jones@linaro.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: davem@davemloft.net, kuba@kernel.org,
linux-kernel@vger.kernel.org,
Martin Langer <martin-langer@gmx.de>,
Stefano Brivio <stefano.brivio@polimi.it>,
Michael Buesch <m@bues.ch>, van Dyk <kugelfang@gentoo.org>,
Andreas Jaggi <andreas.jaggi@waterwave.ch>,
Albert Herranz <albert_herranz@yahoo.es>,
linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
netdev@vger.kernel.org
Subject: [PATCH 07/30] net: wireless: broadcom: b43: main: Add braces around empty statements
Date: Mon, 17 Aug 2020 09:50:18 +0100 [thread overview]
Message-ID: <20200817085018.GT4354@dell> (raw)
In-Reply-To: <87eeo9kulw.fsf@codeaurora.org>
On Fri, 14 Aug 2020, Kalle Valo wrote:
> Lee Jones <lee.jones@linaro.org> writes:
>
> > On Fri, 14 Aug 2020, Kalle Valo wrote:
> >
> >> Lee Jones <lee.jones@linaro.org> writes:
> >>
> >> > Fixes the following W=1 kernel build warning(s):
> >> >
> >> > drivers/net/wireless/broadcom/b43/main.c: In function ?b43_dummy_transmission?:
> >> > drivers/net/wireless/broadcom/b43/main.c:785:3: warning: suggest
> >> > braces around empty body in an ?if? statement [-Wempty-body]
> >> > drivers/net/wireless/broadcom/b43/main.c: In function ?b43_do_interrupt_thread?:
> >> > drivers/net/wireless/broadcom/b43/main.c:2017:3: warning: suggest
> >> > braces around empty body in an ?if? statement [-Wempty-body]
> >> >
> >> > Cc: Kalle Valo <kvalo@codeaurora.org>
> >> > Cc: "David S. Miller" <davem@davemloft.net>
> >> > Cc: Jakub Kicinski <kuba@kernel.org>
> >> > Cc: Martin Langer <martin-langer@gmx.de>
> >> > Cc: Stefano Brivio <stefano.brivio@polimi.it>
> >> > Cc: Michael Buesch <m@bues.ch>
> >> > Cc: van Dyk <kugelfang@gentoo.org>
> >> > Cc: Andreas Jaggi <andreas.jaggi@waterwave.ch>
> >> > Cc: Albert Herranz <albert_herranz@yahoo.es>
> >> > Cc: linux-wireless at vger.kernel.org
> >> > Cc: b43-dev at lists.infradead.org
> >> > Cc: netdev at vger.kernel.org
> >> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> >> > ---
> >> > drivers/net/wireless/broadcom/b43/main.c | 6 ++++--
> >> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >>
> >> Please don't copy the full directory structure to the title. I'll change
> >> the title to more simple version:
> >>
> >> b43: add braces around empty statements
> >
> > This seems to go the other way.
> >
> > "net: wireless: b43" seems sensible.
>
> Sorry, not understanding what you mean here.
So I agree that:
"net: wireless: broadcom: b43: main"
... seems unnecessarily long and verbose. However, IMHO:
"b43:"
... is too short and not forthcoming enough. Obviously this fine when
something like `git log -- net/wireless`, as you already know what the
patch pertains to, however when someone who is not in the know (like I
would be) does `git log` and sees a "b43:" patch, they would have no
idea which subsystem this patch is adapting. Even:
"wireless: b43:"
... would be worlds better.
A Git log which omitted all subsystem tags would be of limited use.
> >> I'll do similar changes to other wireless-drivers patches.
> >
> > Thanks.
> >
> > Does that mean it's been applied, or is this future tense?
>
> It's not applied yet, there will be an automatic "applied" email once I
> have done that.
I see. Thanks for the clarification.
--
Lee Jones [???]
Senior Technical Lead - Developer Services
Linaro.org ? Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-08-17 8:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200814113933.1903438-1-lee.jones@linaro.org>
2020-08-14 11:39 ` [PATCH 07/30] net: wireless: broadcom: b43: main: Add braces around empty statements Lee Jones
2020-08-14 15:12 ` Kalle Valo
2020-08-14 16:43 ` Lee Jones
2020-08-14 17:25 ` Kalle Valo
2020-08-17 8:50 ` Lee Jones [this message]
2020-08-27 7:42 ` Kalle Valo
2020-08-27 8:49 ` Lee Jones
2020-08-14 11:39 ` [PATCH 17/30] net: wireless: broadcom: b43legacy: main: Provide braces around empty 'if' body Lee Jones
2020-08-14 11:39 ` [PATCH 26/30] net: wireless: broadcom: b43: phy_common: Demote non-conformant kerneldoc header Lee Jones
[not found] ` <CAJrvBf00yQQ7F1p1utBuq1oWc2RwnqXijBjaJ+FuxG0mS0TvOA@mail.gmail.com>
2020-08-14 16:36 ` Lee Jones
2020-08-17 8:06 ` Rafał Miłecki
2020-08-17 9:11 ` Lee Jones
2020-08-14 11:39 ` [PATCH 30/30] net: wireless: broadcom: b43: phy_n: Add empty braces around empty statements Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200817085018.GT4354@dell \
--to=lee.jones@linaro.org \
--cc=albert_herranz@yahoo.es \
--cc=andreas.jaggi@waterwave.ch \
--cc=b43-dev@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=kugelfang@gentoo.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=m@bues.ch \
--cc=martin-langer@gmx.de \
--cc=netdev@vger.kernel.org \
--cc=stefano.brivio@polimi.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).