From: Lee Jones <lee.jones@linaro.org>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: David Miller <davem@davemloft.net>,
kuba@kernel.org, Michael Buesch <m@bues.ch>,
Stefano Brivio <stefano.brivio@polimi.it>,
Andreas Jaggi <andreas.jaggi@waterwave.ch>,
Network Development <netdev@vger.kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
b43-dev <b43-dev@lists.infradead.org>,
"Alexander A. Klimov" <grandmaster@al2klimov.de>,
Martin Langer <martin-langer@gmx.de>,
van Dyk <kugelfang@gentoo.org>, Kalle Valo <kvalo@codeaurora.org>
Subject: [PATCH 26/30] net: wireless: broadcom: b43: phy_common: Demote non-conformant kerneldoc header
Date: Mon, 17 Aug 2020 10:11:39 +0100 [thread overview]
Message-ID: <20200817091139.GU4354@dell> (raw)
In-Reply-To: <CACna6ryNNyyVftEFNFEwouKc3O21oPaeqie+bjJR4L_Cf8z2BQ@mail.gmail.com>
On Mon, 17 Aug 2020, Rafa? Mi?ecki wrote:
> On Fri, 14 Aug 2020 at 13:41, Lee Jones <lee.jones@linaro.org> wrote:
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/net/wireless/broadcom/b43/phy_common.c:467: warning: Function parameter or member 'work' not described in 'b43_phy_txpower_adjust_work'
>
> Why you can't document @work instead? Should be quite a better solution.
It some circumstances it would, but not this one.
1. This 'kernel-doc' function is not referenced from any
documentation location i.e. it is presently unused and there is no
reason for it to be kernel-doc in the first place.
2. This patch stops `scripts/find-unused-docs.sh` complaining about
phy_common.c
3. 'b43_phy_txpower_adjust_work' is the only function that has been
documented as kernel-doc - why is that? Seems like a mistake.
--
Lee Jones [???]
Senior Technical Lead - Developer Services
Linaro.org ? Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-08-17 9:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200814113933.1903438-1-lee.jones@linaro.org>
2020-08-14 11:39 ` [PATCH 07/30] net: wireless: broadcom: b43: main: Add braces around empty statements Lee Jones
2020-08-14 15:12 ` Kalle Valo
2020-08-14 16:43 ` Lee Jones
2020-08-14 17:25 ` Kalle Valo
2020-08-17 8:50 ` Lee Jones
2020-08-27 7:42 ` Kalle Valo
2020-08-27 8:49 ` Lee Jones
2020-08-14 11:39 ` [PATCH 17/30] net: wireless: broadcom: b43legacy: main: Provide braces around empty 'if' body Lee Jones
2020-08-14 11:39 ` [PATCH 26/30] net: wireless: broadcom: b43: phy_common: Demote non-conformant kerneldoc header Lee Jones
[not found] ` <CAJrvBf00yQQ7F1p1utBuq1oWc2RwnqXijBjaJ+FuxG0mS0TvOA@mail.gmail.com>
2020-08-14 16:36 ` Lee Jones
2020-08-17 8:06 ` Rafał Miłecki
2020-08-17 9:11 ` Lee Jones [this message]
2020-08-14 11:39 ` [PATCH 30/30] net: wireless: broadcom: b43: phy_n: Add empty braces around empty statements Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200817091139.GU4354@dell \
--to=lee.jones@linaro.org \
--cc=andreas.jaggi@waterwave.ch \
--cc=b43-dev@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=grandmaster@al2klimov.de \
--cc=kuba@kernel.org \
--cc=kugelfang@gentoo.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=m@bues.ch \
--cc=martin-langer@gmx.de \
--cc=netdev@vger.kernel.org \
--cc=stefano.brivio@polimi.it \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).