* [PATCH] wireless: broadcom: b43: Fix assigning negative value to unsigned variable
@ 2022-03-24 8:04 Haowen Bai
2022-03-25 10:08 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Haowen Bai @ 2022-03-24 8:04 UTC (permalink / raw)
To: kvalo, davem, kuba, pabeni
Cc: linux-wireless, b43-dev, netdev, linux-kernel, Haowen Bai
fix warning reported by smatch:
drivers/net/wireless/broadcom/b43/phy_n.c:585 b43_nphy_adjust_lna_gain_table()
warn: assigning (-2) to unsigned variable '*(lna_gain[0])'
Signed-off-by: Haowen Bai <baihaowen@meizu.com>
---
drivers/net/wireless/broadcom/b43/phy_n.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/broadcom/b43/phy_n.c b/drivers/net/wireless/broadcom/b43/phy_n.c
index cf3ccf4d..aa5c994 100644
--- a/drivers/net/wireless/broadcom/b43/phy_n.c
+++ b/drivers/net/wireless/broadcom/b43/phy_n.c
@@ -582,7 +582,7 @@ static void b43_nphy_adjust_lna_gain_table(struct b43_wldev *dev)
u16 data[4];
s16 gain[2];
u16 minmax[2];
- static const u16 lna_gain[4] = { -2, 10, 19, 25 };
+ static const s16 lna_gain[4] = { -2, 10, 19, 25 };
if (nphy->hang_avoid)
b43_nphy_stay_in_carrier_search(dev, 1);
--
2.7.4
_______________________________________________
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] wireless: broadcom: b43: Fix assigning negative value to unsigned variable
2022-03-24 8:04 [PATCH] wireless: broadcom: b43: Fix assigning negative value to unsigned variable Haowen Bai
@ 2022-03-25 10:08 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2022-03-25 10:08 UTC (permalink / raw)
To: Haowen Bai
Cc: davem, kuba, pabeni, linux-wireless, b43-dev, netdev, linux-kernel
Haowen Bai <baihaowen@meizu.com> writes:
> fix warning reported by smatch:
> drivers/net/wireless/broadcom/b43/phy_n.c:585 b43_nphy_adjust_lna_gain_table()
> warn: assigning (-2) to unsigned variable '*(lna_gain[0])'
>
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
> drivers/net/wireless/broadcom/b43/phy_n.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
The prefix should be only "b43:", I can fix that.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-25 10:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-24 8:04 [PATCH] wireless: broadcom: b43: Fix assigning negative value to unsigned variable Haowen Bai
2022-03-25 10:08 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).