From: Arvind Yadav <arvind.yadav.cs@gmail.com>
To: Yong Wu <yong.wu@mediatek.com>, Joerg Roedel <joro@8bytes.org>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Robin Murphy <robin.murphy@arm.com>
Cc: Will Deacon <will.deacon@arm.com>,
Daniel Kurtz <djkurtz@google.com>, Tomasz Figa <tfiga@google.com>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
iommu@lists.linux-foundation.org, arnd@arndb.de,
honghui.zhang@mediatek.com, k.zhang@mediatek.com,
cloud.chou@mediatek.com, youlin.pei@mediatek.com
Subject: Re: [PATCH 5/8] iommu/mediatek: Disable iommu clock when system suspend
Date: Fri, 11 Aug 2017 16:39:57 +0530 [thread overview]
Message-ID: <b451cb47-505e-c300-42fd-9cb73c09ef0b@gmail.com> (raw)
In-Reply-To: <1502445377-26936-6-git-send-email-yong.wu@mediatek.com>
Hi Youn,
On Friday 11 August 2017 03:26 PM, Yong Wu wrote:
> When system suspend, infra power domain may be off, and the iommu's
> clock must be disabled when system off, or the iommu's bclk clock maybe
> disabled after system resume.
>
> Signed-off-by: Honghui Zhang <honghui.zhang@mediatek.com>
> Signed-off-by: Yong Wu <yong.wu@mediatek.com>
> ---
> drivers/iommu/mtk_iommu.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c
> index e81ed9a..b7c8e52 100644
> --- a/drivers/iommu/mtk_iommu.c
> +++ b/drivers/iommu/mtk_iommu.c
> @@ -675,6 +675,7 @@ static int __maybe_unused mtk_iommu_suspend(struct device *dev)
> reg->ctrl_reg = readl_relaxed(base + REG_MMU_CTRL_REG);
> reg->int_control0 = readl_relaxed(base + REG_MMU_INT_CONTROL0);
> reg->int_main_control = readl_relaxed(base + REG_MMU_INT_MAIN_CONTROL);
> + clk_disable_unprepare(data->bclk);
> return 0;
> }
>
> @@ -684,6 +685,7 @@ static int __maybe_unused mtk_iommu_resume(struct device *dev)
> struct mtk_iommu_suspend_reg *reg = &data->reg;
> void __iomem *base = data->base;
>
> + clk_prepare_enable(data->bclk);
Please handle return value of clk_prepare_enable. It can fail
> writel_relaxed(reg->standard_axi_mode,
> base + REG_MMU_STANDARD_AXI_MODE);
> writel_relaxed(reg->dcm_dis, base + REG_MMU_DCM_DIS);
> @@ -699,7 +701,7 @@ static int __maybe_unused mtk_iommu_resume(struct device *dev)
> }
>
> static const struct dev_pm_ops mtk_iommu_pm_ops = {
> - SET_SYSTEM_SLEEP_PM_OPS(mtk_iommu_suspend, mtk_iommu_resume)
> + SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(mtk_iommu_suspend, mtk_iommu_resume)
> };
>
> static const struct of_device_id mtk_iommu_of_ids[] = {
~arvind
WARNING: multiple messages have this Message-ID (diff)
From: arvind.yadav.cs@gmail.com (Arvind Yadav)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/8] iommu/mediatek: Disable iommu clock when system suspend
Date: Fri, 11 Aug 2017 16:39:57 +0530 [thread overview]
Message-ID: <b451cb47-505e-c300-42fd-9cb73c09ef0b@gmail.com> (raw)
In-Reply-To: <1502445377-26936-6-git-send-email-yong.wu@mediatek.com>
Hi Youn,
On Friday 11 August 2017 03:26 PM, Yong Wu wrote:
> When system suspend, infra power domain may be off, and the iommu's
> clock must be disabled when system off, or the iommu's bclk clock maybe
> disabled after system resume.
>
> Signed-off-by: Honghui Zhang <honghui.zhang@mediatek.com>
> Signed-off-by: Yong Wu <yong.wu@mediatek.com>
> ---
> drivers/iommu/mtk_iommu.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c
> index e81ed9a..b7c8e52 100644
> --- a/drivers/iommu/mtk_iommu.c
> +++ b/drivers/iommu/mtk_iommu.c
> @@ -675,6 +675,7 @@ static int __maybe_unused mtk_iommu_suspend(struct device *dev)
> reg->ctrl_reg = readl_relaxed(base + REG_MMU_CTRL_REG);
> reg->int_control0 = readl_relaxed(base + REG_MMU_INT_CONTROL0);
> reg->int_main_control = readl_relaxed(base + REG_MMU_INT_MAIN_CONTROL);
> + clk_disable_unprepare(data->bclk);
> return 0;
> }
>
> @@ -684,6 +685,7 @@ static int __maybe_unused mtk_iommu_resume(struct device *dev)
> struct mtk_iommu_suspend_reg *reg = &data->reg;
> void __iomem *base = data->base;
>
> + clk_prepare_enable(data->bclk);
Please handle return value of clk_prepare_enable. It can fail
> writel_relaxed(reg->standard_axi_mode,
> base + REG_MMU_STANDARD_AXI_MODE);
> writel_relaxed(reg->dcm_dis, base + REG_MMU_DCM_DIS);
> @@ -699,7 +701,7 @@ static int __maybe_unused mtk_iommu_resume(struct device *dev)
> }
>
> static const struct dev_pm_ops mtk_iommu_pm_ops = {
> - SET_SYSTEM_SLEEP_PM_OPS(mtk_iommu_suspend, mtk_iommu_resume)
> + SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(mtk_iommu_suspend, mtk_iommu_resume)
> };
>
> static const struct of_device_id mtk_iommu_of_ids[] = {
~arvind
next prev parent reply other threads:[~2017-08-11 11:10 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-11 9:56 [PATCH 0/8] MT2712 IOMMU SUPPORT Yong Wu
2017-08-11 9:56 ` Yong Wu
2017-08-11 9:56 ` Yong Wu
2017-08-11 9:56 ` [PATCH 1/8] dt-bindings: mediatek: Add binding for mt2712 IOMMU and SMI Yong Wu
2017-08-11 9:56 ` Yong Wu
2017-08-11 9:56 ` Yong Wu
2017-08-17 15:33 ` Rob Herring
2017-08-17 15:33 ` Rob Herring
2017-08-17 15:33 ` Rob Herring
2017-08-11 9:56 ` [PATCH 2/8] iommu/mediatek: Add mt2712 IOMMU support Yong Wu
2017-08-11 9:56 ` Yong Wu
2017-08-11 9:56 ` Yong Wu
2017-08-11 17:24 ` Robin Murphy
2017-08-11 17:24 ` Robin Murphy
2017-08-11 17:24 ` Robin Murphy
2017-08-12 10:04 ` Yong Wu
2017-08-12 10:04 ` Yong Wu
2017-08-12 10:04 ` Yong Wu
2017-08-11 9:56 ` [PATCH 3/8] iommu/mediatek: Merge 2 M4U HWs into one iommu domain Yong Wu
2017-08-11 9:56 ` Yong Wu
2017-08-11 9:56 ` Yong Wu
2017-08-11 9:56 ` [PATCH 4/8] iommu/mediatek: Move pgtable allocation into domain_alloc Yong Wu
2017-08-11 9:56 ` Yong Wu
2017-08-11 9:56 ` Yong Wu
2017-08-11 9:56 ` [PATCH 5/8] iommu/mediatek: Disable iommu clock when system suspend Yong Wu
2017-08-11 9:56 ` Yong Wu
2017-08-11 9:56 ` Yong Wu
2017-08-11 11:09 ` Arvind Yadav [this message]
2017-08-11 11:09 ` Arvind Yadav
2017-08-12 9:34 ` Yong Wu
2017-08-12 9:34 ` Yong Wu
2017-08-12 9:34 ` Yong Wu
2017-08-11 9:56 ` [PATCH 6/8] iommu/mediatek: Enlarge the validate PA range for 4GB mode Yong Wu
2017-08-11 9:56 ` Yong Wu
2017-08-11 9:56 ` Yong Wu
2017-08-11 9:56 ` [PATCH 7/8] memory: mtk-smi: Rearrange some function position alphabetically Yong Wu
2017-08-11 9:56 ` Yong Wu
2017-08-11 9:56 ` Yong Wu
2017-08-11 18:09 ` Robin Murphy
2017-08-11 18:09 ` Robin Murphy
2017-08-11 18:09 ` Robin Murphy
2017-08-12 9:36 ` Yong Wu
2017-08-12 9:36 ` Yong Wu
2017-08-12 9:36 ` Yong Wu
2017-08-11 9:56 ` [PATCH 8/8] memory: mtk-smi: Degrade SMI init to module_init Yong Wu
2017-08-11 9:56 ` Yong Wu
2017-08-11 9:56 ` Yong Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b451cb47-505e-c300-42fd-9cb73c09ef0b@gmail.com \
--to=arvind.yadav.cs@gmail.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=cloud.chou@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=djkurtz@google.com \
--cc=honghui.zhang@mediatek.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=k.zhang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@google.com \
--cc=will.deacon@arm.com \
--cc=yong.wu@mediatek.com \
--cc=youlin.pei@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.