From: "Raja, Tamizh Chelvam" <c_traja@qti.qualcomm.com>
To: Johannes Berg <johannes@sipsolutions.net>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: RE: [PATCHv2 3/4] cfg80211: Add Support set btcoex priority value
Date: Thu, 2 Mar 2017 11:48:48 +0000 [thread overview]
Message-ID: <b55e902d1a5445feb3058cee1118ae39@aphydexm01f.ap.qualcomm.com> (raw)
In-Reply-To: <1488444659.8390.8.camel@sipsolutions.net>
PiBJcyB0aGVyZSBtdWNoIHBvaW50IGluIGhhdmluZyA0IHJhdGhlciB0aGFuIGp1c3QgMiBwYXRj
aGVzPw0KPg0KW1RhbWl6aF0gWWVzLCBJIGFncmVlIHRvIGl0LiANCj4gDQo+ID4gKwlpbnTCoMKg
wqDCoMKgKCpzZXRfYnRjb2V4KShzdHJ1Y3Qgd2lwaHkgKndpcGh5LCBib29sIGVuYWJsZWQsDQo+
ID4gKwkJCcKgwqDCoMKgwqDCoGludCBidGNvZXhfcHJpb3JpdHkpOw0KPiANCj4gU2hvdWxkbid0
IHRoYXQgYmUgdTMyIGFzIGEgYml0bWFwPw0KPiANCltUYW1pemhdIFllcy4NCg0KPiA+ICsJYm9v
bCBidGNvZXhfcHJpb3JpdHlfc3VwcG9ydDsNCj4gDQo+IFdoeSBub3QgdXNlIGFuIGV4dGVuZGVk
IG5sODAyMTEgZmVhdHVyZSBmbGFnIGRpcmVjdGx5Pw0KPiANCltUYW1pemhdIE9rIHN1cmUuIEkn
bGwgdXNlIGV4dGVuZGVkIG5sODAyMTEgZmVhdHVyZSBmbGFnLg0KDQo+ID4gKyAqIEBOTDgwMjEx
X0FUVFJfQlRDT0VYX1BSSU9SSVRZOiBUaGlzIGlzIGZvciB0aGUgZHJpdmVyIHdoaWNoDQo+ID4g
KyAqwqDCoMKgwqDCoHN1cHBvcnQgYnRjb2V4IHByaW9yaXR5IGZlYXR1cmUuIEl0IHVzZWQgd2l0
aA0KPiA+ICVOTDgwMjExX0NNRF9TRVRfQlRDT0VYLg0KPiA+ICsgKsKgwqDCoMKgwqBUaGlzIHdp
bGwgaGF2ZSB1MzIgQklUTUFQIHZhbHVlIHdoaWNoIHJlcHJlc2VudHMNCj4gPiArICrCoMKgwqDC
oMKgZnJhbWUoYmssIGJlLCB2aSwgdm8sIG1nbXQsIGJlYWNvbikgdHlwZSBhbmQgdGhhdCB3aWxs
IGhhdmUNCj4gPiBtb3JlDQo+ID4gKyAqwqDCoMKgwqDCoHByaW9yaXR5IHRoYW4gYSBCVCB0cmFm
ZmljLg0KPiANCj4gSSB0aGluayB5b3UgbmVlZCB0byBkZWZpbmUgdGhlIGJpdHMgc29tZXdoZXJl
IGluIGFuIGVudW0gLSBpLmUuIHdoaWNoIG9uZSBpcyBWTywNCj4gVkksIC4uLg0KPg0KW1RhbWl6
aF0gb2sgc3VyZS4gSXMgdGhpcyBmb3IgZG9jdW1lbnRhdGlvbiBwdXJwb3NlIG9yIGRvIHlvdSB3
YW50IG1lIHRvIHVzZSB0aGF0IA0KZW51bSBmb3Igc29tZXRoaW5nIGVsc2U/DQogDQo+ID4gKwlp
bnQgYnRjb2V4X3ByaW9yaXR5ID0gLTE7DQo+IA0KPiBUaGF0IC0xIGlzIHByZXR0eSB1c2VsZXNz
LCBpZiB0aGUgZHJpdmVyIGRvZXNuJ3Qgc3VwcG9ydCBpdCwgaG9wZWZ1bGx5IGl0IHdvbid0IGxv
b2sNCj4gYXQgdGhlIHZhbHVlIGF0IGFsbD8NCj4gDQpbVGFtaXpoXSBPayBzdXJlDQo=
WARNING: multiple messages have this Message-ID (diff)
From: "Raja, Tamizh Chelvam" <c_traja@qti.qualcomm.com>
To: Johannes Berg <johannes@sipsolutions.net>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: RE: [PATCHv2 3/4] cfg80211: Add Support set btcoex priority value
Date: Thu, 2 Mar 2017 11:48:48 +0000 [thread overview]
Message-ID: <b55e902d1a5445feb3058cee1118ae39@aphydexm01f.ap.qualcomm.com> (raw)
In-Reply-To: <1488444659.8390.8.camel@sipsolutions.net>
> Is there much point in having 4 rather than just 2 patches?
>
[Tamizh] Yes, I agree to it.
>
> > + int (*set_btcoex)(struct wiphy *wiphy, bool enabled,
> > + int btcoex_priority);
>
> Shouldn't that be u32 as a bitmap?
>
[Tamizh] Yes.
> > + bool btcoex_priority_support;
>
> Why not use an extended nl80211 feature flag directly?
>
[Tamizh] Ok sure. I'll use extended nl80211 feature flag.
> > + * @NL80211_ATTR_BTCOEX_PRIORITY: This is for the driver which
> > + * support btcoex priority feature. It used with
> > %NL80211_CMD_SET_BTCOEX.
> > + * This will have u32 BITMAP value which represents
> > + * frame(bk, be, vi, vo, mgmt, beacon) type and that will have
> > more
> > + * priority than a BT traffic.
>
> I think you need to define the bits somewhere in an enum - i.e. which one is VO,
> VI, ...
>
[Tamizh] ok sure. Is this for documentation purpose or do you want me to use that
enum for something else?
> > + int btcoex_priority = -1;
>
> That -1 is pretty useless, if the driver doesn't support it, hopefully it won't look
> at the value at all?
>
[Tamizh] Ok sure
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2017-03-02 11:49 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-25 13:37 [PATCHv2 0/4] cfg80211: mac80211: BTCOEX feature support c_traja
2017-02-25 13:37 ` c_traja
2017-02-25 13:37 ` [PATCHv2 1/4] cfg80211: Add support to enable or disable btcoex c_traja
2017-02-25 13:37 ` c_traja
2017-02-25 14:48 ` kbuild test robot
2017-02-25 14:48 ` kbuild test robot
2017-02-25 14:48 ` kbuild test robot
2017-02-25 14:48 ` kbuild test robot
2017-03-02 8:45 ` Johannes Berg
2017-03-02 8:45 ` Johannes Berg
2017-03-02 11:49 ` Raja, Tamizh Chelvam
2017-03-02 11:49 ` Raja, Tamizh Chelvam
2017-02-25 13:37 ` [PATCHv2 2/4] mac80211: " c_traja
2017-02-25 13:37 ` c_traja
2017-02-25 13:37 ` [PATCHv2 3/4] cfg80211: Add Support set btcoex priority value c_traja
2017-02-25 13:37 ` c_traja
2017-02-25 15:12 ` kbuild test robot
2017-02-25 15:12 ` kbuild test robot
2017-03-02 8:50 ` Johannes Berg
2017-03-02 8:50 ` Johannes Berg
2017-03-02 11:48 ` Raja, Tamizh Chelvam [this message]
2017-03-02 11:48 ` Raja, Tamizh Chelvam
2017-03-02 12:15 ` Johannes Berg
2017-03-02 12:15 ` Johannes Berg
2017-03-02 13:08 ` Raja, Tamizh Chelvam
2017-03-02 13:08 ` Raja, Tamizh Chelvam
2017-03-02 13:43 ` Johannes Berg
2017-03-02 13:43 ` Johannes Berg
2017-03-02 8:51 ` Johannes Berg
2017-03-02 8:51 ` Johannes Berg
2017-02-25 13:37 ` [PATCHv2 4/4] mac80211: Add support to set/update " c_traja
2017-02-25 13:37 ` c_traja
2017-02-25 14:41 ` [PATCHv2 0/4] cfg80211: mac80211: BTCOEX feature support Arend Van Spriel
2017-02-25 14:41 ` Arend Van Spriel
2017-02-27 10:33 ` Raja, Tamizh Chelvam
2017-02-27 10:33 ` Raja, Tamizh Chelvam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b55e902d1a5445feb3058cee1118ae39@aphydexm01f.ap.qualcomm.com \
--to=c_traja@qti.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.