From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Miaoqian Lin <linmq006@gmail.com>, Yong Wu <yong.wu@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Ikjoon Jang <ikjn@chromium.org>,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] memory: mtk-smi: add missing put_device() call in mtk_smi_device_link_common
Date: Mon, 6 Jun 2022 11:16:46 +0200 [thread overview]
Message-ID: <b6cc31fe-1d71-376b-31ad-a149d2224d53@linaro.org> (raw)
In-Reply-To: <20220601120118.60225-1-linmq006@gmail.com>
On 01/06/2022 14:01, Miaoqian Lin wrote:
> The reference taken by 'of_find_device_by_node()' must be released when
> not needed anymore.
> Add the corresponding 'put_device()' in the error handling paths.
>
> Fixes: 4740475 ("memory: mtk-smi: Add device link for smi-sub-common")
This is not correct SHA. Read:
Documentation/process/submitting-patches.rst
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Miaoqian Lin <linmq006@gmail.com>, Yong Wu <yong.wu@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Ikjoon Jang <ikjn@chromium.org>,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] memory: mtk-smi: add missing put_device() call in mtk_smi_device_link_common
Date: Mon, 6 Jun 2022 11:16:46 +0200 [thread overview]
Message-ID: <b6cc31fe-1d71-376b-31ad-a149d2224d53@linaro.org> (raw)
In-Reply-To: <20220601120118.60225-1-linmq006@gmail.com>
On 01/06/2022 14:01, Miaoqian Lin wrote:
> The reference taken by 'of_find_device_by_node()' must be released when
> not needed anymore.
> Add the corresponding 'put_device()' in the error handling paths.
>
> Fixes: 4740475 ("memory: mtk-smi: Add device link for smi-sub-common")
This is not correct SHA. Read:
Documentation/process/submitting-patches.rst
Best regards,
Krzysztof
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Miaoqian Lin <linmq006@gmail.com>, Yong Wu <yong.wu@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Ikjoon Jang <ikjn@chromium.org>,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] memory: mtk-smi: add missing put_device() call in mtk_smi_device_link_common
Date: Mon, 6 Jun 2022 11:16:46 +0200 [thread overview]
Message-ID: <b6cc31fe-1d71-376b-31ad-a149d2224d53@linaro.org> (raw)
In-Reply-To: <20220601120118.60225-1-linmq006@gmail.com>
On 01/06/2022 14:01, Miaoqian Lin wrote:
> The reference taken by 'of_find_device_by_node()' must be released when
> not needed anymore.
> Add the corresponding 'put_device()' in the error handling paths.
>
> Fixes: 4740475 ("memory: mtk-smi: Add device link for smi-sub-common")
This is not correct SHA. Read:
Documentation/process/submitting-patches.rst
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-06 9:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-01 12:01 [PATCH v2] memory: mtk-smi: add missing put_device() call in mtk_smi_device_link_common Miaoqian Lin
2022-06-01 12:01 ` Miaoqian Lin
2022-06-01 12:01 ` Miaoqian Lin
2022-06-06 9:16 ` Krzysztof Kozlowski [this message]
2022-06-06 9:16 ` Krzysztof Kozlowski
2022-06-06 9:16 ` Krzysztof Kozlowski
2022-06-06 9:20 ` Krzysztof Kozlowski
2022-06-06 9:20 ` Krzysztof Kozlowski
2022-06-06 9:20 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6cc31fe-1d71-376b-31ad-a149d2224d53@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=ikjn@chromium.org \
--cc=linmq006@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=yong.wu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.