From: Shawn Lin <shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
To: Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Lorenzo Pieralisi
<lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org>,
linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Bjorn Helgaas <helgaas-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Bjorn Helgaas <bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH v3 1/6] PCI: rockchip: Create individual folder for rockchip drivers
Date: Thu, 22 Mar 2018 19:09:14 +0800 [thread overview]
Message-ID: <b8173dd9-6cf3-ceaf-4293-655e1a5199a4@rock-chips.com> (raw)
In-Reply-To: <20180322084735.GC6211-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
On 2018/3/22 16:47, Greg Kroah-Hartman wrote:
> On Thu, Mar 22, 2018 at 09:03:58AM +0800, Shawn Lin wrote:
...
> USB is "messy" in that we have hardware that acts both as a host and a
> gadget controller. Don't use our directory scheme as an example to do
> anything :)
>
Thanks for comment.
> Do what is right for the PCI subsystem, if a driver is too "complex"
> that it needs lots of different files, make a subdirectory to make it
Clearly it't not too complex for PCI now, so I think we don't need
seperate directory for each controller.
> easier to manage. That's all we did for USB, nothing really complex.
>
> good luck!
>
> greg k-h
>
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Lin <shawn.lin@rock-chips.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: shawn.lin@rock-chips.com,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Bjorn Helgaas <helgaas@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v3 1/6] PCI: rockchip: Create individual folder for rockchip drivers
Date: Thu, 22 Mar 2018 19:09:14 +0800 [thread overview]
Message-ID: <b8173dd9-6cf3-ceaf-4293-655e1a5199a4@rock-chips.com> (raw)
In-Reply-To: <20180322084735.GC6211@kroah.com>
On 2018/3/22 16:47, Greg Kroah-Hartman wrote:
> On Thu, Mar 22, 2018 at 09:03:58AM +0800, Shawn Lin wrote:
...
> USB is "messy" in that we have hardware that acts both as a host and a
> gadget controller. Don't use our directory scheme as an example to do
> anything :)
>
Thanks for comment.
> Do what is right for the PCI subsystem, if a driver is too "complex"
> that it needs lots of different files, make a subdirectory to make it
Clearly it't not too complex for PCI now, so I think we don't need
seperate directory for each controller.
> easier to manage. That's all we did for USB, nothing really complex.
>
> good luck!
>
> greg k-h
>
>
>
next prev parent reply other threads:[~2018-03-22 11:09 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 2:42 [PATCH v3 0/6] Add endpoint driver for Rockchip PCIe controller Shawn Lin
2018-03-06 2:42 ` Shawn Lin
[not found] ` <1520304173-231081-1-git-send-email-shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-03-06 2:43 ` [PATCH v3 1/6] PCI: rockchip: Create individual folder for rockchip drivers Shawn Lin
2018-03-06 2:43 ` Shawn Lin
[not found] ` <1520304202-232891-1-git-send-email-shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-03-20 14:04 ` Lorenzo Pieralisi
2018-03-20 14:04 ` Lorenzo Pieralisi
[not found] ` <20180320140431.GA15953-4tUPXFaYRHv6sAKXYmQ0tx/iLCjYCKR+VpNB7YpNyf8@public.gmane.org>
2018-03-21 0:47 ` Shawn Lin
2018-03-21 0:47 ` Shawn Lin
2018-03-20 17:46 ` Bjorn Helgaas
2018-03-20 17:46 ` Bjorn Helgaas
[not found] ` <20180320174633.GA137590-1RhO1Y9PlrlHTL0Zs8A6p5iNqAH0jzoTYJqu5kTmcBRl57MIdRCFDg@public.gmane.org>
2018-03-21 1:04 ` Shawn Lin
2018-03-21 1:04 ` Shawn Lin
[not found] ` <879a4862-d0d5-21fd-6c47-029c795fe78e-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-03-21 18:19 ` Lorenzo Pieralisi
2018-03-21 18:19 ` Lorenzo Pieralisi
[not found] ` <20180321181940.GA9760-4tUPXFaYRHv6sAKXYmQ0tx/iLCjYCKR+VpNB7YpNyf8@public.gmane.org>
2018-03-21 19:30 ` Bjorn Helgaas
2018-03-21 19:30 ` Bjorn Helgaas
2018-03-22 1:03 ` Shawn Lin
2018-03-22 1:03 ` Shawn Lin
[not found] ` <7275bd77-016a-2729-482d-2855703d9b56-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-03-22 8:47 ` Greg Kroah-Hartman
2018-03-22 8:47 ` Greg Kroah-Hartman
[not found] ` <20180322084735.GC6211-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2018-03-22 11:09 ` Shawn Lin [this message]
2018-03-22 11:09 ` Shawn Lin
2018-03-22 11:30 ` Lorenzo Pieralisi
2018-03-22 11:30 ` Lorenzo Pieralisi
2018-03-06 2:43 ` [PATCH v3 2/6] PCI: rockchip: Split out common function to parse DT Shawn Lin
2018-03-06 2:43 ` Shawn Lin
2018-03-06 2:43 ` [PATCH v3 3/6] PCI: rockchip: Split out common function to init controller Shawn Lin
2018-03-06 2:43 ` Shawn Lin
2018-03-06 2:43 ` [PATCH v3 4/6] dt-bindings: PCI: rockchip: Rename rockchip-pcie.txt to rockchip-pcie-host.txt Shawn Lin
2018-03-06 2:43 ` Shawn Lin
2018-03-06 2:44 ` [PATCH v3 5/6] PCI: rockchip: Add Endpoint controller driver for Rockchip PCIe controller Shawn Lin
2018-03-06 2:44 ` Shawn Lin
2018-03-06 2:44 ` [PATCH v3 6/6] dt-bindings: PCI: rockchip: Add DT bindings for Rockchip PCIe endpoint controller Shawn Lin
2018-03-06 2:44 ` Shawn Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8173dd9-6cf3-ceaf-4293-655e1a5199a4@rock-chips.com \
--to=shawn.lin-tnx95d0mmh7dzftrwevzcw@public.gmane.org \
--cc=bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=helgaas-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.